From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 54F163858423 for ; Tue, 14 Nov 2023 20:26:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 54F163858423 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 54F163858423 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699993611; cv=none; b=LpvdRMrkFhvnJxgANmKW9PhNtRnKYvcm1NOUPAIgwcHG9+wDMRlKxpKhUD5sqY4889fDPIOBBXQX8k/QqLQAFC+xkpTwhszH7u2uQUKTLR9RbrakPPg2Smlm4hOQgEPVWWqtR1PPzsueQIMiCwprbdyHVkNOL5BkLhaEafoxokw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699993611; c=relaxed/simple; bh=J6m0vZsREI2Qvvrrk3yf14KEj7T4GVADOiRPPiKBlG4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=aGZ8A3e5DLvtOaI8cmAo/TShKt4beDOaxDG5SxoipUlWpAHgHZo4js4JReMTJHX02BoZSV340AEuinZYXz/Dmuw8fVKJqG0CjJk6wH4clu5dwQTvX46IQGZfEIaL0StvOz+9ACp4n2cCG9bp7unyNTEHgQmI71foGcleOiFtyk0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699993610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YnrKb8aPkbeqSgKglg56MjKtvuVTJljJj/rVdRKxbVM=; b=HbGPZ1P4VFbeGMFwTRdYP0qsAITyIP+GeJQjViV6ycTHXtWzfr8+i+vFTmQdjtMAQgZo3x ZQLlOZuWp5vONMgKdHHGJwpmr/3B5c3XBfrFpFnrZfEn6khiDJChPN5kdicNmhgEYuHMKX ihzdRfxIvIerfeA3JaX9oONOG1r8pU4= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-b7ZTo5x3PM26z22nGoMWyw-1; Tue, 14 Nov 2023 15:26:46 -0500 X-MC-Unique: b7ZTo5x3PM26z22nGoMWyw-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-779f645c74cso654693285a.0 for ; Tue, 14 Nov 2023 12:26:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699993606; x=1700598406; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YnrKb8aPkbeqSgKglg56MjKtvuVTJljJj/rVdRKxbVM=; b=E3tzgBqv8aExDUHg1jhNtT2VPAoqaaSqG21PLq2njyE2RWNWaTbHjXXp0Xr9Iat68+ QoI/iGfvoohaN7bGKGWJKM+j36cyVbfOkZqYRGcVCD0C39fL7NL1Hp3AzM8M/DcoXvir rD5h8XiezvZKTR7jMWVYBj3QvNC+yYg8nQpR11okM7PiBPPKtzHc5DlzSC+fBAIifnIB ZMAWOT8fD+/xxn2LyjUe6CPZhb0tCA1Yeis3kUFFVI6eRab8s57pQpu/4ZEVQYdrfpGY +Z9rYwsEH5ntnztEUqrFjVw+QgZEetIwVDniuqUOwvFRSvJfFOlFemzimqW1ECZ7SRPP rhfQ== X-Gm-Message-State: AOJu0YySQu0P4edDZd62OCQd3Qf6S5s+ZFP1ELpaqIje5acic0BnHBVQ J3CakT3mOwL3Nrv3VOf1iwVVkZC7vZGuvzqEJSny9rFhWKZjrtMrkWmZ6nmGBubePczK0fVSv0F na5OaLdD6DMdyQR1QSw== X-Received: by 2002:a05:620a:3705:b0:77b:956b:3683 with SMTP id de5-20020a05620a370500b0077b956b3683mr3855439qkb.51.1699993606256; Tue, 14 Nov 2023 12:26:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrBPsLD4kVemdc/wo7KHPfknQ9NJ/v2kAA7YpYyTcb8hJ6LfPen7/Hb8xj87HL1Hf4AkHmDQ== X-Received: by 2002:a05:620a:3705:b0:77b:956b:3683 with SMTP id de5-20020a05620a370500b0077b956b3683mr3855426qkb.51.1699993606012; Tue, 14 Nov 2023 12:26:46 -0800 (PST) Received: from redhat.com (2603-7000-9500-34a5-0000-0000-0000-1db4.res6.spectrum.com. [2603:7000:9500:34a5::1db4]) by smtp.gmail.com with ESMTPSA id qz6-20020a05620a8c0600b00774292e636dsm2907812qkn.63.2023.11.14.12.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 12:26:45 -0800 (PST) Date: Tue, 14 Nov 2023 15:26:43 -0500 From: Marek Polacek To: Florian Weimer Cc: gcc-patches@gcc.gnu.org, jason@redhat.com, jeffreyalaw@gmail.com, joseph@codesourcery.com, sam@gentoo.org Subject: Re: [PATCH v2 8/8] c: Add new -Wdeclaration-missing-parameter-type permerror Message-ID: References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Nov 14, 2023 at 06:50:58PM +0100, Florian Weimer wrote: > --- a/gcc/c-family/c.opt > +++ b/gcc/c-family/c.opt > @@ -591,6 +591,10 @@ Wdeclaration-after-statement > C ObjC Var(warn_declaration_after_statement) Init(-1) Warning > Warn when a declaration is found after a statement. > > +Wdeclaration-missing-parameter-type > +C ObjC Warning > +Warn for missing parameter types in function declarations. > + This doesn't have Var(warn_declaration_missing_parameter), so -fpermissive -Wno-declaration-missing-parameter-type still warns for void foo (i); where I think the warning should be suppressed. Is that expected? It would be nice to have a test for that combination. Marek