From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) by sourceware.org (Postfix) with ESMTPS id 33DB8385841A for ; Sun, 19 Nov 2023 14:31:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 33DB8385841A Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=ucw.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kam.mff.cuni.cz ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 33DB8385841A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.113.20.16 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700404271; cv=none; b=dCriHMypk7+nWP75x7GFxw583n5M5bIbk0GbO1m6HSldRrS0Mz75nLzBaHnrHvPbpNEyLetxhuZLhUI7yCc7eT/0l+K/r/MaWfD6tA7v+tIc6jVnW2xqAQXQ37K0mS0zrxeH2JSIEFhEXbJwgrwx0GiJGpYkxmAQD4ttwzDAREE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700404271; c=relaxed/simple; bh=z7r+JrReBf8SAZGtoJxl6WftKoe4Zfjy3jM1JhvYqas=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=n9FPpp+6qGD5Kw75u8W/s+8kRbKOQqE52mUEbzNusEwwmHlhGs84zH5QH1ftx7Jk2Ymz8YorOXscSsFkPVv9hLkTjh1hYq/e/KwX2xy3jJV/PAR3NPIKF96kuL2iXtzowJtQ/gz+nGXfsL2uipMn2EiWluu1K5WF9EqKzWrcCwM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id C5E2428B819; Sun, 19 Nov 2023 15:31:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1700404268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lBIkBJwK/cun+iErWWJMTUC843HbykBSk4E46z0A1sY=; b=YjG1xNOCyubSCTZ1w84TB3i6pYLHmM9P6ZtJVDdtGyf54krsaWk7wOmE66BonfcV0nlOzn wesasNGyxBsYhOwZHaHxoeEkZdk5j7FXG3tj4mvYzOfnUZGu9eFSjR+TmgQ2EIL+U70yXw T8+KKfTFPUUaEjl0MEfOZgMdZNvRoCo= Date: Sun, 19 Nov 2023 15:31:08 +0100 From: Jan Hubicka To: Sam James Cc: gcc-patches@gcc.gnu.org Subject: Re: Propagate value ranges of return values Message-ID: References: <871qcmkmgd.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871qcmkmgd.fsf@gentoo.org> X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > > +Wsuggest-attribute=returns_nonnull > > - or _? > > (If changing it, needs adjustment in rest of patch too.) I was thinking of this and I am not sure what is better. Sure _ in command line option looks odd, but this is an identifier and it is returns_nonnull and not returns-nonnull. I am not sure we have earlier situation like that. I can live with both variants and would be happy to hear opinions on this. > > > +Common Var(warn_suggest_attribute_malloc) Warning > > +Warn about functions which might be candidates for __attribute__((malloc)). > > + > > Typo: s/malloc/nonnull/? Thanks! Honza