From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) by sourceware.org (Postfix) with ESMTPS id 5F9B13858D39 for ; Tue, 21 Nov 2023 12:18:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F9B13858D39 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=ucw.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kam.mff.cuni.cz ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5F9B13858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.113.20.16 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700569094; cv=none; b=ingJLJ5YOmKmDm8XX/q4XnMqEPhKWRsxUXj+QzWIz94Itx56Vjl91L6TpUrBmfSV1MlkB4N/8xwK8pEIIvmYdr3SsqX7p+653TnOX5Mnc0L2rSp3JsjNsBzVwtda+V30Yeiz/VAAPS+txvTM/cjrkcLvLPQMb5dk7F9a8SgctUw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700569094; c=relaxed/simple; bh=0NBKidX9RnOj0EuIMNVDZGXo2emjHvEcXW7fhMSEJEI=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=AICc4zhXOR3xU2IBFhhG0BFOpG3nUhgQ2PHHjitOBeuhqxK6w/6Uf1+k5CC7wkFDr7M2L8N4fObz0ahhzVNP7ODqtAnenA+lTi/UHtdMoypOJprDmImVgDCYoAQFYy34VHXl2eX3tsYz441IhjQufa36EHv3HBhwZXjV0CA5Vb0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 09AC328B8A0; Tue, 21 Nov 2023 13:18:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1700569091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bh4nIB8jLCJqiLla+0Qj1WBJVOVR1/0sld64xL7c1l8=; b=jsgPZhkvL8pqxepwp2RlvG/NWTs2n9eN+/2oasjwPoLIyIgKBbx4+ON7Y/g4R1rJCO6b6p wwpKRBGMdMRtjeFdCX1HSzXe+piZGueyeqyVpSueKCdbvSKrqCZ3kLEo5GsUIznu/32fdY FM2YHKsIYYrG7ZyS0UnrC7+fts+i2rE= Date: Tue, 21 Nov 2023 13:18:10 +0100 From: Jan Hubicka To: Thomas Schwinge Cc: gcc-patches@gcc.gnu.org Subject: Re: Fix 'gcc.dg/tree-ssa/return-value-range-1.c' (was: Propagate value ranges of return values) Message-ID: References: <871qcmkmgd.fsf@gentoo.org> <87v89v5pnp.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87v89v5pnp.fsf@euler.schwinge.homeip.net> X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Hi! > > On 2023-11-19T16:05:42+0100, Jan Hubicka wrote: > > --- /dev/null > > +++ b/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c > > @@ -0,0 +1,22 @@ > > +/* { dg-do ling } */ > > ERROR: gcc.dg/tree-ssa/return-value-range-1.c: 1: syntax error for " dg-do 1 ling " > > With that fixed into 'dg-do link', and... > > > +/* { dg-options "-O1 -dump-tree-evrp-details" } */ > > ... that one fixed into '-fdump-tree-evrp-details', I then get: > > FAIL: gcc.dg/tree-ssa/return-value-range-1.c (test for excess errors) > UNRESOLVED: gcc.dg/tree-ssa/return-value-range-1.c scan-tree-dump-times evrp "Recording return range" 2 > > /tmp/ccTEuffl.o: In function `test': > return-value-range-1.c:(.text+0x24): undefined reference to `link_error' > > This disappears when switching from '-O1' to '-O2'. OK to push the > attached "Fix 'gcc.dg/tree-ssa/return-value-range-1.c'"? (..., or did > you intend something else, here?) Ah sorry for that - I looked for FAIl and missed the error. Yes, the change is OK. Indeed -fipa-vrp is enabled only at -O2. (I think basic non-dataflow VRP could be doable and effective even at -O1, but we don't do that) Honza > > > Grüße > Thomas > > > > +__attribute__ ((__noinline__)) > > +int a(char c) > > +{ > > + return c; > > +} > > +void link_error (); > > + > > +void > > +test(int d) > > +{ > > + if (a(d) > 200) > > + link_error (); > > +} > > +int > > +main(int argc, char **argv) > > +{ > > + test(argc); > > + return 0; > > +} > > +/* { dg-final { scan-tree-dump-times "Recording return range" 2 "evrp"} } */ > > > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 > From f3a47339a9df9726da7e3c1daeadc216e1d5b365 Mon Sep 17 00:00:00 2001 > From: Thomas Schwinge > Date: Tue, 21 Nov 2023 11:51:42 +0100 > Subject: [PATCH] Fix 'gcc.dg/tree-ssa/return-value-range-1.c' > > ... added in recent commit 53ba8d669550d3a1f809048428b97ca607f95cf5 > "inter-procedural value range propagation". > > gcc/testsuite/ > * gcc.dg/tree-ssa/return-value-range-1.c: Fix. > --- > gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c b/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c > index 4db52233c5d..74f1a5080bb 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c > +++ b/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c > @@ -1,5 +1,5 @@ > -/* { dg-do ling } */ > -/* { dg-options "-O1 -dump-tree-evrp-details" } */ > +/* { dg-do link } */ > +/* { dg-options "-O2 -fdump-tree-evrp-details" } */ > __attribute__ ((__noinline__)) > int a(char c) > { > -- > 2.34.1 >