From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2084.outbound.protection.outlook.com [40.107.247.84]) by sourceware.org (Postfix) with ESMTPS id 681773858430 for ; Mon, 27 Nov 2023 10:58:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 681773858430 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 681773858430 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.247.84 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701082715; cv=pass; b=gY7DVvJqy+YfCfvC11bISXedM+zH5cSJ1MwVhTzxS8AFl4tKxYQmjZgyf2FUirZY6yXwnjtn8RZJrUltyl1iniYRZ4Z9jm02CbbvGtPxFffsZWeiGBM8q/Mki77L2bviFEbsoPtgf8XHnxhKFnAQAqqBh5JG1jWnZq8Ftu2FPEs= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701082715; c=relaxed/simple; bh=RvcmiBlP5LiVlyFzDdhhyGXMO+Q1PvGgT2+5POXUbwg=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=gE6KAh2RiOocaKmaoVAT59zWkkK6S+ajLPOZ1BteWfMD3Lp3wIQ5CNVqJZPFJUrYhV4y0fJBC5YLSSs/wfzMQ+FnP/kvhJSAtjTM+jArxZsnUbEsF+L960bZZxOWY3UK2MeGuUl+cshtAIz8xIJuA5kqTz+r2J6fcvrfg1lZeYc= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=K0GTQBH3l3w3zn2MlrUM1dT6AhVKIMs2MRmkwOvWoNRb+QJf/P0NWRLoHPUPbnySuPQ6lkjAaJuLHVDxMwB7Q68oywmPttP6Xc7O6OfnD6ES8T3rcGj6QWj2EfqqqVIBKJL9TKX3TYrfY9L5z8IZOaL7H8P9BuUiAp55ZVOwf22juWYynLWjOkUAqY2RHbzJs34RknO67dm0x3nkEduDIxyBDG4Ep7JWHBueEwIwt7NzoxtqXPFYF0o6mJ/FThAibJ2gz0gALv33k0+RBNhHmw/r9m0XP/sRCbaPpPFDpW+N653RG0EzBwUUELs0/pNRRF+91r7t2xCYWxMJIPrz+A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dN6/9oNGKB5N59Ws4/9lRGOLKTeeTfKn5SBKAXGOdTk=; b=cAJnQIzNcJTh681YEqxSPUsd4aZTWgtB4IanfnU7q+jk09BAFo+Fq4Jpz1X6Jsq8IwPrwr+JOdGD8em1FOCThiBSqnXUoUIOrClZ96suuWkjmudrA5y+2rRY1S8hGm4WhdmdjyIoEsWPZ3qF5kuxE25GH5dAsPn7vVHyRiZ+2iKn5ROvln2074SE6jHnkS+64HlBHhhF1FDAaEVRaoSVqfqkqjnyEwjzwy4blR2R2JU2A4HOLqFEPV5gvMvKsU8fIdvuvNC741rZghucDsm96G3GpbKAY4oIOJtntS10hcS9D135ENTfq8fpM4+N2W2yQ27Eahj0evulbxylexOhhQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dN6/9oNGKB5N59Ws4/9lRGOLKTeeTfKn5SBKAXGOdTk=; b=FQQhazqSfNarotpGBfXKl+W42VMurpAU7cFjlM5bTHMPqWFby9f/QjEeMtDCTPKbk4x397UgM/oTlxYXfWQAfdWPMGCzYP+Kc40GaGRGozjiZP2GfjeeE4SgtxmtHuU8cmrGxB02kprjtDpiuO5ihA8X+jj9ZVOEwEnOkuvLHXE= Received: from AM6P193CA0128.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::33) by GV1PR08MB7754.eurprd08.prod.outlook.com (2603:10a6:150:55::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Mon, 27 Nov 2023 10:58:18 +0000 Received: from AM1PEPF000252DE.eurprd07.prod.outlook.com (2603:10a6:209:85:cafe::b4) by AM6P193CA0128.outlook.office365.com (2603:10a6:209:85::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27 via Frontend Transport; Mon, 27 Nov 2023 10:58:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM1PEPF000252DE.mail.protection.outlook.com (10.167.16.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.17 via Frontend Transport; Mon, 27 Nov 2023 10:58:17 +0000 Received: ("Tessian outbound 5d213238733f:v228"); Mon, 27 Nov 2023 10:58:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b4317ec653651ba2 X-CR-MTA-TID: 64aa7808 Received: from 37a4c81e0ebd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 76F544F3-D57B-40DA-B3A8-E5254DD65D02.1; Mon, 27 Nov 2023 10:58:10 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 37a4c81e0ebd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 27 Nov 2023 10:58:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RM/J6SYBlWvfMLyN50gDQujlRur+EBbFai8OGeMAteEhIDHGhpS578Rcm5A4WoyWpgEuQ7KZNIxIcztu9UC+e+Ob0N8/4gZYcWCTUawwjwst10RZmOlrqmzAXww/TntAquNlnx9iAjlYBPv3NxXHSE3+jznyhLvIU5eoQa/Hc+vXgBYIVCNF51I063OB+J+muxSWhnjTbjDcOQFp2uvEsqWvW096JXkuIUSsYt5ApNvMawQ1xKsuKnZzMA8zmtoMPGcJKdrlXUe34SEkzGjo6UL5uUoWQz7EKNOMP+HnMw5X7O0TkhMzJZi0ghXggcyifd/+leOxg0YWVhLPC3roZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dN6/9oNGKB5N59Ws4/9lRGOLKTeeTfKn5SBKAXGOdTk=; b=SfdCRMI5xgYsE4Muvz3tqGGl0HNBXH8tj5bD7AN6+tQKd8ftd5qgDC5s1mEk4ARpBbE5+hgzzHIQlkPOrhjK8axSxrRV0pEf1pEkXcmQv3HC+D5QyqRwa9ffyR5VtA81svLYzko4i4x8WeQ2Sv2knbQ6f1h6CnomsUU/jHS57UoCAANxuFS10igw3L8dFvCzsMqhsEP1QwktSxr8xpi8yeKXisoCwj8fD+9zE86n8Z4j3YnaZ34HUkzFg/NOF5e6tw6fxxrAOiUqbIImN7QobCTZjjBC2r8tz0qcDfdTi+HCjF4uqUtj2NVM3gpV+Sz+Ow3uiW/6lsG/HalSRcmR4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dN6/9oNGKB5N59Ws4/9lRGOLKTeeTfKn5SBKAXGOdTk=; b=FQQhazqSfNarotpGBfXKl+W42VMurpAU7cFjlM5bTHMPqWFby9f/QjEeMtDCTPKbk4x397UgM/oTlxYXfWQAfdWPMGCzYP+Kc40GaGRGozjiZP2GfjeeE4SgtxmtHuU8cmrGxB02kprjtDpiuO5ihA8X+jj9ZVOEwEnOkuvLHXE= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PAWPR08MB8958.eurprd08.prod.outlook.com (2603:10a6:102:33e::15) by PAVPR08MB9062.eurprd08.prod.outlook.com (2603:10a6:102:32d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Mon, 27 Nov 2023 10:58:08 +0000 Received: from PAWPR08MB8958.eurprd08.prod.outlook.com ([fe80::8512:cc10:24d4:1919]) by PAWPR08MB8958.eurprd08.prod.outlook.com ([fe80::8512:cc10:24d4:1919%5]) with mapi id 15.20.7025.022; Mon, 27 Nov 2023 10:58:07 +0000 Date: Mon, 27 Nov 2023 10:58:04 +0000 From: Alex Coplan To: Marek Polacek Cc: Jason Merrill , gcc-patches@gcc.gnu.org, Nathan Sidwell , Joseph Myers , Iain Sandoe Subject: Re: [PATCH v5] c-family: Implement __has_feature and __has_extension [PR60512] Message-ID: References: <54f7dafb-e8cf-4282-a042-a4abcba6494f@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0223.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::12) To PAWPR08MB8958.eurprd08.prod.outlook.com (2603:10a6:102:33e::15) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAWPR08MB8958:EE_|PAVPR08MB9062:EE_|AM1PEPF000252DE:EE_|GV1PR08MB7754:EE_ X-MS-Office365-Filtering-Correlation-Id: 4feb888d-386f-43ca-1bef-08dbef37c2d0 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nFL0322LmAoIK5pbWtv2Kx/dZGrD6T5CdCf3352vuZDJvTN5+qSKHNQzO/yy8nubGMLXqn+JK1CI01xAzZS3OUJNH4SbA5w31QESec4FsCaq5+nAXeQph8KXQYg5dc2v7GkZuWXqYJoTAxE2GcDa69C3/n9wc4D9l8hlPddz27dy+28UGjVEKppWQ3Vdu9NHxgEhvXSgM9nhPQf0DjkhOvclLm4KLPbVAKgYtlMZ1Xqax/41rj+pI9Q6ODbxS57pv4gCWxIYMeVRZqhbwjV2TbjuRecCp9NTYp2DPYedQBH3mLHNJqJ1cyksr1Nm5uvfBJj9h0XInPOY4YY4OJcXpDTWjs0YE84JjLQN0YHNkaYkrZ2MzL7qCmA14RKPitSZmiVUaOARUhQV14gZ2ZEEo8fs3xh4hYscbegbItQgWrsgWt20zEYNfAjYMbXYUUeqWxX44rIIh1NCAO1usFqLHVE8x7NjBNIm7RIyp0hnLJJmxPmJnglA0ZqwK/3WGckKzuW3ROvis+0RZRrT+gyoX6zSnI3rpCcWrrijAC+WwauzwM8FEO7m/7PhwIAAdOluI4KA47W15DLgRdZHctNBtyOfzdAv37soACwr1rXDD/ByZqW/WAbeUsapUg4X8IzwG2on7690ioxEYy6N1DIctA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8958.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(376002)(136003)(39860400002)(396003)(346002)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(6666004)(4326008)(8676002)(8936002)(6512007)(53546011)(6506007)(6916009)(54906003)(66946007)(66556008)(66476007)(316002)(966005)(6486002)(478600001)(36756003)(38100700002)(41300700001)(86362001)(26005)(44832011)(2906002)(2616005)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9062 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM1PEPF000252DE.eurprd07.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9ff9f44a-dd2e-47be-bc13-08dbef37bcf9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dsgnC/VCr/iFFOert06vyvt3GQbPER+I+jfF58LHCieZAmrAFkquKRDMt+5TXkBppMakXFWquAsqFm14B9iGDRfn2EB5kfFm8m0MMMTyPCRKdK5GHnt5NQzd6qE8uqH9C0AGv7KmkxjOlsNeDIjA88qi9cGaJ4sMeZrlfLbD0wedIszC1GIGodWLzmrdHqjOM8iub4YUfS/r5FN2Djk2Bg+VAIEEr3lBRkvDjQnbA1xxrALZvmRdWDEodA8oM/iXM5eRyZd6pOfrMR6lCVXfVM1I0wFHGpnZLCBPAPKt1cOLpdadxxtbOAOtCIwkYf+1yVAzsvgQTd2RltrDhEr+sUKLVW1e5RwElgY9wul/q2ubgKC7QQI3QGZbzEoGN/d/ATanJxSUayHmFxAsj59eeqnl/tc44dHbkdh6HU17wK6Cd83Uv1NO2mYXzkNV263FqvATRVt+ycgRJDZfLiGgXwyjY8e87ZlljBBeLEYD87+tSWaN22opVcS8kuXdAtwc/+XkcQGLn1xm9HrmEGgI2Q3BzKBkqxbqDpNabE4ZjQVm+W4ufvSh6gyK/4iyd/48EVQXLBha7XXbtFyXbwpludvyf+IbeaP0UN+VdfDXrvWCnaKf32FLPJnE8t2z86h5xAbcSKd3v7oIU+KiMILSnH5nmyPgAwqwCOKJpsOTsi+4uV2ZZxNClnnYzTCkJkmMD3V0EvYvRhuTQMHoOtzmRCS3yReD+0bGOHzLttTCn+aMaXrxinNlf9tsDg9V91D+eC4LSOQfq7ccNd/PH2LcsA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(39860400002)(346002)(136003)(396003)(376002)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(82310400011)(40470700004)(46966006)(36840700001)(8936002)(6666004)(8676002)(4326008)(6862004)(6512007)(6506007)(53546011)(70206006)(316002)(70586007)(54906003)(966005)(6486002)(478600001)(40460700003)(81166007)(356005)(47076005)(36756003)(41300700001)(86362001)(107886003)(26005)(2906002)(44832011)(40480700001)(36860700001)(2616005)(336012)(82740400003)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 10:58:17.2621 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4feb888d-386f-43ca-1bef-08dbef37c2d0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM1PEPF000252DE.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7754 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23/11/2023 12:41, Marek Polacek wrote: > On Mon, Nov 20, 2023 at 05:29:58PM -0500, Jason Merrill wrote: > > On 11/17/23 09:50, Alex Coplan wrote: > > > Hi, > > > > > > This is a v5 patch to address Marek's feedback here: > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635157.html > > > > > > I also implemented Jason's suggestion to use constexpr for the tables > > > from this review: > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-October/634484.html > > > > > > I'll attach the incremental change in reply to Marek's review to make > > > things easier to compare. > > > > > > Bootstrapped/regtested on aarch64-linux-gnu. Bootstrap/regtest on > > > x86_64-apple-darwin in progress (on top of this libsanitizer fix: > > > https://github.com/llvm/llvm-project/issues/72639). > > > > > > OK for trunk if testing passes? > > > > > --- a/gcc/c-family/c-common.h > > > +/* Implemented in c/c-objc-common.cc. */ > > > +extern void c_register_features (); > > > > I think this declaration should go in c-objc-common.h, though the C > > maintainers might prefer c-lang.h or c-tree.h. > > > > > +/* Implemented in cp/cp-objcp-common.cc. */ > > > +extern void cp_register_features (); > > > > And this one in cp-objc-common.h. > > > > With that change the patch is OK on Friday if Marek doesn't have any other > > notes. > > v5 looks good to me. Thanks, Many thanks both for the reviews, this is now pushed (with Jason's above changes implemented) as g:06280a906cb3dc80cf5e07cf3335b758848d488d. Alex > > Marek >