From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id AC4313858C39 for ; Tue, 28 Nov 2023 04:34:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AC4313858C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AC4313858C39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701146050; cv=none; b=FpDq2s0KtuE6jvxhuiKixL9XzvGb3wZGbluWBTTmvAuVlP+uvnxyegeOXvPbLL2TIhH7FKaYOtp/5j4WRu5vKJQGxSlwtGosMAWkMD+c+89Pakz9oekefg/gDghFG60g4yY7ByMxyBsBdeZj8RwVPZmroZIzxbVHKcSjRiK4ooY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701146050; c=relaxed/simple; bh=E2Mz0hZD8GBaS5n8j5IrBrp4oVbXwtnjJm/+qXDq+ps=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Z9Zpu7LKiuFdbOCh7sIa5ESmJPazXKqtXl1Sxb16KC5SCLGQ/fFvN20gXZrYbumiv3xCumyDWq7vLH/8nvkeX9GsGzj/ZkPVZNoNZe/fr6HXx6cjIN/tEnvutlUIXcRtLTZ64Va8NWXT9SDrMVD2/gC7QgODp62x4sb2FQH2EHk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AS3fBmZ013110; Tue, 28 Nov 2023 04:34:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=GZRR25ueZl7k7ParYZSGoB+0ZRxCJz0EKMp+CCnN+MA=; b=eX5bJbBDcFkzHZrSLHyp8FyjSu/j1ISvUo/Yw6KKqzbuPMsfGCLZmF7J7hRYNi8c9Bhk adXfFeDcYHTP/ASvG61YZhMnK35ojjGIcRZhnf3Ny6yBdwdBhCDWQjGFQni46gKaCsPE hsjjvGdUEiLcSrO6nGwHQCQDrnqQkP1Eyt8+GwSKU078tXBmwsERkNp5Kdx42QUpK7gl 8SLF/gT16gO9hrgijAXbZ1X5UH7OA3gM13yOIfAmVX5GVZbJPJkkJHndrnv+pOOkGlJQ qHN18B4zuDabZ/5TiaXKAk5oeDqssa+fwpj17+vc5yPBfy1Vapi8mZmMwf8ps/UdPSf4 Tw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3un7gpaa6v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Nov 2023 04:34:08 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AS4KXdN022872; Tue, 28 Nov 2023 04:34:08 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3un7gpaa6c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Nov 2023 04:34:08 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AS44X0p027644; Tue, 28 Nov 2023 04:34:06 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ukumydhqs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Nov 2023 04:34:06 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AS4Y58E26411638 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Nov 2023 04:34:05 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C6BF958052; Tue, 28 Nov 2023 04:34:05 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D5995805D; Tue, 28 Nov 2023 04:34:05 +0000 (GMT) Received: from cowardly-lion.the-meissners.org (unknown [9.61.83.136]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTPS; Tue, 28 Nov 2023 04:34:05 +0000 (GMT) Date: Mon, 27 Nov 2023 23:34:03 -0500 From: Michael Meissner To: "Kewen.Lin" Cc: GCC Patches , Segher Boessenkool , David Edelsohn , Peter Bergner , Michael Meissner Subject: Re: [PATCH v2] rs6000: Add new pass for replacement of contiguous addresses vector load lxv with lxvp Message-ID: Mail-Followup-To: Michael Meissner , "Kewen.Lin" , GCC Patches , Segher Boessenkool , David Edelsohn , Peter Bergner References: <77426697-1571-e180-add9-cfb6d10f8424@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77426697-1571-e180-add9-cfb6d10f8424@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: jrRNgxVZBYQwU3DRB25znziNAJRb5n4a X-Proofpoint-ORIG-GUID: IeDAi76UDU93hYdh2Hl6-MBzPn3wbZds X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-28_02,2023-11-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 mlxscore=0 clxscore=1015 adultscore=0 mlxlogscore=954 bulkscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311280035 X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Nov 24, 2023 at 05:31:20PM +0800, Kewen.Lin wrote: > Hi Ajit, > > Don't forget to CC David (CC-ed) :), some comments are inlined below. > > on 2023/10/8 03:04, Ajit Agarwal wrote: > > Hello All: > > > > This patch add new pass to replace contiguous addresses vector load lxv with mma instruction > > lxvp. > > IMHO the current binding lxvp (and lxvpx, stxvp{x,}) to MMA looks wrong, it's only > Power10 and VSX required, these instructions should perform well without MMA support. > So one patch to separate their support from MMA seems to go first. I tend to agree with you, but I recall the decision being made because at the time, vector pairs and vector quads were only used with MMA. We now have various attempts to improve things for using vector pairs for non-MMA code. In my patches, I keeped the MMA requirement, but if we decide to make it ISA 3.1 only if is fairly straight forward to look at all of the TARGET_MMA tests. Now in the GCC 13 days, it was useful that -mmma controlled vector pair. There was an issue if we enabled memcpy to use store vector pair, it would lead to one slow down. When I was doing the tests, it was easy to use -mno-mma and it would stop memcpy from using load/store vector pair since GCC doesn't generate code to use MMA without using the built-ins.