From: Jakub Jelinek <jakub@redhat.com>
To: Alex Coplan <alex.coplan@arm.com>
Cc: Jason Merrill <jason@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] c++: Fix up __has_extension (cxx_init_captures)
Date: Tue, 28 Nov 2023 18:12:01 +0100 [thread overview]
Message-ID: <ZWYfYV7WeoUw9l5o@tucnak> (raw)
In-Reply-To: <ZWYZNZ93Up0uwNYX@arm.com>
On Tue, Nov 28, 2023 at 04:45:41PM +0000, Alex Coplan wrote:
> > --- gcc/cp/cp-objcp-common.cc.jj 2023-11-27 17:34:25.000000000 +0100
> > +++ gcc/cp/cp-objcp-common.cc 2023-11-28 08:55:18.868419864 +0100
> > @@ -145,7 +145,7 @@ static constexpr cp_feature_info cp_feat
> > { "cxx_contextual_conversions", { cxx14, cxx98 } },
> > { "cxx_decltype_auto", cxx14 },
> > { "cxx_aggregate_nsdmi", cxx14 },
> > - { "cxx_init_captures", cxx14 },
> > + { "cxx_init_captures", { cxx14, cxx11 } },
>
> FWIW it looks like this is what I had in the original RFC here:
>
> https://gcc.gnu.org/pipermail/gcc-patches/2023-May/617878.html
>
> but Jason suggested we be more conservative about what we advertise as
> extensions in his review here:
>
> https://gcc.gnu.org/pipermail/gcc-patches/2023-May/618232.html
Wasn't that suggestion mostly about C++98 though?
Jason, shall I commit the patch as approved, or shall Alex tweak the
testcase instead?
Jakub
next prev parent reply other threads:[~2023-11-28 17:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 14:50 [PATCH v5] c-family: Implement __has_feature and __has_extension [PR60512] Alex Coplan
2023-11-20 22:29 ` Jason Merrill
2023-11-23 17:41 ` Marek Polacek
2023-11-27 10:58 ` Alex Coplan
2023-11-28 8:22 ` [PATCH] c++: Fix up __has_extension (cxx_init_captures) Jakub Jelinek
2023-11-28 16:45 ` Alex Coplan
2023-11-28 17:12 ` Jakub Jelinek [this message]
2023-11-28 17:18 ` Jason Merrill
2023-11-28 17:08 ` Jason Merrill
2023-11-28 16:03 ` [PATCH v5] c-family: Implement __has_feature and __has_extension [PR60512] Thomas Schwinge
2023-11-28 16:53 ` Alex Coplan
2023-11-28 17:08 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWYfYV7WeoUw9l5o@tucnak \
--to=jakub@redhat.com \
--cc=alex.coplan@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).