From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2058.outbound.protection.outlook.com [40.107.104.58]) by sourceware.org (Postfix) with ESMTPS id 40D6A3858C31 for ; Wed, 29 Nov 2023 15:51:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 40D6A3858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 40D6A3858C31 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.58 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701273078; cv=pass; b=k5WKyZDYZn3g5JWZkWcBqfgVdiFzsJPO3rlzf2Bdk6aZwWQc/FlbTYmIOj5CZT4hWSX3pNC0Ju0rLYU9QAd+FY2VpcOlbyBB9C/BwkupL5o7XXmPpUhrjNt/MqhucyUOASRzLq0kIo7ZkAGbTQS7MkbREBtvEeQWoYV1UcvzY5I= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701273078; c=relaxed/simple; bh=CTYADJ9KwMXy4jHuPkKghlKtuYnmXsuaL+giPmBqlbI=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=RmQs3NWiHtXosfCLyCYymBEyzodxWaVmtftMw8++DJKzmMWAJmDm9S1RcYZU/uqb6OlvGoV/EJsnco9CsxBjSgTzWaq/RwO6V5Hw6yODBBkVwZdWj/FqPP2WoFmc65sLJj1jy46hvYIGw5ZajxcFM8PTiqvPekBcLdCJ7ZhKp6A= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YEsk+rPA5ggy4zDz17OfHZgllEqW6pf4HguXqiH7zYCOiCHeDu09M0E1UmltJmXicCCQmOVAxPTcPuyEaXzFW/eziibs8XkG77REEF9Ye1BS1PvC+2uNAXM5gaNkjATeZiV3LR2hj65usKpx70clK/ufdXEjHIqinyJFVnQUASuPfWMJhXF7n8Hugkkr4qCPG69t+2hiA/a74gLc78nb5jx9uzQLeIcRbnhRuX0NpGtjdxUtFOKkCibSlp7Cx5G5x2aW49q8fmwQAFr7cEkaOPE8ugdLC+mnGImOEWn0z2TBsqhkjPilXLxFG/6urCw1m68gPE+FG7YQ90dIuASK2A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KZGDt5rPF9/jhgxaiLZfdWAjwkP8Y8ZRPIyrzb89/iI=; b=RKk69ctt+RBuPSy1/rGRZyOWiBYVZd+n1Y+S+X5U728j8AsI3RhuJu5Ryw9BECM9x525sno1Z9cTrYkwhrpbRwQGOzP8r+qvqxjvg/YA6BlX4zXmoD6vdJAvsiKKWpyBPVy6/MCBP6yLNhqxHYS9ZQZlXTO4/p3F9ZrQTNC1Y4prPW5bJi1Asziu9rWn1dxalW9KpAZUYldFt4R3glQJ2dupUVrTBnSjFHQgYpUKnIsans4iOB3fCshIxsTX3eIa7v2BvNX8ILpqIEP58rSTpC1WmytXuwIl97xukIESw4lGPKmXXJmLtGfqEBz8YH6i0mKpFG3JzlXHYZvOvHTn7Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KZGDt5rPF9/jhgxaiLZfdWAjwkP8Y8ZRPIyrzb89/iI=; b=EPi6nM2TFEd5m/ewIbAWfQjh1xzJzWGB1fbdiKqr9HIW3rhWl06vcryHdelM7aweEjonVYq6bx7hcpLp3LtpkYFWePGk3ZlsYhy/bZOe7LI2aWr/2582eKip/v63UcCZeAW5Nea+NP7uQSAf9DXw95cRhwKmCFgbUzR81S4Kvs4= Received: from AM7PR04CA0030.eurprd04.prod.outlook.com (2603:10a6:20b:110::40) by DB9PR08MB9467.eurprd08.prod.outlook.com (2603:10a6:10:45b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Wed, 29 Nov 2023 15:51:13 +0000 Received: from AM2PEPF0001C70E.eurprd05.prod.outlook.com (2603:10a6:20b:110:cafe::29) by AM7PR04CA0030.outlook.office365.com (2603:10a6:20b:110::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.23 via Frontend Transport; Wed, 29 Nov 2023 15:51:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM2PEPF0001C70E.mail.protection.outlook.com (10.167.16.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.17 via Frontend Transport; Wed, 29 Nov 2023 15:51:12 +0000 Received: ("Tessian outbound 26ee1d40577c:v228"); Wed, 29 Nov 2023 15:51:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3265eace61e7b034 X-CR-MTA-TID: 64aa7808 Received: from a3a0dc6fdaad.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BAF0B5D7-BFA7-4FEC-A0FD-0E8E6FCC355A.1; Wed, 29 Nov 2023 15:51:06 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a3a0dc6fdaad.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 29 Nov 2023 15:51:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JD61XwBpeZfmRDrNXgBG8mVwyXOMDkkSPanZQNP3g36KWgpTzuoZhM9sQxGJ9CRQblkRCPHCWed4ItqFWvcbJc7NqFeh+ocrfs0hSn7tOLkdhmtU0l8KIpsXTTYNGMkWhUxFPwMOH/ESPIlm4rthoaCXB1VBe/tLJ+c8lys27HEomZn6TMlK2XYlUgya+dBmDgtAcni5EXVtJys7j7B9VXeasS3HBVwebreqYRR8RF9RflovcG3NeCK4HWrh3TEsltSElmWhtQ8odzpC/4kIn0ga+rpxEKwCORZbm3fMtr3woWmO1Xu9tfU7ZmbeslA2U0F86Zb4+5FLOdADBj5ErA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KZGDt5rPF9/jhgxaiLZfdWAjwkP8Y8ZRPIyrzb89/iI=; b=mHSGvQY+NV6Ud8BPUGJfNdCAmjVFlLR8gq59ACSJVIDFuX0eZk8Pi5J4HEOuhFKAH6cOHDpAGtgOrS8W9tDOdSgCrv3awZDQ//4DI6mYWNZ7ezwtXWnGh89Mgh03WwlHrZ7HZlmtIY8v3sdoWzjJfftMNEX2aJ5VWQfAwX0k6ZNRuzPM0ZIqSF39OZrenRz7Jqk+uukOqRkGOmjq22RSaKOItpBoBpbAS6G0XpNggDQTegZU7tLuUfbwAlS4cJFA+jiKn7EkYlnjEM1UZBqj1YtLxoN8G/EyIax0JWfLJ7YL+KcNWC3pjQAmdW6XLC3BI7gjKD17GLOMYq+rjUi9Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KZGDt5rPF9/jhgxaiLZfdWAjwkP8Y8ZRPIyrzb89/iI=; b=EPi6nM2TFEd5m/ewIbAWfQjh1xzJzWGB1fbdiKqr9HIW3rhWl06vcryHdelM7aweEjonVYq6bx7hcpLp3LtpkYFWePGk3ZlsYhy/bZOe7LI2aWr/2582eKip/v63UcCZeAW5Nea+NP7uQSAf9DXw95cRhwKmCFgbUzR81S4Kvs4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by GVXPR08MB10864.eurprd08.prod.outlook.com (2603:10a6:150:154::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Wed, 29 Nov 2023 15:50:59 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::292d:9c0e:e9f7:deba]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::292d:9c0e:e9f7:deba%5]) with mapi id 15.20.7046.015; Wed, 29 Nov 2023 15:50:59 +0000 Date: Wed, 29 Nov 2023 15:50:44 +0000 From: Szabolcs Nagy To: Florian Weimer , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] aarch64: Avoid -Wincompatible-pointer-types warning in Linux unwinder Message-ID: References: <874jht5tsq.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <874jht5tsq.fsf@oldenburg.str.redhat.com> X-ClientProxiedBy: LO4P265CA0083.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::20) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|GVXPR08MB10864:EE_|AM2PEPF0001C70E:EE_|DB9PR08MB9467:EE_ X-MS-Office365-Filtering-Correlation-Id: 93142dc6-61d7-447a-f5d4-08dbf0f30387 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: j2z5PNtfu5ZpBr+OY/3lfwVcF9p83Rvb929HMmXQNKUWdftEERMdK7r+TYqjX1TcXO5C0YSPyj9/NFj5fgTJXqJPFZCZNbkOqwdWYSjiI4mBpzapZzm7lhlrUF/Pz79DegYlxUm2wx7nkVe9Q4Y6qG2/IO5DPg+Z5YIVnb3frLaTNiiV8S0a2bRhx4fArmlyS7y15zgKyepjU88ETsrXCS7yinDWXjTltpCuF5oFEtUfuGso81giKYqxjNzNuwfAETmE0oCqZ2yOVUA5HIoT3Nh0tWgYMRsnGXmLki+oPpB4Cpxt1rW3VivnR1Gq9j7/38rHKezQ8jcZ5A2Z8DsLUh1//PGF2ohC85WMXb2sd/plks4Eh8qHve+rLxBj/dlcGVg/i16j5hn7zDBKo46qiAL8BPGHnvUJx0y3Fswl8Pg6ChwgeU/XvSKewhjR6JwKVKMo01MnxoRKu9dJ0hDVGe0fZSGO/Re2VgQRGFqTwNMP10B6ADVcnn/9/M1j6I6yNaKulhG+UCK4hM/UkuKqIfiGWFtkyeM/+Arq5uoG8gljupAt4gNA/NQHFvFu35SNgUjeCjcQdsYVWfRuZufjLnZfZHTE68s/IOzKyw9ehR4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(39860400002)(376002)(346002)(136003)(396003)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(83380400001)(38100700002)(8936002)(6486002)(44832011)(6666004)(8676002)(86362001)(6506007)(66946007)(66476007)(66556008)(5660300002)(478600001)(316002)(2906002)(36756003)(6512007)(41300700001)(26005)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB10864 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM2PEPF0001C70E.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9ef7a134-87fc-4bb0-d178-08dbf0f2fba5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2mmStmmi1rxXd5rr9W0gH/Us6PTm6SHptWUdIGAA6IdHuTKZQrq8PVpHz7FuQxYQdR7rHU6L6nWG6Hs93B4Y43WjS+1/5oMDQ7SOIAgLsFQSn6COUVVNnQd8ePN6AuTSzmM3podBvhdeUIePfO9n9vIS9iCXF8SCRiEdtWnbeL/zw7feMIiGyJ6AtUFan3bTzMPw1LQGhhmwI3I63aZbLkZC4LTeoJxCK9KY6ELpGCYi2/L9Tb5gTPUHdhm3YMtVqkCihKJ4i71Ewq3jwsHFj5yC+rRGXWT36RZ4UvT/B8MmAvOPrvtB16XJBNwSUkxEHkNLO9ZIEJYIjFvggRis7QsdoOn0OBklLmVm/w26AybCbO1/fRJ+DtJriRi4gNv7yswciVtRGA/vCzCtVdsXRyDWOU7TJZhKm3yCMvKbG2aH0785ceqUuMA36DBrqF4X6IOCVK7s8KJFfsh+qCWat2H+1/NesP5o5HrABi1HNdOcPA8eLUWHdbgcF3hKWd1Se9iKvJdfsYeR6L6zh+5MY54DlV/sc9QUk8Krg+aqKsxad4odpdr8NQ8TMlm+2s5XaB36imv7UjDHX3HMqj+gtNcsTbtxLu/pwFC1qW9U+5LuL9lztxYNnkXsJbMxmfmf5L1RMRbiZoXZhEkXVtVSyEYgnH6jvNn51jozG0pNEu9QKTnSDQ14lY3j94NQWkd0MuIobFs3aLjV/z1Tx77pyvqWLYmtdwz8dbzsm+d4aPOl4oihqtfF0dRO/fP+FV4X X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(346002)(136003)(39860400002)(396003)(376002)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(82310400011)(40470700004)(36840700001)(46966006)(86362001)(82740400003)(356005)(81166007)(40460700003)(36756003)(6486002)(478600001)(26005)(70586007)(70206006)(8676002)(5660300002)(6666004)(2616005)(6506007)(6512007)(336012)(44832011)(41300700001)(2906002)(8936002)(36860700001)(316002)(83380400001)(40480700001)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 15:51:12.9549 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93142dc6-61d7-447a-f5d4-08dbf0f30387 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF0001C70E.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9467 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 11/10/2023 19:48, Florian Weimer wrote: > * config/aarch64/linux-unwind.h > (aarch64_fallback_frame_state): Add cast to the expected type > in sc assignment. > > (Almost a v2, but the other issue was already fixed via in r14-4183.) > > --- > libgcc/config/aarch64/linux-unwind.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libgcc/config/aarch64/linux-unwind.h b/libgcc/config/aarch64/linux-unwind.h > index 00eba866049..18b3df71e7b 100644 > --- a/libgcc/config/aarch64/linux-unwind.h > +++ b/libgcc/config/aarch64/linux-unwind.h > @@ -77,7 +77,10 @@ aarch64_fallback_frame_state (struct _Unwind_Context *context, > } > > rt_ = context->cfa; > - sc = &rt_->uc.uc_mcontext; > + /* Historically, the uc_mcontext member was of type struct sigcontext, but > + glibc uses a different type now with member names in the implementation > + namespace. */ > + sc = (struct sigcontext *) &rt_->uc.uc_mcontext; FWIW this looks good to me. (but i cannot approve patches) (changing the type of sc to mcontext_t* is another option, but then _GNU_SOURCE is required for the field names to remain the same across glibc versions, while struct sigcontext* is unlikely to cause API issues.) > > /* This define duplicates the definition in aarch64.md */ > #define SP_REGNUM 31 > > base-commit: 3a6df3281a525ae6113f50d7b38b09fcd803801e >