From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>,
Andreas Krebbel <krebbel@linux.ibm.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] s390: Fix builtin-classify-type-1.c on s390 too [PR112725]
Date: Thu, 30 Nov 2023 17:34:45 +0100 [thread overview]
Message-ID: <ZWi5pXQs/WPcrH9W@tucnak> (raw)
In-Reply-To: <ZWeChQalHyNSI+zw@tucnak>
On Wed, Nov 29, 2023 at 07:27:20PM +0100, Jakub Jelinek wrote:
> Given that the s390 backend defines pretty much the same target hook
> as rs6000, I believe it suffers (at least when using -mvx?) the same
> problem as rs6000, though admittedly this is so far completely
> untested.
>
> Ok for trunk if it passes bootstrap/regtest there?
Now successfully bootstrapped/regtested on s390x-linux and indeed it
fixes
-FAIL: c-c++-common/builtin-classify-type-1.c -Wc++-compat (test for excess errors)
-UNRESOLVED: c-c++-common/builtin-classify-type-1.c -Wc++-compat compilation failed to produce executable
there as well.
> 2023-11-29 Jakub Jelinek <jakub@redhat.com>
>
> PR target/112725
> * config/s390/s390.cc (s390_invalid_arg_for_unprototyped_fn): Return
> NULL for __builtin_classify_type calls with vector arguments.
>
> --- gcc/config/s390/s390.cc.jj 2023-11-27 17:34:25.684287136 +0100
> +++ gcc/config/s390/s390.cc 2023-11-29 09:41:08.569491077 +0100
> @@ -12650,7 +12650,8 @@ s390_invalid_arg_for_unprototyped_fn (co
> && VECTOR_TYPE_P (TREE_TYPE (val))
> && (funcdecl == NULL_TREE
> || (TREE_CODE (funcdecl) == FUNCTION_DECL
> - && DECL_BUILT_IN_CLASS (funcdecl) != BUILT_IN_MD)))
> + && DECL_BUILT_IN_CLASS (funcdecl) != BUILT_IN_MD
> + && !fndecl_built_in_p (funcdecl, BUILT_IN_CLASSIFY_TYPE))))
> ? N_("vector argument passed to unprototyped function")
> : NULL);
> }
Jakub
next prev parent reply other threads:[~2023-11-30 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 18:27 Jakub Jelinek
2023-11-30 16:34 ` Jakub Jelinek [this message]
2023-12-01 6:50 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWi5pXQs/WPcrH9W@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=krebbel@linux.ibm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).