From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1FCD63857C69 for ; Thu, 30 Nov 2023 16:34:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1FCD63857C69 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1FCD63857C69 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701362097; cv=none; b=dx8r41Y+asnNlcefjEeaqUUCHapMZVYYJXWducbGyRMUueP0l3w8E3k173+6+okdVPh9LUPt/PGXi4FAIHyDTRkMao6JeFZfS266LCUpVnfwZ0qviEyu2VGuhRWTyk1wPqt5bsY7KgvCwa3TuezG0dSYgXG2sbP88Dc77zQvQIQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701362097; c=relaxed/simple; bh=XAGWP4dfEBtbWxW5hcyicfN74dTO/X3g0Uqtc30PH7o=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=MWbJ9L6rLfiGE5NzMQ2orWvUFEzSsUaux0bRxBIxAyOz9d/aYVggnMu8EDe1P9Uu8li5Rpr/EqsvqdXFQWZPdPjE1vqZ37bynj9BTVid5AYoeBRDHW8nbPElp6RMWdWqQOv543f5J25UJf7hv690WFsA8qtDrlcKQwLm6Qf90ms= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701362095; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=5ZpgSMeS5SBUn2df7Zrg1Vrngmzb9RXqf8FfbtqbhtY=; b=UhiyPIXSW2gS4o/7V0wgllu2N8xGn+EDNXPqWaofACLT5SCiRI25VniYpFeI8UcRipBNTu V44WKFWuCAgG4Mr/Owu8FgQaRP3g2L34X6mTUWEGqFX59FvI42ENth2kESs3j4RqukOnoV IiV8117p4NAzipSMqH17jTLuLJebP7w= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-XZJeUEFDNxmZ6haqQfi4yw-1; Thu, 30 Nov 2023 11:34:51 -0500 X-MC-Unique: XZJeUEFDNxmZ6haqQfi4yw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D5E0482A661; Thu, 30 Nov 2023 16:34:50 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.157]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99DDF492BE0; Thu, 30 Nov 2023 16:34:50 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 3AUGYlu01881532 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 30 Nov 2023 17:34:47 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 3AUGYk9P1881531; Thu, 30 Nov 2023 17:34:46 +0100 Date: Thu, 30 Nov 2023 17:34:45 +0100 From: Jakub Jelinek To: Ulrich Weigand , Andreas Krebbel , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] s390: Fix builtin-classify-type-1.c on s390 too [PR112725] Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 29, 2023 at 07:27:20PM +0100, Jakub Jelinek wrote: > Given that the s390 backend defines pretty much the same target hook > as rs6000, I believe it suffers (at least when using -mvx?) the same > problem as rs6000, though admittedly this is so far completely > untested. > > Ok for trunk if it passes bootstrap/regtest there? Now successfully bootstrapped/regtested on s390x-linux and indeed it fixes -FAIL: c-c++-common/builtin-classify-type-1.c -Wc++-compat (test for excess errors) -UNRESOLVED: c-c++-common/builtin-classify-type-1.c -Wc++-compat compilation failed to produce executable there as well. > 2023-11-29 Jakub Jelinek > > PR target/112725 > * config/s390/s390.cc (s390_invalid_arg_for_unprototyped_fn): Return > NULL for __builtin_classify_type calls with vector arguments. > > --- gcc/config/s390/s390.cc.jj 2023-11-27 17:34:25.684287136 +0100 > +++ gcc/config/s390/s390.cc 2023-11-29 09:41:08.569491077 +0100 > @@ -12650,7 +12650,8 @@ s390_invalid_arg_for_unprototyped_fn (co > && VECTOR_TYPE_P (TREE_TYPE (val)) > && (funcdecl == NULL_TREE > || (TREE_CODE (funcdecl) == FUNCTION_DECL > - && DECL_BUILT_IN_CLASS (funcdecl) != BUILT_IN_MD))) > + && DECL_BUILT_IN_CLASS (funcdecl) != BUILT_IN_MD > + && !fndecl_built_in_p (funcdecl, BUILT_IN_CLASSIFY_TYPE)))) > ? N_("vector argument passed to unprototyped function") > : NULL); > } Jakub