From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 02FAC384CBBA for ; Thu, 30 Nov 2023 19:54:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 02FAC384CBBA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 02FAC384CBBA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701374043; cv=none; b=eRaL7FCXl2gLtsrGB0zmWFgJo2YBfrntzmPVtUJYZZrzfxxZOH+RkBxpNrp48V/jzC9kY3F9w0jMWiF64zKvJtWFkWsCl5j0jEafOWOot66A2HSslXgvkXp2uF3x+d2Uwas/8XghyQiyJK8Dj+9AzYu2YwPvdkZV7PmuWk6dB+w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701374043; c=relaxed/simple; bh=iEI4YXxzdX+NTkyu63RmAmxZZZKnJ43/my2mAkKOD8I=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=PsLFoEAFXX9y79hBKmc+m0IXfWLh+w9ZhlxaR5+0osQvpReIoW5jDi8IXRFE472ykGd24vrFDF2XszvCZ05gfi65gvODRTHu1zy6TTSJ0FOrH63aSPf8ED0vIFYFSauB61nvtITkcjXry84XN4p3CUB7zwfPfgkx39QTV01Dh18= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701374041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TOUbFsvNHY8ZBCr3pt3g6XBuMa8GDMLo4gXmZHyzo08=; b=YV5lwe7HPLPbhOySW0rH/eieIv6UXl5FjZhB10WgHDSPOPXZifG+1MB8SMkldJ80hUcMVc Juo3Z10gTfNFwAWO9tnqucWKF0Wjkudrq8H6tW8ViSpx1r/9aXy1kNRbZCOWRMwCQgwLkT mi9Mc9w1Sh/TGYNIlgCdpOykiDLMS2M= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-250-xPiR3eUAMtaCaMKVsskWxw-1; Thu, 30 Nov 2023 14:53:59 -0500 X-MC-Unique: xPiR3eUAMtaCaMKVsskWxw-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-67a4bb77f47so29727006d6.0 for ; Thu, 30 Nov 2023 11:53:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701374039; x=1701978839; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TOUbFsvNHY8ZBCr3pt3g6XBuMa8GDMLo4gXmZHyzo08=; b=RExw4Ck/XfvUGoWjY5wTazqgHW3TObisyKzCW4DVmX9k2ziNgZwfHnvXZgZ3moKC1t QR+sz0nxxgbO0L88XoyYwt1gHEeEsEqCuGlfolEdqTCOutCuvrez/KXwx22u0KvQ8POF PAAsgPfEccLgKXrvYk/6U+CdTwp6TDoHkzNfvS19Y/Y92mWQ/G6NFzVkcOzVsK0t9nka tK2KoK+Lwi579lh57cKHpkxBCL1g38Wd03iwVDvhWwEzorj5kVRFDEouwOCD4EbykEAH YJBUtotVmjHrFJhS7VnkNVXWeIlSq0yi1/o3XqzbLZj0r6dy/no2Mzo5qGx8IafxkrEs 0r9A== X-Gm-Message-State: AOJu0YwexcxaRmgNWXoZuXsudUAEI42eyB4mPF/Vcbe9gEYwrgvgMkQL DaochIN/9OTaGakESFS1VOgqrzLyZS0sXkCnR0rkyIORJcwPu+SS0b9uKjrou2jPOQM2Heid9M/ u5Urxxg03zACSN+PZIlwF+UAObw== X-Received: by 2002:a05:6214:14ee:b0:67a:92d1:a9fd with SMTP id k14-20020a05621414ee00b0067a92d1a9fdmr760568qvw.0.1701374039264; Thu, 30 Nov 2023 11:53:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYDvxQ1i8BMkZiXKMCxEIRfk90Ei3F1CElQVBEh9x6pE+48KpQczE1d5c6LFrQngf00O5WFw== X-Received: by 2002:a05:6214:14ee:b0:67a:92d1:a9fd with SMTP id k14-20020a05621414ee00b0067a92d1a9fdmr760550qvw.0.1701374038998; Thu, 30 Nov 2023 11:53:58 -0800 (PST) Received: from redhat.com (2603-7000-9500-34a5-0000-0000-0000-1db4.res6.spectrum.com. [2603:7000:9500:34a5::1db4]) by smtp.gmail.com with ESMTPSA id y2-20020a0c9a82000000b0067a2354f8besm776827qvd.91.2023.11.30.11.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 11:53:58 -0800 (PST) Date: Thu, 30 Nov 2023 14:53:56 -0500 From: Marek Polacek To: Florian Weimer Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v3 08/11] c: Do not ignore some forms of -Wimplicit-int in system headers Message-ID: References: <7b09c1315253d91868e0f4e95debb75c41a62873.1700473918.git.fweimer@redhat.com> MIME-Version: 1.0 In-Reply-To: <7b09c1315253d91868e0f4e95debb75c41a62873.1700473918.git.fweimer@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Nov 20, 2023 at 10:56:26AM +0100, Florian Weimer wrote: > Most -Wimplicit-int warnings were unconditionally disabled for system > headers. Only missing types for parameters in old-style function > definitions resulted in warnings. This is inconsistent with the > treatment of other permerrors, which are active in system headers. LGTM. > gcc/c/ > > * c-decl.cc (grokdeclarator): Do not skip -Wimplicit-int > warnings or errors in system headers. > > gcc/testsuite/ > > * gcc.dg/permerror-system.c: Expect all -Wimplicit-int > permerrors. > --- > gcc/c/c-decl.cc | 2 +- > gcc/testsuite/gcc.dg/permerror-system.c | 5 +++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/gcc/c/c-decl.cc b/gcc/c/c-decl.cc > index 893e24f7dc6..d16958113a8 100644 > --- a/gcc/c/c-decl.cc > +++ b/gcc/c/c-decl.cc > @@ -6845,7 +6845,7 @@ grokdeclarator (const struct c_declarator *declarator, > > /* Diagnose defaulting to "int". */ > > - if (declspecs->default_int_p && !in_system_header_at (input_location)) > + if (declspecs->default_int_p) > { > /* Issue a warning if this is an ISO C 99 program or if > -Wreturn-type and this is a function, or if -Wimplicit; > diff --git a/gcc/testsuite/gcc.dg/permerror-system.c b/gcc/testsuite/gcc.dg/permerror-system.c > index 60c65ffc1d4..cad48c93f90 100644 > --- a/gcc/testsuite/gcc.dg/permerror-system.c > +++ b/gcc/testsuite/gcc.dg/permerror-system.c > @@ -10,7 +10,12 @@ > > /* { dg-error "'f1' \\\[-Wimplicit-function-declaration\\\]" "" { target *-*-* } 10 } */ > > +/* { dg-error "'implicit_int_1' \\\[-Wimplicit-int\\\]" "" { target *-*-* } 13 } */ > +/* { dg-error "'implicit_int_2' \\\[-Wimplicit-int\\\]" "" { target *-*-* } 14 } */ > +/* { dg-error "'implicit_int_3' \\\[-Wimplicit-int\\]" "" { target *-*-* } 15 } */ > +/* { dg-error "return type defaults to 'int' \\\[-Wimplicit-int\\\]" "" { target *-*-* } 16 } */ > /* { dg-error "type of 'i' defaults to 'int' \\\[-Wimplicit-int\\\]" "" { target *-*-*} 16 } */ > +/* { dg-error "type defaults to 'int' in type name \\\[-Wimplicit-int\\\]" "" { target *-*-* } 19 } */ > > /* { dg-error "pointer/integer type mismatch in conditional expression \\\[-Wint-conversion\\\]" "" { target *-*-* } 29 } */ > /* { dg-error "pointer/integer type mismatch in conditional expression \\\[-Wint-conversion\\\]" "" { target *-*-* } 30 } */ > -- > 2.42.0 > > Marek