From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id ED5003858C31 for ; Wed, 6 Dec 2023 08:49:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED5003858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ED5003858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701852547; cv=none; b=Po1Cd4um+TaKE8iKrPakFZkjUe8Vz4yy+csKdUnjV7cep6S9jaIK+4ovX04NPK+CLdAB/5ENN92FWLbRAWzjde74ptyan1sZbjO6ZEqCXu0OGt6X2IL5PJ8sRGONFR162cBp+FO+46Sjn1q+dGn/hsJtV56fH4F9PdHwY6lMsPM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701852547; c=relaxed/simple; bh=RY9mxyLXy7EzVoLPXfGuhLhrMu5SZ8lDetttgTmDZA4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=k4/pg6QA6talk4a2CLF2Hm7wWk4KQoQYn8szeng98faujc+yFZIxNO1O5ttcsLHz+BvXqBasDIRgqfKfgFcBlAt/62CwLUpf0HyTeNI+n2m1gj/8FJt/lM4+eAH94HTA/KZ9uxf5UBDodmArZTvwHUuMAbkxu9FJg6yvncpZ1Ys= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701852544; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=rPmmNSYXnfUAgVF9825kexb1wD8D0Tms4dmKu32paBQ=; b=ClAVqbnZbEbpszihIlCkW3swT0zpaJOB7/raRZZ3K1RDt32xpuyPqc2FHE1z0Ph4YGyrbh Qe4XvmGL+J7Z4DeFJW+nVadLjvPQh/s4cyZIo3fvS/Mod2ZJzeFyCUJZugrE1XxEku/zko 7LG7ptbcenb79PGeEGXUfXtqwZFFVdw= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-9b5y1gTfMuidVVqyHlvs9w-1; Wed, 06 Dec 2023 03:49:02 -0500 X-MC-Unique: 9b5y1gTfMuidVVqyHlvs9w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DE4253806622; Wed, 6 Dec 2023 08:49:01 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.157]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F1E3C15E6A; Wed, 6 Dec 2023 08:49:01 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 3B68mwG01484969 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 6 Dec 2023 09:48:59 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 3B68mwpT1484968; Wed, 6 Dec 2023 09:48:58 +0100 Date: Wed, 6 Dec 2023 09:48:57 +0100 From: Jakub Jelinek To: waffl3x Cc: Jason Merrill , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH v7 1/1] c++: Initial support for P0847R7 (Deducing This) [PR102609] Message-ID: Reply-To: Jakub Jelinek References: <=5Fe1O52EjoN=5FBFiH31iHE-0eYegNJhoOdDN2O0mduqtMmt7qTGpRWgduxNppnO1si01rORJ470oWcoM-=5Flk1ICFo9lhe=5FylBKQsJ791qMm=5Fk=3D@protonmail.com> <1b3b0259-5ce4-4193-a36d-60f09e1c7c92@redhat.com> <575c0bbe-a3d6-4a54-b299-edff64df84b1@redhat.com> <59LofhYhxl7MLEuElXwZcESRB6MpjdG-iq-89B63siDRo5k0j-y6z-PVa6Y3iE1xE5LkJwpwTFi82bd0RZjB1yZbSJptFdPTBWfvOGj1W78=3D@protonmail.com> <61NBWPmN34lD25i-dND5emZReJ7UbgkAcSiy1eYvjwW?==?us-ascii?Q?O9ALSTArJ4NWvOqN5UDOvbmr=5FdTNdRFNBCkpuu5eL41dHdZfNcqH4UZru7JK2k50=3D@protonmail.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.6 required=5.0 tests=BAD_ENC_HEADER,BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Dec 06, 2023 at 07:33:21AM +0000, waffl3x wrote: > Here is the next version, it feels very close to finished. As before, I > haven't ran a bootstrap or the full testsuite yet but I did run the > explicit-obj tests which completed as expected. > > There's a few test cases that still need to be written but more tests > can always be added. The behavior added by CWG2789 works in at least > one case, but I have not added tests for it yet. The test cases for > dependent lambda expressions need to be fleshed out more, but a few > temporary ones are included to demonstrate that they do work and that > the crash is fixed. Explicit object conversion functions work, but I > need to add fleshed out tests for them, explicit-obj-basic5.C has that > test. > > I'll start the tests now and report back if anything fails, I'm > confident everything will be fine though. > > Alex > From 937e12c57145bfd878a0bc4cd9735c2d3c4fcf22 Mon Sep 17 00:00:00 2001 > From: Waffl3x > Date: Tue, 5 Dec 2023 23:16:01 -0700 > Subject: [PATCH] P0847R7 (Deducing This) [PR102609] Another quick and dirty > patch for review, hopefully the last. gcc/cp/ChangeLog: > Please add PR c++/102609 line above this. > * call.cc (build_this_conversion): Note, for the final submission, all the ): should be followed by descriptions what has changed in there (but not why). Plus it would be good to mention somewhere early in the cp/ChangeLog entry that the patch implements C++23 P0847R7 - Deducing this paper (unfortunately the ChangeLog verifier doesn't allow such free text above the ChangeLog entry where it used to be written some years ago, only allows there the PR line; I usually put such text after the ): of the first entry now and only after it write exactly what changed in that function. Does the patch also implement CWG2586? Also, I don't see in the patch the expected gcc/c-family/ * c-cppbuiltin.cc (c_cpp_builtins): Predefine __cpp_explicit_this_parameter=202110L for C++23. part plus gcc/testsuite/cpp{23,26}/feat-cxx*.C additions checking for that macro presence and its value. Jakub