From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 648C93858281 for ; Wed, 6 Dec 2023 14:34:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 648C93858281 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 648C93858281 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701873253; cv=none; b=oqUxUnKhW4TQLa6YiZXF+83jXy7O+LiMAD9967EaMs2sSQcM9+c0gLlnOXiAecxlP6bBz/43eyX8msQkqj7e+xUMavINn8IUxy0LKk9S4vMrFQ1QM50Ke+Syi55wIE/F68HG29/A9MXTe9OYy6zwvHE8lBeMVy+LNA09rDW5/D4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701873253; c=relaxed/simple; bh=OGU/KtxcrvP3I9ndbB5YZXbZs//TgcG4ZiHKRKtKUvo=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=rRbjn7jn/Q+TimBeTiIXDWwk+P3nnSqstjV4wT8cIY4CI7vNvSfBJ935ic3YFV+kpQJp0nvCgRKcTpoTsB2PJ7pd7m8cHZvrVT0Kx/KrYigPpBDEYMdA2XIF0V5kzKLKcPdGWrfuuaAS80tR/gzpgr67qbFwzN+nZwAsMsufda8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701873250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OoE0qbVfScDbtEdWBMd+0ySshYYEn73qxVL7oRqWtTk=; b=hDukcLymgcYxuSXiVOUa2KTnCNnHFTKJfh2WLSsV/wbiqlABewAN9+ZMKQngk8dicRCrbd tvHenTU+mSkBmzY7UQBLaCLDRYD4XVChyiQuY77NvnOr9HICFy3CrjpojTWHUTqpxk7Bkg s7S/a+4T5X4IocKBBeQTKsRwMxjgMro= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-346-Ggi_YCNIOSqWG9j19IEw9w-1; Wed, 06 Dec 2023 09:34:06 -0500 X-MC-Unique: Ggi_YCNIOSqWG9j19IEw9w-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-77d7a92f883so1113214385a.0 for ; Wed, 06 Dec 2023 06:34:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701873246; x=1702478046; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OoE0qbVfScDbtEdWBMd+0ySshYYEn73qxVL7oRqWtTk=; b=lFSRhC3EpdcB9FlicFN+1gME1X5P2WDOX5B7a4/x8Epg2BB/CbKjEQiVCLYd1tMKDH U6hNTTZCi2WwIGPIXmCr3vF4YVhV6SH49qQAbCP/tPaNTncM4pPEbZG83Hu2XnAAXLXG bww2bhyBW+DByjyohElGDjavHm6KZA8qg64NqAYbGlRjvVEgZ+qbPkTUPBo9S5XaBjod 4d1yT3C31VM2Wx7WtOJ0ExrzOcOJOKW0fVdFkAUaA1+y0xo2QDFyWjoo2yx4dif4VmXP osNTqSL6NMBIpUUujHnYGlqbJVEK/lYWbu5f40zsSTszQ98/CVtAJQRvOUWS4/ov5g+8 Ardg== X-Gm-Message-State: AOJu0Yztz00nXkAftyzyBgCMSyD7qaKzobKBITidPY5RLFu8kXz34+rk NR+RembzaASgtC6bZ6pk9H05IuRcaZMB/oOikSOyE9RMy6kJCQ6qamV+4VPJFpJ1T2162AcJN4G iNCT4GfL3BIDnaQvJSw== X-Received: by 2002:ae9:e709:0:b0:77f:35e3:a493 with SMTP id m9-20020ae9e709000000b0077f35e3a493mr493131qka.65.1701873246223; Wed, 06 Dec 2023 06:34:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUh832t2L078OzN17cm8/RopyeEvprfMF/LpTuWI/vwQmSx4B+JCbOZwNpibRqd3qDZ/nsGA== X-Received: by 2002:ae9:e709:0:b0:77f:35e3:a493 with SMTP id m9-20020ae9e709000000b0077f35e3a493mr493121qka.65.1701873245962; Wed, 06 Dec 2023 06:34:05 -0800 (PST) Received: from redhat.com (2603-7000-9500-34a5-0000-0000-0000-1db4.res6.spectrum.com. [2603:7000:9500:34a5::1db4]) by smtp.gmail.com with ESMTPSA id y18-20020a05620a44d200b0077da7a46b0fsm5940853qkp.69.2023.12.06.06.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 06:34:05 -0800 (PST) Date: Wed, 6 Dec 2023 09:34:03 -0500 From: Marek Polacek To: Prathamesh Kulkarni Cc: Jason Merrill , GCC Patches Subject: Re: [PATCH v8] c++: implement P2564, consteval needs to propagate up [PR107687] Message-ID: References: <6a3303b5-85b3-4d8f-a4e3-4f41455ec6d1@redhat.com> <1d9a1b66-c1ba-4aa1-80e3-09c5e1840845@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.10 (2023-03-25) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Dec 06, 2023 at 05:09:21PM +0530, Prathamesh Kulkarni wrote: > On Tue, 5 Dec 2023 at 06:18, Marek Polacek wrote: > > > > On Mon, Dec 04, 2023 at 04:49:29PM -0500, Jason Merrill wrote: > > > On 12/4/23 15:23, Marek Polacek wrote: > > > > +/* FN is not a consteval function, but may become one. Remember to > > > > + escalate it after all pending templates have been instantiated. */ > > > > + > > > > +void > > > > +maybe_store_immediate_escalating_fn (tree fn) > > > > +{ > > > > + if (unchecked_immediate_escalating_function_p (fn)) > > > > + remember_escalating_expr (fn); > > > > +} > > > > > > > +++ b/gcc/cp/decl.cc > > > > @@ -18441,7 +18441,10 @@ finish_function (bool inline_p) > > > > if (!processing_template_decl > > > > && !DECL_IMMEDIATE_FUNCTION_P (fndecl) > > > > && !DECL_OMP_DECLARE_REDUCTION_P (fndecl)) > > > > - cp_fold_function (fndecl); > > > > + { > > > > + cp_fold_function (fndecl); > > > > + maybe_store_immediate_escalating_fn (fndecl); > > > > + } > > > > > > I think maybe_store_, and the call to it from finish_function, are unneeded; > > > we will have already decided whether we need to remember the function during > > > the call to cp_fold_function. > > > > 'Tis true. > > > > > OK with that change. > > > > Here's what I pushed after another regtest. Thanks! > Hi Marek, > It seems the patch caused following regressions on aarch64: > > Running g++:g++.dg/modules/modules.exp ... > FAIL: g++.dg/modules/xtreme-header-4_b.C -std=c++2b (internal compiler > error: tree check: expected class 'type', have 'declaration' > (template_decl) in get_originating_module_decl, at cp/module.cc:18659) > FAIL: g++.dg/modules/xtreme-header-5_b.C -std=c++2b (internal compiler > error: tree check: expected class 'type', have 'declaration' > (template_decl) in get_originating_module_decl, at cp/module.cc:18659) > FAIL: g++.dg/modules/xtreme-header_b.C -std=c++2b (internal compiler > error: tree check: expected class 'type', have 'declaration' > (template_decl) in get_originating_module_decl, at cp/module.cc:18659) > > Log files: https://ci.linaro.org/job/tcwg_gcc_check--master-aarch64-build/1299/artifact/artifacts/00-sumfiles/ Are you sure it's caused by my patch? I reckon I've seen that FAIL many times before. Marek