From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 35B1D3858282 for ; Thu, 7 Dec 2023 16:44:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 35B1D3858282 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 35B1D3858282 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701967474; cv=none; b=JQETC0kCoMae27E4aXB4rk9iyWpqQ95T0U3/rZMGTL5fYwvhQ+pzWRCIufJQCQ0P9RBFzqxKb12sHoQ3r5dj0sdGYkTDgSzziyxoug1fFHw/91j2kIJu4TCih9roik5V6xyop68tdjG/Y+Laq5f/OLWWFv9ig7oqU/ILfOskM2w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701967474; c=relaxed/simple; bh=6A++wKMXFeXRqpGlBVT9vX/4oFX6FaTpZ0hIUlrnqHk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=o9priTFrwG1/xNn6irLFqINuhdqVATq0MFuBQJvoSnPZEGDTw6lck5MEGDLxU24nIvbL/oxVVWDATd9RmJeDwIIHXH0XytTRareFC2vZSiimKn11tFfvhlQctxzYupd1vz4ErMgObccelzETdTtimBUC6ltT3FJ2asp5rbByAUs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701967472; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aQA3fMWtY9CYje3iXl/Jng422TOzbYdxA4ylNI3+1NU=; b=N3RQ66It6BoGkQlJP03ZgF9x+oRQkXtDg/UWaetHy7010qRY/i0OyZeFCKLkzjOBgCsM2Y Lk6VD3+RVgJEods8mTQJAZEU1lOBmBqsizHeWE0eB4U5ChHA+bCOZE6N8IxAgS9xfdtLuu R8wtZR2GjbgEM214A+SzME/GDaTuvAQ= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-237-45zGJjrPMPOadZSDNjT6Jw-1; Thu, 07 Dec 2023 11:44:29 -0500 X-MC-Unique: 45zGJjrPMPOadZSDNjT6Jw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 710BB299E744; Thu, 7 Dec 2023 16:44:29 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.157]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 34A8F492BE6; Thu, 7 Dec 2023 16:44:29 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 3B7GiQhO166932 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 7 Dec 2023 17:44:27 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 3B7GiQCX166931; Thu, 7 Dec 2023 17:44:26 +0100 Date: Thu, 7 Dec 2023 17:44:25 +0100 From: Jakub Jelinek To: Marc =?iso-8859-1?Q?Poulhi=E8s?= Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] testsuite: adjust call to abort in excess-precision-12 Message-ID: Reply-To: Jakub Jelinek References: <20231207162743.686431-1-poulhies@adacore.com> MIME-Version: 1.0 In-Reply-To: <20231207162743.686431-1-poulhies@adacore.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 07, 2023 at 05:27:28PM +0100, Marc Poulhičs wrote: > abort() is not always available, using the builtin as done in other > tests. > > gcc/testsuite/ChangeLog: > > * g++.target/i386/excess-precision-12.C: call builtin_abort instead of abort. > --- > Tested on x86_64-linux and x86_64-elf. > > Ok for master? > > gcc/testsuite/g++.target/i386/excess-precision-12.C | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/testsuite/g++.target/i386/excess-precision-12.C b/gcc/testsuite/g++.target/i386/excess-precision-12.C > index dff48c07c8b..e59f7c3b1fb 100644 > --- a/gcc/testsuite/g++.target/i386/excess-precision-12.C > +++ b/gcc/testsuite/g++.target/i386/excess-precision-12.C > @@ -13,8 +13,8 @@ main (void) > unsigned long long int u = (1ULL << 63) + 1; > > if ((f <=> u) >= 0) > - abort (); > + __builtin_abort (); > > if ((u <=> f) <= 0) > - abort (); > + __builtin_abort (); Why wouldn't they have abort and what else does __builtin_abort () expand to? There are 2000+ other tests in gcc.target/i386/ which call abort (), not __builtin_abort (), after including directly or indirectly or declaring it themselves. This test in particular includes Does whatever target you are running this into provide just std::abort () and not abort (); from ? If so, perhaps it should call std::abort (); instead of abort (). Jakub