From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7B6A23858414 for ; Fri, 8 Dec 2023 12:04:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B6A23858414 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B6A23858414 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702037081; cv=none; b=CKw9AoDcEQEG7FDwvOdu1uzJnQMKJPPtegoRn2bqyhyQsXcL5/NMkrvHoHLMuwd6dLhnYv+Y9YvX04NoutMbsYIbUgFoXDicFsJrjDWPYYweuBHtLS2rr02m7GSMEf7rD2DC5nXeNM4ZIq0SSoW+d8eMPsPrKNtA/9D5KYJJPPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702037081; c=relaxed/simple; bh=6FAFbTtnwHe4rf8M+K8mqwXo+wmVaA8VM7wdPwXgfmY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=q+cDLQ2m0Raqjg5UUT/ReQDzc9EE74s6Qzb+iPrEF7lWdqJt3LOjuFib8QxwgfKTmHgNjv6WYomQlxEpQ4+7K9gPvm+OAPM+57yEXMzGxaBBCSZwwCZOjUINl9l8cXV/nJAbWh1VTTjfVV6sXJStExWWCkPASZPkCnGL8E/lgJY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702037080; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=1ecbddRN7dgUwgTsX12r4wcSs/9F+Ni2DEs/Lz3z8e0=; b=batPX2RlZrTrnRbUjQ7nmcakPh8+izV9xoh0bRMpMWbNCbFbDP3Ch++II2KL/cFRo1CDQq wlujIjcmzUMbyQ3ZmkGtExPJpzx+vI5XYUYc0vmHsrvFhMG9J4gGBqJet4OCtX6Las0vl1 27jvh1j0unClObYxOUg+0HLVFVqyTTo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-jVCH_qRnNV2NVRBqcMHXLg-1; Fri, 08 Dec 2023 07:04:36 -0500 X-MC-Unique: jVCH_qRnNV2NVRBqcMHXLg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D643385A58C; Fri, 8 Dec 2023 12:04:35 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.157]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9925F2166AE4; Fri, 8 Dec 2023 12:04:35 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 3B8C4WT52912066 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 8 Dec 2023 13:04:33 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 3B8C4WZt2912065; Fri, 8 Dec 2023 13:04:32 +0100 Date: Fri, 8 Dec 2023 13:04:31 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [patch] OpenMP/Fortran: Implement omp allocators/allocate for ptr/allocatables Message-ID: Reply-To: Jakub Jelinek References: <60940754-edc6-4110-b7ba-5bed2133bbb6@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <60940754-edc6-4110-b7ba-5bed2133bbb6@codesourcery.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 08, 2023 at 05:58:10PM +0100, Tobias Burnus wrote: > --- a/gcc/builtins.cc > +++ b/gcc/builtins.cc > @@ -11739,6 +11739,7 @@ builtin_fnspec (tree callee) > return ".cO "; > /* Realloc serves both as allocation point and deallocation point. */ > case BUILT_IN_REALLOC: > + case BUILT_IN_GOMP_REALLOC: > return ".Cw "; I must say I've never been sure if one needs to specify those ". " for integral arguments for which nothing is known; if they would need to be, then also all the BUILT_IN_GOMP_* other cases would be wrong, but not just those, also BUILT_IN_*_CHK (which have extra size_t argument) or here BUILT_IN_REALLOC itself. So, let's hope it is ok as is. Otherwise, the middle-end changes look just fine to me, and for Fortran FE I'm afraid you know it much more than I do. Jakub