From: Jakub Jelinek <jakub@redhat.com>
To: Hongyu Wang <hongyu.wang@intel.com>
Cc: gcc-patches@gcc.gnu.org, ubizjak@gmail.com, hongtao.liu@intel.com
Subject: Re: [PATCH] i386: Fix missed APX_NDD check for shift/rotate expanders [PR 112943]
Date: Mon, 11 Dec 2023 13:27:59 +0100 [thread overview]
Message-ID: <ZXcAT81mFiP5+FQM@tucnak> (raw)
In-Reply-To: <20231211122020.3645581-1-hongyu.wang@intel.com>
On Mon, Dec 11, 2023 at 08:20:20PM +0800, Hongyu Wang wrote:
LGTM but will defer review of the patch to Hongtao or Uros.
> + __int128 u128_2 = (9223372036854775808 << 4) * foo0_u8_0; /* { dg-warning "integer constant is so large that it is unsigned" "so large" } */
Just you can use (9223372036854775807LL + (__int128) 1) instead of 9223372036854775808
to avoid the warning.
The testcase will ICE without the patch even with that.
Jakub
next prev parent reply other threads:[~2023-12-11 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 12:20 Hongyu Wang
2023-12-11 12:27 ` Jakub Jelinek [this message]
2023-12-11 12:39 ` Hongyu Wang
2023-12-12 2:49 ` Hongtao Liu
2023-12-14 21:01 FX Coudert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXcAT81mFiP5+FQM@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=hongyu.wang@intel.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).