From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E027138582B1 for ; Mon, 11 Dec 2023 12:28:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E027138582B1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E027138582B1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702297688; cv=none; b=CfEARQ5MmMlYPDqAnpr58rF2NyEDPER8VEgPPOyPl0A7NzhNrRKG24pTZwCcHUtCkRpJ8pE00mRvRV/I2l1O8B7tz8sXv40XcPrqH4ZZByQruD3ASLovfbssqcxLMmsQ8IUFB74oeMRszdqTRZu3qkqp0JYHPtxF3z6A219g428= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702297688; c=relaxed/simple; bh=IXHAJ/iMKfdt/nuDXHD3IFvggKXDG5MtLli+otuf93Q=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=cuFR54BSHE9ul6e0EuHeEdtRdU2AXPIHIizoRoy06L7j8ZgJtEoIqOO3d7+hvyt97Tb9vcdjy2Z5ENwkUCxTfOeb6pkGGqjodtX05ZdIyw4H6UI7oe4aKkHAr7GkmWmzCDMITsgBIMQmoC/458spUDhToFe+uzsOaumSWjc5zdc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702297687; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Vp1pXn8TouC7uwcUW0aydpMyjeKQQLKKsoRJytlieOw=; b=DljT9M1fRzhhvpVCNp90lQ+xW92flvOFkFbVRVdvFgnAOzLACPw6dAnisTT4/K0O9CNplC 9UoPbMXXiiJysPWGCaVYfmyQoIWoWnKgaKsLewJVlQs0Dp9A+paVqsV2TSJy1k0xkGVirK o6H8XuOShTn22j8YDLpmQaZvPOzf6CQ= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-KeCANO6QMauuTKl8lTimDA-1; Mon, 11 Dec 2023 07:28:04 -0500 X-MC-Unique: KeCANO6QMauuTKl8lTimDA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EF1171C3B646; Mon, 11 Dec 2023 12:28:03 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.92]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B26E71C060AF; Mon, 11 Dec 2023 12:28:03 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 3BBCS0aJ2888431 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 11 Dec 2023 13:28:01 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 3BBCS0Nr2888413; Mon, 11 Dec 2023 13:28:00 +0100 Date: Mon, 11 Dec 2023 13:27:59 +0100 From: Jakub Jelinek To: Hongyu Wang Cc: gcc-patches@gcc.gnu.org, ubizjak@gmail.com, hongtao.liu@intel.com Subject: Re: [PATCH] i386: Fix missed APX_NDD check for shift/rotate expanders [PR 112943] Message-ID: Reply-To: Jakub Jelinek References: <20231211122020.3645581-1-hongyu.wang@intel.com> MIME-Version: 1.0 In-Reply-To: <20231211122020.3645581-1-hongyu.wang@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Dec 11, 2023 at 08:20:20PM +0800, Hongyu Wang wrote: LGTM but will defer review of the patch to Hongtao or Uros. > + __int128 u128_2 = (9223372036854775808 << 4) * foo0_u8_0; /* { dg-warning "integer constant is so large that it is unsigned" "so large" } */ Just you can use (9223372036854775807LL + (__int128) 1) instead of 9223372036854775808 to avoid the warning. The testcase will ICE without the patch even with that. Jakub