From: Jan Hubicka <hubicka@ucw.cz>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] ipa/92606 - properly handle no_icf attribute for variables
Date: Tue, 12 Dec 2023 15:19:45 +0100 [thread overview]
Message-ID: <ZXhsAeqD9h+IzHu1@kam.mff.cuni.cz> (raw)
> The following adds no_icf handling for variables where the attribute
> was rejected. It also fixes the check for no_icf by checking both
> the source and the targets decl.
>
> Bootstrap / regtest running on x86_64-unknown-linux-gnu.
>
> This would solve the AVR issue with merging of "progmem" attributed
> and non-"progmem" attributed variables if they'd also add no_icf there.
>
> OK?
>
> Thanks,
> Richard.
>
> PR ipa/92606
> gcc/c-family/
> * c-attribs.cc (handle_noicf_attribute): Also allow the
> attribute on global variables.
>
> gcc/
> * ipa-icf.cc (sem_item_optimizer::merge_classes): Check
> both source and alias for the no_icf attribute.
> * doc/extend.texi (no_icf): Document variable attribute.
OK,
thanks!
Honza
next reply other threads:[~2023-12-12 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 14:19 Jan Hubicka [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-11 9:17 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXhsAeqD9h+IzHu1@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).