From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=3x6F=HX=kam.mff.cuni.cz=hubicka@sourceware.org>
Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16])
	by sourceware.org (Postfix) with ESMTPS id 497E73858418
	for <gcc-patches@gcc.gnu.org>; Tue, 12 Dec 2023 14:21:09 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 497E73858418
Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=ucw.cz
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kam.mff.cuni.cz
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 497E73858418
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.113.20.16
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702390870; cv=none;
	b=jCS2pe0me+EeKkOjHJxkafYoSQJ0wKRBuirJ1VG+QxOPDwgzewBji9Wrpy9OsCrHtmGg+4Mss7/Uy38M34+JUMyXy1hl0PeSmI7LReACfwP3iye1vUShl6+puNUhKiLz6DUXIXfYaQhuw7/+7QnGQCynjtP+plFwgvxyCRLSifU=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1702390870; c=relaxed/simple;
	bh=4fBUREMHMj6mn0nE5M2BdmCCvFJghHD3C+ykf0Q3j3c=;
	h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=dsQFKl6CuJ49KovGa4vEcjUS4kDWJ0ze0CR0Vogyrg/GndAdGFpd6Q1H2M1BWuiXeeyUQ+6ihnrNhlsj8PB14rvTbeofQ3HJg7dZt2v8DALHAAz2MEAZxyH5aQVEXMBobF7mouePjQ6VjBxXXA6Yt8w6nRro3BaLGIVYZIzNyfQ=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202)
	id 6065E28BFF5; Tue, 12 Dec 2023 15:21:08 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;
	t=1702390868;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=AkTi5r+rApfO92mRr7ZFdi6G0WO7xJ4k02iuuRhqXQc=;
	b=GrJW3x0eIJeKMxWB0i1AEKTTHQA5K/XGffrFDJZn3noN4pbXs1Lff/YEhaMP0UYZgSLJpl
	MkKfA6CQ8xpxxbtfbok1Kf3/3T0awIYjWrzhDSvfV1N7f4pC1IlIw0hJj6Hy/scXBx+Nji
	LEyHGoABshv4nG1nYQDzKlr8wl2eCck=
Date: Tue, 12 Dec 2023 15:21:08 +0100
From: Jan Hubicka <hubicka@ucw.cz>
To: Alexandre Oliva <oliva@adacore.com>
Cc: Richard Biener <richard.guenther@gmail.com>, gcc-patches@gcc.gnu.org,
	Jeremy Bennett <jeremy.bennett@embecosm.com>,
	Craig Blackmore <craig.blackmore@embecosm.com>,
	Graham Markall <graham.markall@embecosm.com>,
	Martin Jambor <mjambor@suse.cz>, Jim Wilson <wilson@tuliptree.org>,
	Jeff Law <jeffreyalaw@gmail.com>, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] strub: add note on attribute access
Message-ID: <ZXhsVMd5Kx4rshz8@kam.mff.cuni.cz>
References: <orcyw0n3g8.fsf@lxoliva.fsfla.org>
 <CAFiYyc01uyz4eRVZ=4QpsQax38Jq0HzwSBYL8ihW2SrscGqhtQ@mail.gmail.com>
 <or1qc9lz4c.fsf@lxoliva.fsfla.org>
 <CAFiYyc0t-5TKoRFgs6x1huWX80QZGjin2oW5eyMi2TnN_YZudA@mail.gmail.com>
 <orr0k7280k.fsf@lxoliva.fsfla.org>
 <CAFiYyc0MiDZ3CZ=L5uDyZjEr0XLpQf9cSn+RSBKAQkXjVerQvw@mail.gmail.com>
 <ormsuswkss.fsf_-_@lxoliva.fsfla.org>
 <ZXBLVaM/ZnPmV9wP@kam.mff.cuni.cz>
 <orplzhbsk1.fsf@lxoliva.fsfla.org>
 <orbkb0b00e.fsf_-_@lxoliva.fsfla.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <orbkb0b00e.fsf_-_@lxoliva.fsfla.org>
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

> On Dec  7, 2023, Alexandre Oliva <oliva@adacore.com> wrote:
> 
> > Thanks for raising the issue.  Maybe there should be at least a comment
> > there, and perhaps some asserts to check that pointer and reference
> > types don't make to indirect_parms.
> 
> Document why attribute access doesn't need the same treatment as fn
> spec, and check that the assumption behind it holds.
> 
> Regstrapped on x86_64-linux-gnu.  Ok to install?
> 
> 
> for  gcc/ChangeLog
> 
> 	* ipa-strub.cc (pass_ipa_strub::execute): Check that we don't
> 	add indirection to pointer parameters, and document attribute
> 	access non-interactions.
OK,
Honza