From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A66943858C78 for ; Wed, 13 Dec 2023 10:56:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A66943858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A66943858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702464962; cv=none; b=f80DXykKtgKpodWp8caiaoR9uWLpnbVNsFm24ouj5N/Neuw5/02vxMGgLnogsS5FZere7lnF5GtmwQ/RkT4Pn0ZwEM4tZQVc+pXeH1PgKABRYvnQ5He3l4gFs0mKG6cEsL9HfffQP8oXW6U68viikSkPRLoPh5YoTXxQlKdZfco= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702464962; c=relaxed/simple; bh=BGWc1O8Q4usMFO6Ad/aKQ1kMXvZCuZftMr7fHkk5b24=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=QwepsAw7UvmwH0ED/l+iTwNYSVZYEX3pXlkFkm5lCrSbOdRBWNss0dShr8eCWc/CM2aUgrICVbDWW6mAsaL3b2yUI3grMFE9KYJ0+/t1mwPdXIF9q0mvucQiHONeXLdfdkP8U4fTbkMn28iYkpIdgIgui/PSmZvHi4rLNAEkn3c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702464961; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=vOQIZr3W1x/qWPItcv6V+4N2zOi+FVYVlNd6iP7l0fM=; b=eiHA9TIx5tnz+gXSLVBHHVWCP0yvakSW37xeEPiuPMmwRtP4rYTrgYYcmN11Arqwo7lOLM ox+X9LqVWjGSl+PVaXCfPLHM4CeNCkY2URiiNCSnTxRMamSwj5a8nri6fW2mRPzVh2iFhT FOWAE3gzgAkre2hPA+O1nvOLwd6aEtI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-547-srPiMUuAOuyfwXXQ-M6NAA-1; Wed, 13 Dec 2023 05:55:57 -0500 X-MC-Unique: srPiMUuAOuyfwXXQ-M6NAA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5094E836F8A; Wed, 13 Dec 2023 10:55:57 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.92]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1351E2026D66; Wed, 13 Dec 2023 10:55:56 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 3BDAtsbr2490492 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 13 Dec 2023 11:55:54 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 3BDAtrL82490491; Wed, 13 Dec 2023 11:55:53 +0100 Date: Wed, 13 Dec 2023 11:55:52 +0100 From: Jakub Jelinek To: "Andre Vieira (lists)" Cc: "gcc-patches@gcc.gnu.org" , Richard Biener Subject: Re: [PATCH] Fix tests for gomp Message-ID: Reply-To: Jakub Jelinek References: <3ec10d98-7dd6-4d25-9df5-7856cd87649f@arm.com> MIME-Version: 1.0 In-Reply-To: <3ec10d98-7dd6-4d25-9df5-7856cd87649f@arm.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Dec 13, 2023 at 10:43:16AM +0000, Andre Vieira (lists) wrote: > Hi, > > Apologies for the delay and this mixup. I need to do something different > > This is to fix testisms initially introduced by: > commit f5fc001a84a7dbb942a6252b3162dd38b4aae311 > Author: Andre Vieira > Date: Mon Dec 11 14:24:41 2023 +0000 > > aarch64: enable mixed-types for aarch64 simdclones > > gcc/testsuite/ChangeLog: > > * gcc.dg/gomp/pr87887-1.c: Fixed test. > * gcc.dg/gomp/pr89246-1.c: Likewise. > * gcc.dg/gomp/simd-clones-2.c: Likewise. > > libgomp/ChangeLog: > > * testsuite/libgomp.c/declare-variant-1.c: Fixed test. > * testsuite/libgomp.fortran/declare-simd-1.f90: Likewise. > > OK for trunk? I was intending to commit as obvious, but jakub had made a > comment about declare-simd-1.f90 so I thought it might be worth just sending > it up to the mailing list first. > --- a/libgomp/testsuite/libgomp.c/declare-variant-1.c > +++ b/libgomp/testsuite/libgomp.c/declare-variant-1.c > @@ -40,16 +40,17 @@ f04 (int a) > int > test1 (int x) > { > - /* At gimplification time, we can't decide yet which function to call. */ > - /* { dg-final { scan-tree-dump-times "f04 \\\(x" 2 "gimple" } } */ > + /* At gimplification time, we can't decide yet which function to call for > + x86_64 targets, given the f01 variant. */ > + /* { dg-final { scan-tree-dump-times "f04 \\\(x" 2 "gimple" { target x86_64-*-* } } } */ > /* After simd clones are created, the original non-clone test1 shall > call f03 (score 6), the sse2/avx/avx2 clones too, but avx512f clones > shall call f01 with score 8. */ > /* { dg-final { scan-ltrans-tree-dump-not "f04 \\\(x" "optimized" } } */ > - /* { dg-final { scan-ltrans-tree-dump-times "f03 \\\(x" 14 "optimized" { target { !aarch64*-*-* } } } } } */ > - /* { dg-final { scan-ltrans-tree-dump-times "f01 \\\(x" 4 "optimized" { target { !aarch64*-*-* } } } } } */ > - /* { dg-final { scan-ltrans-tree-dump-times "f03 \\\(x" 10 "optimized" { target { aarch64*-*-* } } } } } */ > - /* { dg-final { scan-ltrans-tree-dump-not "f01 \\\(x" "optimized" { target { aarch64*-*-* } } } } } */ > + /* { dg-final { scan-ltrans-tree-dump-times "f03 \\\(x" 14 "optimized" { target { !aarch64*-*-* } } } } */ > + /* { dg-final { scan-ltrans-tree-dump-times "f01 \\\(x" 4 "optimized" { target { !aarch64*-*-* } } } } */ > + /* { dg-final { scan-ltrans-tree-dump-times "f03 \\\(x" 10 "optimized" { target { aarch64*-*-* } } } } */ > + /* { dg-final { scan-ltrans-tree-dump-not "f01 \\\(x" "optimized" { target { aarch64*-*-* } } } } */ The changes in this test look all wrong. The differences are i?86-*-* x86_64-*-* (which can support avx512f isa) vs. other targets (which can't). So, there is nothing aarch64 specific in there and { target x86_64-*-* } is also incorrect. It should be simply { target i?86-*-* x86_64-*-* } vs. { target { ! { i?86-*-* x86_64-*-* } } } (never sure about the ! syntaxes). The other changes LGTM. Jakub