From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7D3B83858D39 for ; Wed, 13 Dec 2023 11:00:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D3B83858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7D3B83858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702465215; cv=none; b=PXsssQhBYuyZk+CRosyyt+X/k+BwxOAXbuAC7qYU99zJNblSLux0OFaMvrD1LjuNMVL73pONckNJLLKgBkIHkWy/Io+ItlLGaCq9FJY1ZD+WELCyCqEPrYRSp1w4u8RNiLVFIz/o1qaRsTNW2Y3aNYBNy9OLsZfWkgMfTmn5GpA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702465215; c=relaxed/simple; bh=y90HD5JCgcppotDtKFArGifKHuOClv0IgTMVsS8ithQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=CKNpi2JPq6GFo6VyesWFr0qqC73FSV2dhfgJYxVMDDddFjpfkr+i04iltu6lmjOGvsThwwi4kGBZx0ogHfRCnQjRpFE35wID0lJHXDlag/3Kxb6mYNSno1l1x9e8T7gSw3gPtPrEsfqOg5lBeoY2BRSI+kSKa1xVFBVAwKFJpoY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702465214; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=DwRoHecU5Hq0ykNbpoxrIFuoWnAW5osOxSD5zLhCVPU=; b=GZg7m1am6amhV0gAt0SVx1YRbUSoZznQZ19vxlXyUbz4X/x/YvYRiKBPwnMU2OrQWUV0qH VN236rheaCgRP1xHUg8ksDkKKPaAlj+9T3CCM/8HwVjnzBphpcGVTMCtGld7aC/2xwInlw xJFDw5VoTDcoOqkRourZKKQfQRs5Byw= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-Mbfc4MdMOKCQ0G-MabKR_Q-1; Wed, 13 Dec 2023 06:00:12 -0500 X-MC-Unique: Mbfc4MdMOKCQ0G-MabKR_Q-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C65B61C068DB; Wed, 13 Dec 2023 11:00:11 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.92]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A218492BE6; Wed, 13 Dec 2023 11:00:11 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 3BDB08vl2490505 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 13 Dec 2023 12:00:09 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 3BDB08e82490504; Wed, 13 Dec 2023 12:00:08 +0100 Date: Wed, 13 Dec 2023 12:00:07 +0100 From: Jakub Jelinek To: "Andre Vieira (lists)" , "gcc-patches@gcc.gnu.org" , Richard Biener Subject: Re: [PATCH] Fix tests for gomp Message-ID: Reply-To: Jakub Jelinek References: <3ec10d98-7dd6-4d25-9df5-7856cd87649f@arm.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Dec 13, 2023 at 11:55:52AM +0100, Jakub Jelinek wrote: > On Wed, Dec 13, 2023 at 10:43:16AM +0000, Andre Vieira (lists) wrote: > > --- a/libgomp/testsuite/libgomp.c/declare-variant-1.c > > +++ b/libgomp/testsuite/libgomp.c/declare-variant-1.c > > @@ -40,16 +40,17 @@ f04 (int a) > > int > > test1 (int x) > > { > > - /* At gimplification time, we can't decide yet which function to call. */ > > - /* { dg-final { scan-tree-dump-times "f04 \\\(x" 2 "gimple" } } */ > > + /* At gimplification time, we can't decide yet which function to call for > > + x86_64 targets, given the f01 variant. */ > > + /* { dg-final { scan-tree-dump-times "f04 \\\(x" 2 "gimple" { target x86_64-*-* } } } */ > > /* After simd clones are created, the original non-clone test1 shall > > call f03 (score 6), the sse2/avx/avx2 clones too, but avx512f clones > > shall call f01 with score 8. */ > > /* { dg-final { scan-ltrans-tree-dump-not "f04 \\\(x" "optimized" } } */ > > - /* { dg-final { scan-ltrans-tree-dump-times "f03 \\\(x" 14 "optimized" { target { !aarch64*-*-* } } } } } */ > > - /* { dg-final { scan-ltrans-tree-dump-times "f01 \\\(x" 4 "optimized" { target { !aarch64*-*-* } } } } } */ > > - /* { dg-final { scan-ltrans-tree-dump-times "f03 \\\(x" 10 "optimized" { target { aarch64*-*-* } } } } } */ > > - /* { dg-final { scan-ltrans-tree-dump-not "f01 \\\(x" "optimized" { target { aarch64*-*-* } } } } } */ > > + /* { dg-final { scan-ltrans-tree-dump-times "f03 \\\(x" 14 "optimized" { target { !aarch64*-*-* } } } } */ > > + /* { dg-final { scan-ltrans-tree-dump-times "f01 \\\(x" 4 "optimized" { target { !aarch64*-*-* } } } } */ > > + /* { dg-final { scan-ltrans-tree-dump-times "f03 \\\(x" 10 "optimized" { target { aarch64*-*-* } } } } */ > > + /* { dg-final { scan-ltrans-tree-dump-not "f01 \\\(x" "optimized" { target { aarch64*-*-* } } } } */ > > The changes in this test look all wrong. The differences are > i?86-*-* x86_64-*-* (which can support avx512f isa) vs. other targets (which > can't). > So, there is nothing aarch64 specific in there and { target x86_64-*-* } > is also incorrect. It should be simply > { target i?86-*-* x86_64-*-* } > vs. > { target { ! { i?86-*-* x86_64-*-* } } } > (never sure about the ! syntaxes). Or even better just make the whole test i?86-*-* x86_64-*-* specific. It is really testing the details how many clones are created and what is called in them, so nothing that applies to other architectures and how many clones those have will differ, but what exactly will be called in there will be the same. Jakub