From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 242A8385842D for ; Thu, 14 Dec 2023 19:29:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 242A8385842D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 242A8385842D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702582184; cv=none; b=LEtTotdqz9PRj+uLgtseAX8+Vdru9hiSAxorGZ1X2WH0xNGSxF7BO2QYMTVB+S7NKK+zyg9Q4reoVnrPveQ5NUY1I0fMhF6bjhNiFhIOmkunaN9CkT///esRdyZuyEPzhzgn52Qt7w9g48nfpnSvcwnjIUOBykaBFA/mCM+ZuHI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702582184; c=relaxed/simple; bh=7z8Yj23sBBUhhUmv6qaYGdNQNRct88Fb3BMJddafql4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=lIVgHQhyYRkf572bd45waqBwMrTFkr/7mcZqAjo+7ILNIxR+/6oUSB/fxuO/SXQOiOeh/BbpANcO/JlCJRe5hf2GC8tolhNW1nMe1qM+yDSDqP262aBl28CKVmaYyk4bmPPwhYCdE4h7bLiEOfdAq5UEOkwitqRVTCR91MGUsEg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702582182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CbAj/CBkSJpAPYYKgdC2+plgWOkBWKaUTmmVKWP2xs4=; b=SAjHEDexuux/+4VxYev/2oO05jXj4QvVSsQcwLjAVrjp4GZ/1NtrTmv1ppxJXep8ux6QTX tmnW8xYnEr8rO6/Y5BKDywEZWH73Y7cDU3kuPwkGE2VXx15JW/869xs9smn9SejaJqZCOr eGZsB/xP2muhaE3fecrqhZ9RttcSb6o= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-113-iZjKa_6gMJS6laewinN1jQ-1; Thu, 14 Dec 2023 14:29:41 -0500 X-MC-Unique: iZjKa_6gMJS6laewinN1jQ-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-42593d04ef6so70553671cf.2 for ; Thu, 14 Dec 2023 11:29:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702582180; x=1703186980; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CbAj/CBkSJpAPYYKgdC2+plgWOkBWKaUTmmVKWP2xs4=; b=gcQbpWX5Z9o1Yc3LmNCIGjpaMHMTbAWMtjKGVbKOJ18JZUqOLvFuMBH+IR6WbNzg0M QqX2R3Uh648tXd9PvEdbr3W8cTHHCIOsoMNz5kqIokYQec8AdPeAjNzMdbJDLJpKwHh0 JWLOac6CTKPZDdde77Ihf+cIEaKmHtgPYc5BTrLktTMCuix7/QKfjBB4j0nJ6JBOvzYO PfIw/fb5cTIPsJW/xVE2hPb5zuL3LafldaNzTadD5+L0xj1+oq1gg2+zsjn3l2NyA40J 8MP69t9wDsGEFM0jXt/gIwuYjSbS1v/PuBNT9uYBSNyXYhgvoLhoEivl8JgXC3d8UL/L LA5w== X-Gm-Message-State: AOJu0YwWrkzoU5CTw/lPTxd7LydHInl7Koz3YadDSr5PBfiQHVmy1DIN W0YMc+fuYxzw+XpDhLOV52sYg4ZsZmZLb26f8IoInYlVxKhI6xIlBya3lT/YQ2BWv1GYpG9PCXb zS6iGcVJA2a55mj5Dqw== X-Received: by 2002:a05:622a:1309:b0:425:83bc:e373 with SMTP id v9-20020a05622a130900b0042583bce373mr8368982qtk.62.1702582180725; Thu, 14 Dec 2023 11:29:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IELXzahAlGhdodZr7Cssvz0lWm3XYACF5GxB1A0PC4tt6Cb9njUkCnTXtKJU1yu+F9ATKh6WQ== X-Received: by 2002:a05:622a:1309:b0:425:83bc:e373 with SMTP id v9-20020a05622a130900b0042583bce373mr8368972qtk.62.1702582180469; Thu, 14 Dec 2023 11:29:40 -0800 (PST) Received: from redhat.com (2603-7000-9500-34a5-0000-0000-0000-1db4.res6.spectrum.com. [2603:7000:9500:34a5::1db4]) by smtp.gmail.com with ESMTPSA id p20-20020ac87414000000b00423dfab8fc3sm6047750qtq.32.2023.12.14.11.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 11:29:39 -0800 (PST) Date: Thu, 14 Dec 2023 14:29:38 -0500 From: Marek Polacek To: Patrick Palka Cc: gcc-patches@gcc.gnu.org, jason@redhat.com Subject: Re: [PATCH] c++: section attribute on templates [PR70435, PR88061] Message-ID: References: <20231214191725.1941372-1-ppalka@redhat.com> MIME-Version: 1.0 In-Reply-To: <20231214191725.1941372-1-ppalka@redhat.com> User-Agent: Mutt/2.2.10 (2023-03-25) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 14, 2023 at 02:17:25PM -0500, Patrick Palka wrote: > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for > trunk? LGTM. > -- >8 -- > > The section attribute currently has no effect on templates because the > call to set_decl_section_name only happens at parse time and not also at > instantiation time. This patch fixes this by propagating the section > name from the template to the instantiation. > > PR c++/70435 > PR c++/88061 > > gcc/cp/ChangeLog: > > * pt.cc (tsubst_function_decl): Call set_decl_section_name. > (tsubst_decl) : Likewise. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/attr-section1.C: New test. > * g++.dg/ext/attr-section1a.C: New test. > * g++.dg/ext/attr-section2.C: New test. > * g++.dg/ext/attr-section2a.C: New test. > --- > gcc/cp/pt.cc | 4 ++++ > gcc/testsuite/g++.dg/ext/attr-section1.C | 9 +++++++++ > gcc/testsuite/g++.dg/ext/attr-section1a.C | 11 +++++++++++ > gcc/testsuite/g++.dg/ext/attr-section2.C | 9 +++++++++ > gcc/testsuite/g++.dg/ext/attr-section2a.C | 14 ++++++++++++++ > 5 files changed, 47 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/attr-section1.C > create mode 100644 gcc/testsuite/g++.dg/ext/attr-section1a.C > create mode 100644 gcc/testsuite/g++.dg/ext/attr-section2.C > create mode 100644 gcc/testsuite/g++.dg/ext/attr-section2a.C > > diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc > index 50e6f062c85..8c4174fb902 100644 > --- a/gcc/cp/pt.cc > +++ b/gcc/cp/pt.cc > @@ -14607,6 +14607,8 @@ tsubst_function_decl (tree t, tree args, tsubst_flags_t complain, > = remove_attribute ("visibility", DECL_ATTRIBUTES (r)); > } > determine_visibility (r); > + if (DECL_SECTION_NAME (t)) > + set_decl_section_name (r, t); > if (DECL_DEFAULTED_OUTSIDE_CLASS_P (r) > && !processing_template_decl) > defaulted_late_check (r); > @@ -15423,6 +15425,8 @@ tsubst_decl (tree t, tree args, tsubst_flags_t complain, > = remove_attribute ("visibility", DECL_ATTRIBUTES (r)); > } > determine_visibility (r); > + if (!local_p && DECL_SECTION_NAME (t)) > + set_decl_section_name (r, t); > } > > if (!local_p) > diff --git a/gcc/testsuite/g++.dg/ext/attr-section1.C b/gcc/testsuite/g++.dg/ext/attr-section1.C > new file mode 100644 > index 00000000000..b8ac65baa93 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/attr-section1.C > @@ -0,0 +1,9 @@ > +// PR c++/70435 > +// { dg-do compile { target { c++11 && named_sections } } } > + > +template > +[[gnu::section(".foo")]] void fun() { } > + > +template void fun(); > + > +// { dg-final { scan-assembler {.section[ \t]+.foo} } } > diff --git a/gcc/testsuite/g++.dg/ext/attr-section1a.C b/gcc/testsuite/g++.dg/ext/attr-section1a.C > new file mode 100644 > index 00000000000..be24be2fc95 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/attr-section1a.C > @@ -0,0 +1,11 @@ > +// PR c++/70435 > +// { dg-do compile { target { c++11 && named_sections } } } > + > +template > +struct A { > + [[gnu::section(".foo")]] void fun() { } > +}; > + > +template struct A; > + > +// { dg-final { scan-assembler {.section[ \t]+.foo} } } > diff --git a/gcc/testsuite/g++.dg/ext/attr-section2.C b/gcc/testsuite/g++.dg/ext/attr-section2.C > new file mode 100644 > index 00000000000..a76f43b346f > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/attr-section2.C > @@ -0,0 +1,9 @@ > +// PR c++/88061 > +// { dg-do compile { target { c++14 && named_sections } } } > + > +template > +[[gnu::section(".foo")]] int var = 42; > + > +template int var; > + > +// { dg-final { scan-assembler {.section[ \t]+.foo} } } > diff --git a/gcc/testsuite/g++.dg/ext/attr-section2a.C b/gcc/testsuite/g++.dg/ext/attr-section2a.C > new file mode 100644 > index 00000000000..a0b01cd8d93 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/attr-section2a.C > @@ -0,0 +1,14 @@ > +// PR c++/88061 > +// { dg-do compile { target { c++11 && named_sections } } } > + > +template > +struct A { > + [[gnu::section(".foo")]] static int var; > +}; > + > +template > +int A::var = 42; > + > +template struct A; > + > +// { dg-final { scan-assembler {.section[ \t]+.foo} } } > -- > 2.43.0.76.g1a87c842ec > Marek