From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) by sourceware.org (Postfix) with ESMTPS id D0E3F3858C5E for ; Fri, 29 Dec 2023 21:17:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D0E3F3858C5E Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=ucw.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kam.mff.cuni.cz ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D0E3F3858C5E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.113.20.16 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703884665; cv=none; b=qasgEyr40fHC5nmb9J8uiwWrhJVOEzQOGXW6d4zgwZDdVXCov/7Wr6sy/rbzhkaj0rHvZp2KOeatCAzds3AeceYGYydzMbWkXWl/B3ZImIbXADsEfgIbiO/aIayYW5vL+ALc+EpTtRGDY7M5RO2UDDoGOhykW6KNMqVF2FEHcC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703884665; c=relaxed/simple; bh=ZwCnrDC1QNA8YeEHbwhaFytDj2/hmCfE/zQ3GtZS6Fw=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=yB5xXoQVpIDt78xT7iZ1yImGIo2skio2sJHw+YqmNwsHIuaZ10VY8XFnFUvPWrUgfxcjEPkI7yuLOc2WoHhjtnvuoYBLRG7+GbjDl1xeELCZVtdkljCBCsGEmcijEbGJTMEzxfQxwckNnf5/NZYtQ584nn8vm7odbOtJeOo5ZGk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id EE84B28C597; Fri, 29 Dec 2023 22:17:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1703884662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VegcwbixThuw5whgNWcCdMcCSWFqhSF2ZtrL1LqmYCs=; b=Ig5qi9SV1XqAqiywY/pNyW21T+quDYqv8phu+lfHHPgI7Kstp4AH3fI2Hl/uonfceSh3Ri bSto81Xz/lYkaqBg1hnmqy4gR2p53FLqaS7/2ZQtykBEu9jNVIMJlCJ3DG6GK26uC9bBfN 2fFsIdUdYLkPc311iiHVHOfwOA9u8+I= Date: Fri, 29 Dec 2023 22:17:42 +0100 From: Jan Hubicka To: Michal Jires Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 2/7] lto: Remove random_seed from section name. Message-ID: References: <18cc1c3980551ac1881eea6e78811a629c7baa82.1700222403.git.mjires@suse.cz> <1ab98391f1f12962c48d1dd4d7309fc219454c96.1700222403.git.mjires@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ab98391f1f12962c48d1dd4d7309fc219454c96.1700222403.git.mjires@suse.cz> X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Bootstrapped/regtested on x86_64-pc-linux-gnu > > gcc/ChangeLog: > > * lto-streamer.cc (lto_get_section_name): Remove random_seed in WPA. This is also OK. (since it lacks explanation - the random suffixes are added for ld -r to work. This never happens between WPA and ltrans, so they only consume extra space and confuse the ltrans cache). > --- > gcc/lto-streamer.cc | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/gcc/lto-streamer.cc b/gcc/lto-streamer.cc > index 4968fd13413..53275e32618 100644 > --- a/gcc/lto-streamer.cc > +++ b/gcc/lto-streamer.cc > @@ -132,11 +132,17 @@ lto_get_section_name (int section_type, const char *name, > doesn't confuse the reader with merged sections. > > For options don't add a ID, the option reader cannot deal with them > - and merging should be ok here. */ > + and merging should be ok here. > + > + WPA output is sent to LTRANS directly inside of lto-wrapper, so name > + uniqueness for external tools is not needed. > + Randomness would inhibit incremental LTO. */ > if (section_type == LTO_section_opts) > strcpy (post, ""); > else if (f != NULL) > sprintf (post, "." HOST_WIDE_INT_PRINT_HEX_PURE, f->id); > + else if (flag_wpa) > + strcpy (post, ".0"); Con't post be just empty string? > else > sprintf (post, "." HOST_WIDE_INT_PRINT_HEX_PURE, get_random_seed (false)); > char *res = concat (section_name_prefix, sep, add, post, NULL); > -- > 2.42.1 >