From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2049.outbound.protection.outlook.com [40.107.104.49]) by sourceware.org (Postfix) with ESMTPS id 771D13857C4B for ; Thu, 11 Jan 2024 14:43:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 771D13857C4B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 771D13857C4B Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.49 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1704984230; cv=pass; b=O0F0Dzeu3SchiKHeh8sR+IkKH0sYw64vaOIExdn9dHbQlM0GSzowemHTp5D0UKXehoKoceYXp8jAdwvSnc89sVysvbY1HDtvoUHx5ITjy5JBdp+qEnXI2WcG/srbfFWE91YaXHZbs7fIdVRylHtbh4fBwlmC2fluq3cDPVDoCrM= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1704984230; c=relaxed/simple; bh=zn57L1WzzfcHGbIHzlxtg7uyumGqpHxDUldpB+9nWwk=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=dptSDG9iug7KBqQB3sMkxFz1+LUXuWEZoP7iIaU50n9HNdiHlgw0Euaegt3hm7FPDvpHymiwwSmYr/996EiH2EIHGZYErG3bDlBM1P9reRlNAt65RMLG1lEBqd1MFAO9Orx1VrcnHOwiqiwK3Bvsa4ksSb7d53fNrwqhwmSlp7I= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EAct45VPjo0fbNoN6G48RvLqmJ++AXMYeR8HqRjqGW02kVxmXP8ff42QHUDvZCR3gmKdrnBFYxlaC0CyFzT4mSGRoNKoHK0W8xEZEibJjFeFYEH58XQzX7RklbSWM4EfhKWJSrvfKwt1FRSeSPZpaKB8p0nJPuG1hd3nDqiQk6k45JQYEeluR/7xXUponHQzbRJgnQftndXNeJ7p0p/hDbK5+cTZ2EnG5kJnk5u9v5iv7ouwu5NQQxfcHbxW4XtpGEkcoc1nWvfNdJ9YxvzVizU4jgTIqS0yBzpbYdRrQCvWUCaSnA13nuTgD9K+3rtUuHWO6lFnq7Y0mAZ5LqStuw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BAZJdud7vXBcXdknQJqeNPHU08K4Uy6qHaW+7UZZOso=; b=Urg/42tsP7anNCyx8I82acq8CEqHr+m5SOUfZ0goNhq5JswtMG6lLKnCkfegSsM9pQq5H8KilL5B5SFslSW803Lk7nUpmwWdNHNNXk6s3TrQNBYEqnyNuaNNQQVdmPbQG4DnfurF50SXJ3BSvYYsvjUdSJ5PAhwf/SOMG9rrRUhtoZRhivGm1477J2Z6I0aN0IoD0gE2w9YPoDoogp89M1UWlDZuVKYqb+CZKKrlhPOmMyzKKb8/fa1F50rhaAG3iwoezq4YHzS4FB1iRsWhIfBZIWZej44aHZxjA0inVFix7iT6kYQXOD4oAEwPD/95hrErvYiSRvf/RfIQ+nQ2qA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BAZJdud7vXBcXdknQJqeNPHU08K4Uy6qHaW+7UZZOso=; b=7G1rGN19MlEIrS8FN2Y8RyeUYaEFdTj2wdyhnFEShu1TY/cD0cJIwmmhgxiL/ubHBYKqroHEQyfLCPI2yDWcvx/lkopEsQ4H/KH59YviHr/r64xozFnB20+LFfjYJsTAY/dWvl279JoMI1gS/X8gT13kPOwxjlKXGQYgpcCknfM= Received: from AS9PR06CA0612.eurprd06.prod.outlook.com (2603:10a6:20b:46e::19) by AM7PR08MB5349.eurprd08.prod.outlook.com (2603:10a6:20b:107::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.19; Thu, 11 Jan 2024 14:43:45 +0000 Received: from AM3PEPF00009BA1.eurprd04.prod.outlook.com (2603:10a6:20b:46e:cafe::a0) by AS9PR06CA0612.outlook.office365.com (2603:10a6:20b:46e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.19 via Frontend Transport; Thu, 11 Jan 2024 14:43:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM3PEPF00009BA1.mail.protection.outlook.com (10.167.16.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.14 via Frontend Transport; Thu, 11 Jan 2024 14:43:45 +0000 Received: ("Tessian outbound 1076c872ecc6:v228"); Thu, 11 Jan 2024 14:43:45 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 594fd362b6ef9b08 X-CR-MTA-TID: 64aa7808 Received: from 27e914d606f3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A6208DA2-5A4D-44E0-BE43-B79F6A48CD5E.1; Thu, 11 Jan 2024 14:43:39 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 27e914d606f3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 11 Jan 2024 14:43:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j6a/Bj4h36d7rz7156PM5d0CgwCeIHskDrEwyIcWjaWdShXLJQprASFoWPwQF0kHsVDiEh4j1WBGyr+5rkYhKdiu3jy4Nk09wJpR40/igbH4YNiUfB6OZ3v9DZHp7oQUpMo6oZ4/XckaxWs6CuN15AlIX0L7DvvXFPGCNEC1DowkhWsa9rQNT3I1c7ZysPR+9AJKjR7hG1PY5/QwQOS1R8uor6zzqTADuh2rNJaPMlkWfMSsWJJGmiRNFBbdHQpJcSzd3DoJKB21k/ccW2LU9AF3dmA7jPNWun9ohKNC+aSmHPvii8/PTIVS4x+V5WVeWQkkHr26LzbqD/CBtXujhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BAZJdud7vXBcXdknQJqeNPHU08K4Uy6qHaW+7UZZOso=; b=ixnU7vWN9W6pfsuF+iGz6cG3N/rIGf04s0XRCUkzHDwRqHYMZsXNXL8eTdwZstdio93pAITL9gvXuXOhDLA045lV6WMF/Ug5gjcIWADU9icAqvqF5JUlx7S0uIh6IJl+genZzLVE0uf5o06CqAldrvvRUcI0C/BsX21klkQoCu/r9QwG71PEgtteSH3XuwYPe7jed+nmXkZQTE+ZQI6BIIEgUk5KGMrLPBAVBTNl1QUDin2Yn7zggHz2sH5/i8ftucTQ7m168bgOud2E+j1+tIpDD8Xaos0IZajAxwguHqu3o8WSpgNXJ5jl3xZh+q+pqfB+E6HjTN3h1/0rSYxh7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BAZJdud7vXBcXdknQJqeNPHU08K4Uy6qHaW+7UZZOso=; b=7G1rGN19MlEIrS8FN2Y8RyeUYaEFdTj2wdyhnFEShu1TY/cD0cJIwmmhgxiL/ubHBYKqroHEQyfLCPI2yDWcvx/lkopEsQ4H/KH59YviHr/r64xozFnB20+LFfjYJsTAY/dWvl279JoMI1gS/X8gT13kPOwxjlKXGQYgpcCknfM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by PAWPR08MB9541.eurprd08.prod.outlook.com (2603:10a6:102:2eb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.17; Thu, 11 Jan 2024 14:43:37 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::bc19:813c:34d3:758]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::bc19:813c:34d3:758%7]) with mapi id 15.20.7159.020; Thu, 11 Jan 2024 14:43:35 +0000 Date: Thu, 11 Jan 2024 14:43:20 +0000 From: Szabolcs Nagy To: Richard Earnshaw , gcc-patches@gcc.gnu.org Subject: Re: [PATCH v2 7/7] aarch64,arm: Move branch-protection data to targets Message-ID: References: <69a6baa924519053eef92766189d23da1f7afa7c.1699025215.git.szabolcs.nagy@arm.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P123CA0096.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::11) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|PAWPR08MB9541:EE_|AM3PEPF00009BA1:EE_|AM7PR08MB5349:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d4a543d-93d5-4650-ff60-08dc12b3b6c0 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ceoLYhU5WtIU2+bifznOzJpbTMtdNODeLmit3CRnPtDmOa/iyvB/418EbK+GEVgxtjW5nhbOL3oqfQhW3n01t/Hb4sFyI/+njjOpagNf6cse7EgmrAxddkvjWOVvcc/0fr2OhZFaLS9q/RfJzHZj6i6juOuNE2f/QWt0J1q5gAUXkgxA9DlS0bUJn9ZdbHhBqxzKPWJ6fmzyaVy52osCW5EcvWrhtXQxIY6BWm6q6p4WSXKKXYs3XqZbz0Q0IrxFID+rYE4C1qr4LIBaXJCe3Z3Zjg3A8mKmDn1kzfRPlkugTRYoR+biLejIBc0gBFFeTkp3uT3AA+MKskAqWUJ1Z79PUaYXSDcXqj1OvtW0B8o1iCyu+VpcGviT/GpdWADcsfAAWAjhz6oMa4nViIk6kEEplDk/H5Nbuc3yD3sAxMnJgnU375JruqSxYISYnrLe00t4MN/ixc6hJXTnKIpnG6hAbseww4Kxh/G0QW2y1xDlh2dTv3qvoMZXp6UdpMuB0O/fJ4zr8Netu9szCfH4fTFrVNh+IqB+oBjCaz+T/dExlcPGRmz8YKOkKhDtYlxt X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(39860400002)(136003)(396003)(346002)(366004)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(6486002)(5660300002)(66476007)(66556008)(66946007)(44832011)(8676002)(8936002)(316002)(26005)(86362001)(2616005)(6506007)(6512007)(41300700001)(53546011)(6666004)(38100700002)(2906002)(478600001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9541 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM3PEPF00009BA1.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6bc6d46f-120b-480c-79d4-08dc12b3b0a8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QDLSC0/nJeHahdXB8gxlhviLd1ozoDC9dMQuwuSVbtEyhoq/8iUxCAjnj+hX+15evqFcALUwM4s0p/w/xhYDJvjEFVmPdURPG4/4YrpG7cVXwknrHey2HVWwHWbRT0Bu5VFQ7qVrlWaxdMqz1QiyeyVnmRLjbllNYZ/kpkR7J6ZakAZWJP5qnph/U7Hd5IyKISn9tdgTUGTud5iOhRKClnXSlCxZuq/gGfVqCQStcVDuYTeuSr7WDSshvgy+7nwVyvwquR8JUGufQJdKuachuO+3yUufONIIAg+GXDGrIK9HAU9TyfrwKM+vhCkeYwfptisDHjCNMO987/nACagMnObelIwJ9tgiW3gRuS7I4eG1gWJ4GRG9zTU9IM0ZZfa2x9riDgmmRxbZoonQ51OPWsnCtl+inb55PbHn8tqBGVGImFOLGfugdYmVXkvnB7Lmw5Q9NPkaOZtfF9QEj9fvyTY0AtBiDFzHvfthwRiXOVV//OuiuMWjJG3qXTN+bdDFzkRnqEKEX0HMTp8cPLVADPLHAxWofvcgyroQltEweqJYLyqE0j4OGhpjOZaBdtW1CIb3Sffz2P2yDnGpXADL5hDkTO7YCVmk/wMTyIZ/dK41xos9h+4D6zMRLOzbWJi43PInH229laz2GU/2RGh/NNDm7jUbYVLxmQqMrmtwZnLf30/9FqjN/j0HFDGwbCgi/UtjXq0zgw2rYJy/xLAYMA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(136003)(39850400004)(376002)(346002)(396003)(230922051799003)(1800799012)(82310400011)(64100799003)(451199024)(186009)(36840700001)(46966006)(40480700001)(356005)(36756003)(5660300002)(82740400003)(336012)(26005)(2616005)(81166007)(44832011)(8936002)(8676002)(41300700001)(2906002)(478600001)(86362001)(36860700001)(6506007)(6486002)(6512007)(316002)(70586007)(47076005)(70206006)(6666004)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2024 14:43:45.3846 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d4a543d-93d5-4650-ff60-08dc12b3b6c0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF00009BA1.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5349 X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 12/07/2023 13:13, Richard Earnshaw wrote: > On 03/11/2023 15:36, Szabolcs Nagy wrote: > > * config/aarch64/aarch64.cc (aarch_handle_no_branch_protection): Copy. > > (aarch_handle_standard_branch_protection): Copy. > > (aarch_handle_pac_ret_protection): Copy. > > (aarch_handle_pac_ret_leaf): Copy. > > (aarch_handle_pac_ret_b_key): Copy. > > (aarch_handle_bti_protection): Copy. > > I think all of the above functions that have been moved back from > aarch-common should be renamed back to aarch64_..., unless they are directly > referenced statically by code in aarch-common.c. done. > > +const struct aarch_branch_protect_type aarch_branch_protect_types[] = { > > can this be made static now? And maybe pass the structure as a parameter if > that's not done already. done in v4. > It would be nice if, when we raise an error, we could print out the list of > valid options (and modifiers), much like we do on Arm for -march/-mcpu. > > eg. > $ gcc -mcpu=crotex-a8 > cc1: error: unrecognised -mcpu target: crotex-a8 > cc1: note: valid arguments are: arm8 arm810 strongarm strongarm110 fa526 > [...rest of list]; did you mean ‘cortex-a8’? i implemented this with candidates_list_and_hint but it does not work very well if the typo is in a subtype, so i think this should be done in a separate patch if at all.