From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B08173860002 for ; Thu, 11 Jan 2024 12:39:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B08173860002 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B08173860002 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704976742; cv=none; b=bUiseWwvymI1Yg493CKOqvp6oWZUvrBZkM1wBi0qZwh/7bErcfT/T/g3v7cAhYl6Ar+NJeWKr2Vw2xDoSgRAVV5kEF1MsW6RNsU/bfdzt3maaBLSh8hlCmlVcsDQzSv97MK/bgLlwspdFQ+NBoGh5os8f+yCvJMURotSr+e4J0Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704976742; c=relaxed/simple; bh=KTX47Ri9b4ixtg8oKwrhs7iGSR8Gqa6tf/PNHkAcObA=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=lmtF8NUzdeBU+w/ad0fwua15Io09gMSGSzvMrPDhioHvui+PbmjMLX5xTz25lxX6y22a1ERNdBcAD77rfEGGhjUEyayCz+74nMTlQGzkCfgYubC4bxZeKBTEWe7l+Yi+hrlktWQ/R56XHhWs0z7uG0KEixOYfC+PDsMx+xU3FN0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704976740; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=HeI85IHs1Y3nthPyCKuaAj56v8bHJrlzFF3jU5gkRks=; b=DDpebxL4EnS+Mdcb7CWaIDAhYJLY7e5lX8mh/sTAMALBFbZKtQ9+JqFK6RhgBaNf8HZeSy tfNbZbufiImHP5oTqswN6CM9YEo5RMK9kvhhagHnrKmMuvHJz4ODMg516zIj05ndN6MWyf T0R4K+zdIYa2s3+bsLUEAwyZL8Tpq10= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-lzFjwntCP4emYpwINYugYg-1; Thu, 11 Jan 2024 07:38:56 -0500 X-MC-Unique: lzFjwntCP4emYpwINYugYg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EA85F863E81; Thu, 11 Jan 2024 12:38:55 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.92]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5418D3C25; Thu, 11 Jan 2024 12:38:55 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 40BCcpcq454173 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 11 Jan 2024 13:38:52 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 40BCcnIr454172; Thu, 11 Jan 2024 13:38:49 +0100 Date: Thu, 11 Jan 2024 13:38:49 +0100 From: Jakub Jelinek To: Lipeng Zhu Cc: tobias@codesourcery.com, Richard.Earnshaw@arm.com, fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org, hongjiu.lu@intel.com, pan.deng@intel.com, rep.dot.nop@gmail.com, thomas@codesourcery.com, tianyou.li@intel.com, tkoenig@netcologne.de, wangyang.guo@intel.com Subject: Re: [PATCH v2] libgfortran: Bugfix if not define HAVE_ATOMIC_FETCH_ADD Message-ID: Reply-To: Jakub Jelinek References: <20240105014325.1490280-1-lipeng.zhu@intel.com> MIME-Version: 1.0 In-Reply-To: <20240105014325.1490280-1-lipeng.zhu@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jan 04, 2024 at 08:43:26PM -0500, Lipeng Zhu wrote: > This patch try to fix the bug when HAVE_ATOMIC_FETCH_ADD is > not defined in dec_waiting_unlocked function. As io.h does > not include async.h, the WRLOCK and RWUNLOCK macros are > undefined. > > libgfortran/ChangeLog: > > * io/io.h (dec_waiting_unlocked): Use > __gthread_rwlock_wrlock/__gthread_rwlock_unlock or > __gthread_mutex_lock/__gthread_mutex_unlock functions > to replace WRLOCK and RWUNLOCK macros. > > Signed-off-by: Lipeng Zhu LGTM. Jakub