Re: [PATCH] ipa-cp: Fix check for exceeding param_ipa_cp_value_list_size (PR 113490)

[Jan Hubicka <hubicka@ucw.cz>]

> Hi,
> 
> When the check for exceeding param_ipa_cp_value_list_size limit was
> modified to be ignored for generating values from self-recursive
> calls, it should have been changed from equal to, to equals toor is
> greater than.  This omission manifests itself as PR 113490.
> 
> When I examined the condition I also noticed that the parameter should
> come from the callee rather than the caller, since the value list is
> associated with the former and not the latter.  In practice the limit
> is of course very likely to be the same, but I fixed this aspect of
> the condition too.  I briefly audited all other uses of opt_for_fn in
> ipa-cp.cc and all the others looked OK.
> 
> Bootstrapped and tested on x86_64-linux.  OK for master?
> 
> Thanks,
> 
> Martin
> 
> 
> gcc/ChangeLog:
> 
> 2024-01-19  Martin Jambor  <mjambor@suse.cz>
> 
> 	PR ipa/113490
> 	* ipa-cp.cc (ipcp_lattice<valtype>::add_value): Bail out if value
> 	count is equal or greater than the limit.  Use the limit from the
> 	callee.
> 
> gcc/testsuite/ChangeLog:
> 
> 2024-01-19  Martin Jambor  <mjambor@suse.cz>
> 
> 	PR ipa/113490
> 	* gcc.dg/ipa/pr113490.c: New test.
OK,
thanks!
Honza