From: Jakub Jelinek <jakub@redhat.com>
To: Andrew Pinski <quic_apinski@quicinc.com>
Cc: gcc-patches@gcc.gnu.org, alex.coplan@arm.com
Subject: Re: [PATCH] aarch64: Fix aarch64_ldp_reg_operand predicate not to allow all subreg [PR113221]
Date: Wed, 17 Jan 2024 10:11:51 +0100 [thread overview]
Message-ID: <ZaeZ1x7pFDHxgxCz@tucnak> (raw)
In-Reply-To: <20240117032904.80831-1-quic_apinski@quicinc.com>
On Tue, Jan 16, 2024 at 07:29:04PM -0800, Andrew Pinski wrote:
> So the problem here is that aarch64_ldp_reg_operand will all subreg even subreg of lo_sum.
> When LRA tries to fix that up, all things break. So the fix is to change the check to only
> allow reg and subreg of regs.
>
> Note the tendancy here is to use register_operand but that checks the mode of the register
> but we need to allow a mismatch modes for this predicate for now.
>
> Built and tested for aarch64-linux-gnu with no regressions
> (Also tested with the LD/ST pair pass back on).
>
> PR target/113221
>
> gcc/ChangeLog:
>
> * config/aarch64/predicates.md (aarch64_ldp_reg_operand): For subreg,
> only allow REG operands isntead of allowing all.
s/isntead/instead/
Otherwise I defer to AArch64 maintainers.
Jakub
next prev parent reply other threads:[~2024-01-17 9:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 3:29 Andrew Pinski
2024-01-17 8:59 ` Alex Coplan
2024-01-17 18:54 ` Andrew Pinski (QUIC)
2024-01-17 9:11 ` Jakub Jelinek [this message]
2024-01-17 10:18 ` Kyrylo Tkachov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaeZ1x7pFDHxgxCz@tucnak \
--to=jakub@redhat.com \
--cc=alex.coplan@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=quic_apinski@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).