From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C58633858D20 for ; Wed, 17 Jan 2024 09:21:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C58633858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C58633858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705483295; cv=none; b=E1b0wvx09hnWRWBbSKo+VrJOb33xDXUKwQxxx+aq0Jv6rDnsDXhl8PO91l6FgKop7Xv8mC1ePd/57//OYZpgqeQLXJFuOO49UAGjVs18fnEWSBpLr5f+R/rZQi9reYasL/8zB8UGbT3WHfFHI5CLO+FzAFEALzzZf+yuyJLyZEI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705483295; c=relaxed/simple; bh=gR45nlrvNCxz3bvYJEKCptCCLc+a7gxZQfrxVN5tE+4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=lBVK78Luc5LYWOV+6KwiZOwZHkAzjXxCnNEfHDnWCidaij7+xmUwI7BCZE3cK9t+UfpNVHe/fG+LrBBVLV6zONK0p+1jAHelx7+BeqTKJXc2u6XH99SOwVWWEap9meneGXDHNizYUT5D33/HGWngXl9QRlcGDyMAIQAMmUuWBf8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705483293; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=FD4+TPQlgUVQS4C2HehvABj98DmIdgqySNnzoFpH2HI=; b=U1uCCxhTtbEwJ7D4S+bCEaocQ9yVv5IO/7bTNgVqu3ArmjpZBaId+cL9ftY9QvZ+q0dMQC af1m619oQcPOWI1FAXRdEMtO5vmoAkXATIXVKkc818z4z+JWhfYjLnlygcCv5L2Kp1FZV2 Y+uGyDRneY9CK6U1O6IfZ1DXWCQ3KTg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-349-XOIjxADUP-izfx1bmMH9sg-1; Wed, 17 Jan 2024 04:21:31 -0500 X-MC-Unique: XOIjxADUP-izfx1bmMH9sg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 89702811E86; Wed, 17 Jan 2024 09:21:31 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3708140C6EB9; Wed, 17 Jan 2024 09:21:31 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 40H9LSxt2305859 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 17 Jan 2024 10:21:29 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 40H9LS352305858; Wed, 17 Jan 2024 10:21:28 +0100 Date: Wed, 17 Jan 2024 10:21:28 +0100 From: Jakub Jelinek To: Iain Sandoe Cc: GCC Patches Subject: Re: [PATCH v2] Fix __builtin_nested_func_ptr_{created,deleted} symbol versions [PR113402] Message-ID: Reply-To: Jakub Jelinek References: <20240117085531.21315-1-iain@sandoe.co.uk> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jan 17, 2024 at 09:04:08AM +0000, Iain Sandoe wrote: > > On 17 Jan 2024, at 08:55, Iain Sandoe wrote: > > > > Tested on x86_64, aarch64 Darwin21 (which default to heap-based trampolines) > > and on x86_64 Darwin19 and Linux (which default to executable stack > > trampolines). > > OK for trunk? > > Hmm.. maybe this is not right and the builtins should still be named __builtin (with > the fallback function only renamed) or alternatively, add these as libfuncs only? > > > Iain > > > > --- 8< --- > > > > The symbols for the functions supporting heap-based trampolines were > > exported at an incorrect symbol version, the following patch fixes that. > > > > As requested in the PR, this also renames __builtin_nested_func_ptr* to > > __gcc_nested_func_ptr*. > > > > PR libgcc/113402 > > > > gcc/ChangeLog: > > > > * builtins.def > > (BUILT_IN_NESTED_PTR_CREATED): Rename __builtin_nested_func_ptr_created > > to __gcc_nested_func_ptr_created. > > (BUILT_IN_NESTED_PTR_DELETED): Rename __builtin_nested_func_ptr_deleted > > to __gcc_nested_func_ptr_deleted. The normal way would be call the builtins in the compiler __builtin___gcc_nested_func_ptr_* and expand them to the __gcc_nested_func_ptr_* calls. See e.g. __builtin___clear_cache. Jakub