From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) by sourceware.org (Postfix) with ESMTPS id 698593858C53 for ; Wed, 17 Jan 2024 14:00:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 698593858C53 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=ucw.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kam.mff.cuni.cz ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 698593858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.113.20.16 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705500050; cv=none; b=ZEihOQJm+sZ/tUpb1fR56CT6AcLsd0GDkBUdbJD8uEsb7UgQ+kM5bUWW+qGRKoJkx+qKuXVNPPu7hJr5GLzT+IMBL4jrCfNhrv5HBW9HOSIysBiBtVXfMK8wo0+EqwGsk8/vnILlxymLyJ0KKUDad/EYxDk6PodCzvQVtOoWNgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705500050; c=relaxed/simple; bh=HdCwTX7a9cwmunLCaNW1AKny1n0BEtGioOLFP2NlDrQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=pvJIGi+gyQGku/i3a8ki/tcKqVRT3O1ZWbzEOwR20Il0Bw64EOjXx9ukJfzBjl6dZV9pYZT90TloXH0ngCcYDsQOWNyQbhlOB/RdICWmN1XeS3fr7LiizXZtIBWVA4K9SEDdPVQX7pFjdnWUcRjzKRRcJ+zy1QDg2lUkOClaUmU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id EEA07283B5A; Wed, 17 Jan 2024 15:00:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1705500042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PyzYIqt2sfT2tAEx9hkYMcgukXXUVAuxlOsbc8v+ZuQ=; b=D8qk3BNEONRm90/DZeP6m0xGBtJvBIxePgyw1C20lLuitiax9uQg0u7Zjo5JK8EijiWD4n m1yihDuZMd2asE5NgnO+0UlbLmOJwxs1VHgAOD/0JqpypH2y9yL4s8LjWahg7wdUTWHpBl 8mjBJrRV/MoDi++bTK09S18aRBdsVh4= Date: Wed, 17 Jan 2024 15:00:42 +0100 From: Jan Hubicka To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: Add -falign-all-functions Message-ID: References: <93nnq110-3974-p060-sp9p-q2pn0641687p@fhfr.qr> <72ssp99q-2447-6685-8307-n06499051o12@fhfr.qr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <72ssp99q-2447-6685-8307-n06499051o12@fhfr.qr> X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > > I meant the new option might be named -fmin-function-alignment= > rather than -falign-all-functions because of how it should > override all other options. I was also pondering about both names. -falign-all-functions has the advantage that it is similar to all the other alignment flags that are all called -falign-XXX but both options are finte for me. > > Otherwise is there an updated patch to look at? I will prepare one. So shall I drop the max-skip support for alignment and rename the flag? Honza > > Richard. > > > > -flimit-function-alignment should not have an effect on it > > > and even very small functions should be aligned. > > > > I write that it is not affected by limit-function-alignment > > @opindex falign-all-functions=@var{n} > > @item -falign-all-functions > > Specify minimal alignment for function entry. Unlike @option{-falign-functions} > > this alignment is applied also to all functions (even those considered cold). > > The alignment is also not affected by @option{-flimit-function-alignment} > > > > Because indeed that would break the atomicity of updates. > > > > > Honza > > > > > > Richard. > > > > > > > + } > > > > + > > > > /* Handle a user-specified function alignment. > > > > Note that we still need to align to DECL_ALIGN, as above, > > > > because ASM_OUTPUT_MAX_SKIP_ALIGN might not do any alignment at all. */ > > > > > > > > > > -- > > > Richard Biener > > > SUSE Software Solutions Germany GmbH, > > > Frankenstrasse 146, 90461 Nuernberg, Germany; > > > GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg) > > > > -- > Richard Biener > SUSE Software Solutions Germany GmbH, > Frankenstrasse 146, 90461 Nuernberg, Germany; > GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)