From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2068.outbound.protection.outlook.com [40.107.22.68]) by sourceware.org (Postfix) with ESMTPS id AFA893858D33 for ; Wed, 17 Jan 2024 14:49:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFA893858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AFA893858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.68 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1705502971; cv=pass; b=N/IbOe9y1M1w2lLd4Y5gTlaVZ9tnQkxon70trTFeR37eMfKhflKKApFQyemZp+dtTy+zN3L4bzc2lczGYzsIiZsDsgydMxaY69LfGgl74iEJrHnZStG10w+UXhl49e7EQh+bZpsiykzEL4EgEoIBf82qS1Kv7t8D6Adt8P9DIIc= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1705502971; c=relaxed/simple; bh=RcNwZOGT/DKzxJHL1BkEpAHdawoPRSNmkGpy0jjOSeg=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=X6yOkJqtJ/NyR4EfP9QHiVIqADze9osfRA96N6/urMTCYm6IthbLdVE9l3o9GR2JGetmdd7vjICSAPdH94NmKNynj2+m6vJKwL+BhHg1IVerYrQau1OKUbc/rqF+vDjKPCAHjM7DLmhiskEYOlbhzC3tCTY0m+hg2modg3zpdLU= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RYWneuJU3BQcKA7UZrRMvLEX9BEWAPT2aILNoE0nhEk6OEQgr3KyNVTRy/XWB7V35w/5CanyY1WgGw8IoP9rEoet6d4UVaPkwoDqBMu5dzWr+FLxH6K/54dhg3Zdda5jPS4OF/6yPDwrZbMEqxtnGkdKqIMglsupA1jL/ptsSF/QA6s0j7Eyka2bzJr+q0OJTMC0q49HC0BvZsPKVcmVK5Nn5aJeSSuZ0+Mk59UnZL3C/fwV+pej7IX2kuldU4YwDjJkBNoBBk0WDt590oIijCInHeTIxg8P5KadLUqkKtg+0KES1cYeX949QRVHBOY9YP56HKvpJeyuL273vAB5Uw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LgKa1lnp8mnIlnoXgiG+7PsGMkuxlempvXzAtsgf7vk=; b=YnJ3iWs7Gw5ukkTL99cpgGf2fv/urpMotma/bnIRl224lDWE2QaQ0rbfAUvv5RNworINk1Ny9tXyicVxOqt+AfcOmHN8+gNLp9cZXqCFFfIo5oa1R38ceYKYWkXNdXXwaAukdITvwflrshbNb1COu7JHlv7MIGcKH2vIsSq+eqh/g9DUJSGxp2MDNURPzRMEz1U0IPEVWt9WgzpcftN9q6d3gJ+mdMy7EiR2eegFLKGF/mezjwIIf6AmF4M24yTi4nFEKRg4DEIoO1TrscgObiOpzWuWKP/ZbtHdEMtlDMHDtzejmIQRgy38kIX0zBp/oXUXsNU77MZF2DNzl9kKFA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LgKa1lnp8mnIlnoXgiG+7PsGMkuxlempvXzAtsgf7vk=; b=jjBAzoxrxUxbd2X00C5Jl7vZHBNFxub65bdMEzIsvHLvWH6Znx5VtF7ebkbWHhBRWpo9BktiHtXLrnPM2oTwGdw0rseG61Ey8xWyAJQShWBtL9K/6ux63kaB6+7MNnSLphdeZKqWJYyFraId34Bxhr2qWnrXCAMSH9Ao5pOCINk= Received: from AS9PR06CA0441.eurprd06.prod.outlook.com (2603:10a6:20b:49e::24) by DU0PR08MB9321.eurprd08.prod.outlook.com (2603:10a6:10:41c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.23; Wed, 17 Jan 2024 14:49:15 +0000 Received: from AM3PEPF0000A797.eurprd04.prod.outlook.com (2603:10a6:20b:49e:cafe::4) by AS9PR06CA0441.outlook.office365.com (2603:10a6:20b:49e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.29 via Frontend Transport; Wed, 17 Jan 2024 14:49:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM3PEPF0000A797.mail.protection.outlook.com (10.167.16.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.16 via Frontend Transport; Wed, 17 Jan 2024 14:49:14 +0000 Received: ("Tessian outbound 31df1b57f90c:v228"); Wed, 17 Jan 2024 14:49:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 269a1993cf5b7bdd X-CR-MTA-TID: 64aa7808 Received: from 69f14e712d7f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 83264A59-F70C-49E9-AB9A-3F68718F6A1E.1; Wed, 17 Jan 2024 14:49:05 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 69f14e712d7f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 17 Jan 2024 14:49:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FqIYD3MZ669MOsF8ZAKGt0nlnnO2Rb+BcLtSIQIwgKbrtRHJvZ6h0yRq9SD/vskSWU6dgdB969egciRLomJ6vVOKRxgJI/ratb2wbBo2pyMdUHcEXAF1rBVEmMjafaf7oGWfsBRw5CADfMaaWwsG3/VeiG8h32v2ef2ctI/94NPy0ar/bp+09ZfdvfxLLDtQqRpkZVxTGDYjaQOgUix+rm99HZHCxyseh0AV8SqbECdoFVKFKL2xiOk0c8aG/2lGyqWIXA9h1fDpokk+P/tB9KvVnFGbHJq3MN0yff4SWjJs4sPMxUQlvMAJ6ztvbPOEXCUKz7i8uC/f7nvVWpF5iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LgKa1lnp8mnIlnoXgiG+7PsGMkuxlempvXzAtsgf7vk=; b=YY0oThTEy168U2ehBNzcgPbm5QWZywc94twGuuybcb13gnK0ujNgj5GjdxY/Y/+xLdz4bj8wnaRj0gbijc3IykDQSpoUl9wxvhZDRxMa72ICo14Px8i1AGW58dpN/O8gOcHrnopz8Nb6oFW/ZJdYDjj0/QkLXSS1aODEgaQ/VDE6y9Xum9IjNsPw9ShjO3Ve2PxLVTftN9n2DzHWjGQXuKBbjsBNhGhJR7VVkZM3fLjmvXZFRimptgsf/Da3ZmK31jEDMYHVy9UXSCkjrZT75wtL68NLzfgX2GegRdi8kse9ziALlw88d0sD5t3LB9qosrbCJowCRzQ0r6BVUk9sPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LgKa1lnp8mnIlnoXgiG+7PsGMkuxlempvXzAtsgf7vk=; b=jjBAzoxrxUxbd2X00C5Jl7vZHBNFxub65bdMEzIsvHLvWH6Znx5VtF7ebkbWHhBRWpo9BktiHtXLrnPM2oTwGdw0rseG61Ey8xWyAJQShWBtL9K/6ux63kaB6+7MNnSLphdeZKqWJYyFraId34Bxhr2qWnrXCAMSH9Ao5pOCINk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PAWPR08MB8958.eurprd08.prod.outlook.com (2603:10a6:102:33e::15) by PR3PR08MB5738.eurprd08.prod.outlook.com (2603:10a6:102:81::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.23; Wed, 17 Jan 2024 14:49:04 +0000 Received: from PAWPR08MB8958.eurprd08.prod.outlook.com ([fe80::48ca:fbcb:84bf:ed17]) by PAWPR08MB8958.eurprd08.prod.outlook.com ([fe80::48ca:fbcb:84bf:ed17%4]) with mapi id 15.20.7181.027; Wed, 17 Jan 2024 14:49:04 +0000 Date: Wed, 17 Jan 2024 14:49:00 +0000 From: Alex Coplan To: Jeff Law Cc: gcc-patches@gcc.gnu.org, Richard Sandiford , Kyrylo Tkachov , Richard Earnshaw Subject: Re: [PATCH 1/4] rtl-ssa: Run finalize_new_accesses forwards [PR113070] Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P265CA0172.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::15) To PAWPR08MB8958.eurprd08.prod.outlook.com (2603:10a6:102:33e::15) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAWPR08MB8958:EE_|PR3PR08MB5738:EE_|AM3PEPF0000A797:EE_|DU0PR08MB9321:EE_ X-MS-Office365-Filtering-Correlation-Id: f41d1d75-e4ca-46c8-32c8-08dc176b79a0 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: O47orUJAZnjyB14SpeJ5klmuUEK3KV8rlSD1D3uMkW3/KsngCpb11rLLta8zdHgJhLJ9l+gg2cVxMKnsVpz6Ve6F6VdlmHV2xvV0OenmFTK2r6Uw+kgQasqmGwMf0QH15Gq2BMWDecje3jvz22DoSoZaH5XFabjw/58LHJEcMgKIdKrmCCG67xqizjWQAB2ynOnsDNmhrNbkqnipFuvP7BZjAoEw9wwE2lYiTsS40tbTC1vGEaKr2ZnHVZ1U9s1KVsxUyxB6EgHUlFwnePmWjUk2Hrb9ecyLt+STXjjpo7jLrN93pdP/aHf6sA1GmhhDY4OgGk9lnyOGPmgER7MXKD5xE65HL9nKBZiMtNaVWwMmTgipPM1bazyTIrKg+1ErNNM3mwviyfmj9aQ/CE+r+TITP42br3JIkTYNbNseZg0cBzgSWOWmbK/g+5Faep3Ywo2VXJ7Oi5hhPanqDFWvKXuZ7CkRfmiAnZZd5nnwnucoGcEq0xdu6CNwcbQg84GCliixvMB5MiO8/aK/TMvtZTyYMxy/w1zdg1tggsXZQ7HjitpVQseFiLIOGNnNIohz X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8958.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(396003)(39860400002)(366004)(376002)(230922051799003)(64100799003)(1800799012)(451199024)(186009)(38100700002)(41300700001)(36756003)(86362001)(6916009)(316002)(66556008)(8936002)(54906003)(66946007)(66476007)(8676002)(26005)(4326008)(6486002)(5660300002)(478600001)(44832011)(2616005)(6506007)(83380400001)(6512007)(53546011)(2906002)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5738 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM3PEPF0000A797.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9e201ae9-c964-4435-6a88-08dc176b7307 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vyd3jaAuMwwk/IWO8wDxYlTXgG8BFha5FQrP8Kko3Co8MgKxnbjlC85ZcmeIrIcF1/x+YJW8BjDGuABl4EqLxCpjnU0UrskeIkj+TkcY37MBPd7adRkvPGXYxyn3iu66XyYAkMj02oWQmJDf3ezi8zC2iI/hxEXzWrpr/llwxIDdxAYAQGH+4VAmVg/zwEMJqLoHSI6Bbo3zpp3mv8Dip5DHLolgM/TA6E468XWrEOEPMszeq3nJVU4Y/1QbN1dekBqTv1Kb4qe8bTzDARtUASLFHTLEZ3SO15xsALFE4mGXrB/ZTPFswclSpaNWCLEOwcmURGN/2h7bbn4Hf0oNfY8CE69M4F5MP6/GDuKOiTqPPnyLPv0gpUCceztpsQiBxPMUzY91iVBzq0jRlE78YG87TX2p2D8u+LFHtBq+hcrI2m9YvZUycnqWMIIvII9NLdenYcb1+JpoS0pWodKiS9576Yd/BHWhW+JAAMkmo60f6lhLVnxN3q24hBrFx3Inatmz4CP+9e6oECkln2nQ6WODrbEOiYYExOPLmpqtAN3WBedgzJSqaoZlDJ50I2hT7FrpiahyxzjF0UG1FJ4KL8ihg0R1dADzzrv7La1qVNWgRJHtaO/G+XgvmfMFVdO0LYOtwT0+VWs9TAK2pZQ0t+nmqTOEwYkhZaawh41xJVW9hhvbBdevLRMvPnBOY2OIIwcvb6DgNwvx76T7iJwCsYImGSl4HQWfBxQSLnNPX8Q= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(396003)(346002)(136003)(39860400002)(376002)(230922051799003)(186009)(82310400011)(64100799003)(451199024)(1800799012)(40470700004)(46966006)(36840700001)(40480700001)(40460700003)(6512007)(83380400001)(26005)(53546011)(6506007)(336012)(86362001)(2616005)(36756003)(356005)(6666004)(6862004)(47076005)(4326008)(81166007)(44832011)(5660300002)(82740400003)(8676002)(54906003)(478600001)(8936002)(70586007)(6486002)(316002)(70206006)(2906002)(41300700001)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2024 14:49:14.7842 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f41d1d75-e4ca-46c8-32c8-08dc176b79a0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A797.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9321 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 17/01/2024 07:42, Jeff Law wrote: > > > On 1/13/24 08:43, Alex Coplan wrote: > > The next patch in this series exposes an interface for creating new uses > > in RTL-SSA. The intent is that new user-created uses can consume new > > user-created defs in the same change group. This is so that we can > > correctly update uses of memory when inserting a new store pair insn in > > the aarch64 load/store pair fusion pass (the affected uses need to > > consume the new store pair insn). > > > > As it stands, finalize_new_accesses is called as part of the backwards > > insn placement loop within change_insns, but if we want new uses to be > > able to depend on new defs in the same change group, we need > > finalize_new_accesses to be called on earlier insns first. This is so > > that when we process temporary uses and turn them into permanent uses, > > we can follow the last_def link on the temporary def to ensure we end up > > with a permanent use consuming a permanent def. > > > > Bootstrapped/regtested on aarch64-linux-gnu, OK for trunk? > > > > Thanks, > > Alex > > > > gcc/ChangeLog: > > > > PR target/113070 > > * rtl-ssa/changes.cc (function_info::change_insns): Split out the call > > to finalize_new_accesses from the backwards placement loop, run it > > forwards in a separate loop. > So just to be explicit -- given this is adjusting the rtl-ssa > infrastructure, I was going to let Richard S. own the review side -- he > knows that code better than I. Yeah, that's fine, thanks. Richard is away this week but back on Monday, so hopefully he can take a look at it then. Alex > > Jeff