From: Andi Kleen <ak@linux.intel.com>
To: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Cc: gcc-patches@gnu.org
Subject: Re: [PATCH v4 4/5] Add tests for C/C++ musttail attributes
Date: Fri, 2 Feb 2024 06:50:51 -0800 [thread overview]
Message-ID: <Zb0BS6-YjE9l3iaD@tassilo> (raw)
In-Reply-To: <CAAgBjMm9G=MxRmi7a+_B=b5rhK2UoB2oQ6Lc4Gr=MQr44=K4KA@mail.gmail.com>
> Sorry, I wasn't clear about this in previous patch -- noipa will
> subsume other ipa attributes,
> so there's no need to have noinline, noclone along with noipa.
> int __attribute__((noipa)) callee(int i) should be sufficient for
> disabling IPA optimizations involving callee.
I thought you were worried about extra IPA optimizations. I prefer to
clearly say what I mean (besides it was just copied from existing
tests), so the verbose form is better. So if e.g. gcc ever re-adds the old
RTL inliner it wouldn't break.
-Andi
next prev parent reply other threads:[~2024-02-02 14:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 9:09 Updated musttail patches Andi Kleen
2024-02-02 9:09 ` [PATCH v4 1/5] Improve must tail in RTL backend Andi Kleen
2024-02-02 9:09 ` [PATCH v4 2/5] C++: Support clang compatible [[musttail]] (PR83324) Andi Kleen
2024-02-02 9:09 ` [PATCH v4 3/5] C: Implement musttail attribute for returns Andi Kleen
2024-02-02 9:09 ` [PATCH v4 4/5] Add tests for C/C++ musttail attributes Andi Kleen
2024-02-02 11:01 ` Prathamesh Kulkarni
2024-02-02 14:50 ` Andi Kleen [this message]
2024-02-02 9:09 ` [PATCH v4 5/5] Add documentation for musttail attribute Andi Kleen
2024-02-04 4:35 ` Sandra Loosemore
2024-02-05 13:32 ` Andi Kleen
2024-02-02 13:18 ` Updated musttail patches Joseph Myers
2024-02-02 14:49 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zb0BS6-YjE9l3iaD@tassilo \
--to=ak@linux.intel.com \
--cc=gcc-patches@gnu.org \
--cc=prathamesh.kulkarni@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).