public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Marek Polacek <polacek@redhat.com>
Cc: Alex Coplan <alex.coplan@arm.com>,
	gcc-patches@gcc.gnu.org, Jason Merrill <jason@redhat.com>,
	Nathan Sidwell <nathan@acm.org>
Subject: Re: [PATCH] c++: Don't advertise cxx_constexpr_string_builtins [PR113658]
Date: Fri, 2 Feb 2024 17:32:31 +0100	[thread overview]
Message-ID: <Zb0ZH6XIE5D2ONgS@tucnak> (raw)
In-Reply-To: <Zb0X3asmd88YSL-j@redhat.com>

On Fri, Feb 02, 2024 at 11:27:09AM -0500, Marek Polacek wrote:
> > With -pedantic-errors we would have __has_extension behaving like
> > __has_feature, and I wanted to check in the test that this doesn't get
> > reported as a feature or extension.
>  
> Oh I see.  A comment to that effect might be helpful.

Don't we have over 1200 other tests with dg-options "" which
don't have comments why they are doing that?

	Jakub


  reply	other threads:[~2024-02-02 16:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02 10:27 Alex Coplan
2024-02-02 14:34 ` Marek Polacek
2024-02-02 15:45   ` Alex Coplan
2024-02-02 16:27     ` Marek Polacek
2024-02-02 16:32       ` Jakub Jelinek [this message]
2024-02-02 16:37         ` Marek Polacek
2024-02-09 17:55     ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zb0ZH6XIE5D2ONgS@tucnak \
    --to=jakub@redhat.com \
    --cc=alex.coplan@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=nathan@acm.org \
    --cc=polacek@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).