From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 407503858403 for ; Fri, 2 Feb 2024 16:37:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 407503858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 407503858403 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706891877; cv=none; b=KcZt7dftOCZZAetrW8DpDtnU4U9tSVQmP0M8RTXAY5Fg+yv02BzoVp3joQItmnyF+0rX7zGwFCD2LnnekESVxE4kKS+BCFnhrEvjEWa9INsV6pCP3R5Q+5oD5HKFYpNNmrcOrQ8i58PKVdftZB3N4xLB1dy+icNHmQgljq0FIDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706891877; c=relaxed/simple; bh=Kei7ErEVkw+Lbm9+5qHqPzgNw0AzinPmEhL2JzTTFc8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=C8ajjeif0aP1AmuI6tmIm18Lcxa24Le3EdgLE7arXOcSgkegJmO3vkxt++7bcat93mJ1wVCKghYZViAKyZ43fSUBp8y3e4Nj4rjQpM+jX49s2TJEcql7gl2fxWpTY3F2Wp/SevJTorNMtyvWsXQHunVCEmxcFEobA7EXWWjKA44= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706891875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WytgR6G7PDe0W2SzlHN4VC5Rmh1DmqS6AoBlDfguvPw=; b=cSLVdabYcZL22sg6kglePxxqRoLwRMFUuock5wTIfL1+YHK0Kl3bPv9I6OtOsgc0Bwasd0 vsSz5msubcavke3on2ghPL5SUzUn8d8oacN5IjzkiyvuqpRPne6+OO1t5iP7p50t7aOuZV 6ZLCcScwKD3OjpykS09PeG4Lhe1ZXCU= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-455-BH4Alve0O7yWJ6ZsQ4kFnA-1; Fri, 02 Feb 2024 11:37:54 -0500 X-MC-Unique: BH4Alve0O7yWJ6ZsQ4kFnA-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7853b039d45so263638185a.1 for ; Fri, 02 Feb 2024 08:37:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706891874; x=1707496674; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WytgR6G7PDe0W2SzlHN4VC5Rmh1DmqS6AoBlDfguvPw=; b=H2Yp5P1rI0GVXi+LI7ihsWF1EdAEo+FLksllIST/lxefseMv0KHB86i0eAHmXqAvdU AfeoEHtS9FVU9aeALJzso1bauFvcPw/gf+2h5+DnmOfME0hHDAGhZ99vn2SpL9ymdygj nPVC09Ph9dmtb/OJ3acRJtDScbYbFLcfbMMyYQ+IamGKqX7fheaYpECMLb4XG6nwW2f0 6zkZ0D9CHBCz110MWJ20SPINIqNtHeBhj3lX75X1A0dwQ8PzCYBq3kVSAQ2/Jc0rNR/h 43RoAL2ncB73tLR8wORijKp5kMt0p+IA0/Wm3GQ1uQgNXf8tNWwD4rrpfA8T5nR3aV72 UIDw== X-Gm-Message-State: AOJu0YxwXC+BmrQMny6H8Ql8IRTdK15SaoWq6FdvDHJf5tABvScnrAV5 w1bVnf1F5F7SPO6P6hQ5jFv7v2Nh5oSmodLek/4tFpO7MjVqBN4pESiDJRVemr29Hne6Y37ksY2 CjGKyWCb8UufHnXVG+wtkhAO8VLzSjlbAku8L7GAUZiCJ+pvGG53Nju4= X-Received: by 2002:ae9:c102:0:b0:783:d096:d761 with SMTP id z2-20020ae9c102000000b00783d096d761mr5744975qki.31.1706891874190; Fri, 02 Feb 2024 08:37:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IERB1qeqAGRbL0hEinNGSLbPMQwh52aX3L1ZO6jhdzW6eok3eDhn53LGTdMufbNJtom2BVnbg== X-Received: by 2002:ae9:c102:0:b0:783:d096:d761 with SMTP id z2-20020ae9c102000000b00783d096d761mr5744960qki.31.1706891873943; Fri, 02 Feb 2024 08:37:53 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUGZOPUW5pENt4WLfsMWrXVJ7koRo0Q07j6giTRCn+GSGppdyHN9wR88aLIP1zFsA8v70UT/8LRlfsFXrKhMtZLIRPaNxzLAof6PZUxCexdDcOimk5+S0HMGdVDvmJ6JH+i6qZclM7qFgM= Received: from redhat.com (2603-7000-9500-34a5-0000-0000-0000-1db4.res6.spectrum.com. [2603:7000:9500:34a5::1db4]) by smtp.gmail.com with ESMTPSA id z29-20020a05620a08dd00b007855f767745sm85045qkz.73.2024.02.02.08.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 08:37:53 -0800 (PST) Date: Fri, 2 Feb 2024 11:37:51 -0500 From: Marek Polacek To: Jakub Jelinek Cc: Alex Coplan , gcc-patches@gcc.gnu.org, Jason Merrill , Nathan Sidwell Subject: Re: [PATCH] c++: Don't advertise cxx_constexpr_string_builtins [PR113658] Message-ID: References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Feb 02, 2024 at 05:32:31PM +0100, Jakub Jelinek wrote: > On Fri, Feb 02, 2024 at 11:27:09AM -0500, Marek Polacek wrote: > > > With -pedantic-errors we would have __has_extension behaving like > > > __has_feature, and I wanted to check in the test that this doesn't get > > > reported as a feature or extension. > > > > Oh I see. A comment to that effect might be helpful. > > Don't we have over 1200 other tests with dg-options "" which > don't have comments why they are doing that? Yes, but the __has_extension / __has_feature thing doesn't seem obvious at all, and the test passed for me with and without dg-options "". But I'm fine with the patch either way. Marek