From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id EA127385829A for ; Fri, 26 Jan 2024 14:12:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA127385829A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EA127385829A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706278326; cv=none; b=leSrq4EE5S0hRXo7c8ixkcxBTb7gy/WVCvN4gGH8axESmFvMX5Tb/CCqyaXpMuX1l4a9KO4opGRW83ingxK92WdQGyQKYPo8Y5m4wP+rMwIEgFiOKwhnOBxx0n+LHEGSZXKNt+mvmMgPBLx0tR9JiZA4AjpiRasF71l96bRkhAU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706278326; c=relaxed/simple; bh=FvrxUm96UbhYEfHAObLfzSvMOcEIFwVeyxg1k8cpw+I=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=qv9qJMHyJgtK/NQxCCCIoMh9f1vtZijzNBYhj8h1VSPx0oXbccDbRsGf2N/rHKUthRgmIc19txFVVd4arpTrIFeHtjvGQluFSDQBjakdqONDQ0evFEv4BspLaBBO9VjCfC18EW5fOcsD0RnpywNSOZ2TFfpIAydDxvLVz8snyUg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706278324; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=VDCA3tpRtB0O0Gf0bDfESMxmlbproP6focDItgTJHn4=; b=HenxaoHPz0CtkIaFNHMXxii6TVBV/PUPE4IyhQAOeXhyDFtxo0UjObcjzwxq8gtYTJZskN Xs6t0GIfhdlTQnhomMfSmyRp1TD/+QbPkBgIbOu1eSSweIyNUZ65LsmSm4d+H+iTIB2otM S28poU24mkCTlNIS2s76He876gqPaKU= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-Kr3ChMOcM_SpQYyWFKlAPw-1; Fri, 26 Jan 2024 09:12:02 -0500 X-MC-Unique: Kr3ChMOcM_SpQYyWFKlAPw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F2C53C000A5; Fri, 26 Jan 2024 14:12:02 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 248DCC15E61; Fri, 26 Jan 2024 14:12:02 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 40QEBx4B1385299 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 15:11:59 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 40QEBwjR1385298; Fri, 26 Jan 2024 15:11:58 +0100 Date: Fri, 26 Jan 2024 15:11:58 +0100 From: Jakub Jelinek To: Richard Biener Cc: Andrew Stubbs , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Avoid registering unsupported OMP offload devices Message-ID: Reply-To: Jakub Jelinek References: <20240126120143.6978F3858C62@sourceware.org> <3b5417c9-179f-41f9-b4e5-2882aff27340@baylibre.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jan 26, 2024 at 03:04:11PM +0100, Richard Biener wrote: > > > Otherwise it looks reasoanble to me, but let's see what Andrew thinks. > > > > 'n' before 'a', please. ;-) > > ?! I've misspelled a word. > @@ -1443,6 +1445,16 @@ suitable_hsa_agent_p (hsa_agent_t agent) > switch (device_type) > { > case HSA_DEVICE_TYPE_GPU: > + { > + char name[64] = "nil"; > + if ((hsa_fns.hsa_agent_get_info_fn (agent, HSA_AGENT_INFO_NAME, name) > + != HSA_STATUS_SUCCESS) > + || isa_code (name) == EF_AMDGPU_MACH_UNSUPPORTED) > + { > + GCN_DEBUG ("Ignoring unsupported agent '%s'\n", name); > + return false; > + } I must say I know nothing about HSA libraries, but generally if a function that is supposed to fill some buffer fails the content of the buffer is undefined/unpredictable. So might be better not to not initialize name before calling the function (unless it has to be initialized) and strcpy it to nil or something similar if it fails. Jakub