From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CDAD33858C60 for ; Sun, 28 Jan 2024 16:31:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDAD33858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CDAD33858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706459469; cv=none; b=MM6qs6UMtbIWHpMt5Wjki4vcD7g2hTJrp6xGIEO8YExO1z67cobgIwBGhEDkPtWRkZO3mYNJdHqU8V7bZprXY9T+uckBhDLsOtCMJbyHC3KEkroXlH+ZmfAcKA1oWb6GZuYVkLfVajECLiQ/OVAvdrWHE40rm8zvaztoEih3IJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706459469; c=relaxed/simple; bh=cTWeB8r9dquV7f/x7ALB+RZS4bvT+6GEOHnyUp0njag=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=hBUGFZPZxy9d0wLEI7vcq905P7URuEv19oVSPYRZWtNNZ6RikEqZnjV9AIIQtHYdACmzY2MoOR+OAzfbYsPREqlByu9cfqKye7d6n2d/K3yGCHCepojHXrbwFVvnaHUgIIsQEATJ+NsDQyAxcQNjYnO2J5Y70BmtwC5KH+uolKU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706459463; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=AXJ65vloT3m0cxXXaWrBLjDTUW0x3Ifc/zZEltXGVQo=; b=Kcr0A+pq4TTl7b/h7UbPE5q/BzwMX4QV2qvrkKuSsi87moAAZ4zDDIwGJQCDrRAMBzDYZ1 6Wg7Pjcha9NEHkYMz+fqUTz4ehNoIPUCfa2vNmyIILCo+6kb/uv7NWzYvVxuGPWV6BdVFe X2e9BEuxkVypPQX/cqnDaXfkYNANSWo= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-3rP93rZAOXuitWxO-26dAg-1; Sun, 28 Jan 2024 11:30:59 -0500 X-MC-Unique: 3rP93rZAOXuitWxO-26dAg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 311D329AB40D; Sun, 28 Jan 2024 16:30:59 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EAA72900; Sun, 28 Jan 2024 16:30:58 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 40SGUutG2964814 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 28 Jan 2024 17:30:56 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 40SGUsDA2964813; Sun, 28 Jan 2024 17:30:54 +0100 Date: Sun, 28 Jan 2024 17:30:54 +0100 From: Jakub Jelinek To: iain@sandoe.co.uk Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 1/2] libgcc: Make heap trampoline support dynamic [PR113403]. Message-ID: Reply-To: Jakub Jelinek References: <20240128140733.94198-1-iain@sandoe.co.uk> <20240128140733.94198-2-iain@sandoe.co.uk> MIME-Version: 1.0 In-Reply-To: <20240128140733.94198-2-iain@sandoe.co.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Jan 28, 2024 at 02:07:32PM +0000, Iain Sandoe wrote: > This removes the heap trampoline support functions from libgcc.a and > adds them to libgcc_eh.a. They are also present in libgcc_s. > > PR libgcc/113403 > > libgcc/ChangeLog: > > * config/aarch64/t-heap-trampoline: Move the heap trampoline > support functions from libgcc.a to libgcc_eh.a. > * config/i386/t-heap-trampoline: Likewise. LGTM. I'd also default to -shared-libgcc when linking using gcc driver with the new trampoline option in options unless -static-libgcc has been used, but that can be done incrementally. > diff --git a/libgcc/config/aarch64/t-heap-trampoline b/libgcc/config/aarch64/t-heap-trampoline > index b22480800b2..6468fb8704f 100644 > --- a/libgcc/config/aarch64/t-heap-trampoline > +++ b/libgcc/config/aarch64/t-heap-trampoline > @@ -16,4 +16,5 @@ > # along with GCC; see the file COPYING3. If not see > # . > > -LIB2ADD += $(srcdir)/config/aarch64/heap-trampoline.c > +LIB2ADDEH += $(srcdir)/config/aarch64/heap-trampoline.c > +LIB2ADDEHSHARED += $(srcdir)/config/aarch64/heap-trampoline.c > diff --git a/libgcc/config/i386/t-heap-trampoline b/libgcc/config/i386/t-heap-trampoline > index 613f635b1f6..728c1e26a92 100644 > --- a/libgcc/config/i386/t-heap-trampoline > +++ b/libgcc/config/i386/t-heap-trampoline > @@ -16,4 +16,5 @@ > # along with GCC; see the file COPYING3. If not see > # . > > -LIB2ADD += $(srcdir)/config/i386/heap-trampoline.c > +LIB2ADDEH += $(srcdir)/config/i386/heap-trampoline.c > +LIB2ADDEHSHARED += $(srcdir)/config/aarch64/heap-trampoline.c > -- > 2.39.2 (Apple Git-143) Jakub