From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 85A023858CDA for ; Mon, 29 Jan 2024 13:27:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 85A023858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 85A023858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706534864; cv=none; b=hsPRwYw6m8RYoMDyGqUOWxqYyqjGGScAbvXBCLsyHmEVLVouo3Ye+dMJKBoCbc4ogNJwEbt40+GzNoD19UJOuovWgjUoff90lmc+2T74r7ANcCJnW47nHnmH13XkBUKml01/8jNq1biDLQZdpiANs7IbqXyFXI+5Hbx8PBM9s+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706534864; c=relaxed/simple; bh=f33HIK70XYmxdY07mGU4FoVyNW89td6V+Q0KJ7+d46U=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=SCD6h49Fcju1mYByhrFYSZ82gotXdC5tP5hpddfBweB7zWDncysjLoLaYSMBxLHKk/iY/05Qsv43mCKQfxaH/PqQk5nBfBDZ3fE1vTiTUTixQAbSuQ7DffFjpuruBzcM36cuv4hMIRczTDuCjd7u4wO8UH6rM/P4ZRGG2emdvao= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706534863; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=2kupHTNYgiVOD/lgwBMdvmDYbicQgDAgzYKdetQQZlI=; b=WmmI1vAnc7YpHeBwVx2pgEwdrJVLtNsu3XGWZxfUwBwSE1m7YjOkvahXm8em9gmM5Tr/o7 cXB9H4eY6hXiWLh4LepNmAr5JnQ9lfyWt6uSSPbgOtrgIZWwtfyChv0Om5LhpQMBjeQv1E jjKucxYmpA25+uVcKTXQzksOnEEDfgo= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-8zqSv-1rPziEkMXd-KRBdA-1; Mon, 29 Jan 2024 08:27:41 -0500 X-MC-Unique: 8zqSv-1rPziEkMXd-KRBdA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5FBBE282D3C2; Mon, 29 Jan 2024 13:27:41 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22C8D492BE2; Mon, 29 Jan 2024 13:27:41 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 40TDRcsx2974113 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 29 Jan 2024 14:27:38 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 40TDRcX62974112; Mon, 29 Jan 2024 14:27:38 +0100 Date: Mon, 29 Jan 2024 14:27:37 +0100 From: Jakub Jelinek To: "H.J. Lu" Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v3] x86: Save callee-saved registers in noreturn functions for -O0/-Og Message-ID: Reply-To: Jakub Jelinek References: <20240129132605.497501-1-hjl.tools@gmail.com> MIME-Version: 1.0 In-Reply-To: <20240129132605.497501-1-hjl.tools@gmail.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jan 29, 2024 at 05:26:05AM -0800, H.J. Lu wrote: > Changes in v3: > > 1. Add the TREE_THIS_VOLATILE check to minimize noreturn attribute lookup. > > Changes in v2: > > 1. Lookup noreturn attribute first. > 2. Use __attribute__((noreturn, optimize("-Og"))) in pr38534-6.c. > > ---- > Save callee-saved registers in noreturn functions for -O0/-Og so that > debugger can restore callee-saved registers in caller's frame. > > Also add the TREE_THIS_VOLATILE check to minimize noreturn attribute > lookup. > > gcc/ > > PR target/38534 > * config/i386/i386-options.cc (ix86_set_func_type): Save > callee-saved registers in noreturn functions for -O0/-Og. > > gcc/testsuite/ > > PR target/38534 > * gcc.target/i386/pr38534-5.c: New file. > * gcc.target/i386/pr38534-6.c: Likewise. Ok, thanks. Jakub