From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tburnus@baylibre.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [RFA/RFC] C++/OpenMP: Supporting (first)private for member variables [PR110347] - or VALUE_EXPR and gimplify
Date: Fri, 16 Feb 2024 16:57:27 +0100 [thread overview]
Message-ID: <Zc+F58bXrFKDQJyK@tucnak> (raw)
In-Reply-To: <Zc+Ceh3QohGl+YcB@tucnak>
Hi!
Ah, and the reason why it doesn't work on target is that it has the
everything is mapped assumption:
if ((ctx->region_type & ORT_TARGET) != 0)
{
if (ctx->region_type & ORT_ACC)
/* For OpenACC, as remarked above, defer expansion. */
shared = false;
else
shared = true;
ret = lang_hooks.decls.omp_disregard_value_expr (decl, shared);
Perhaps shared = true; should be shared = (flags & GOVD_MAPPED) != 0;
now that we have private/firstprivate clauses on target?
Jakub
next prev parent reply other threads:[~2024-02-16 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 15:15 Tobias Burnus
2024-02-16 15:42 ` Jakub Jelinek
2024-02-16 15:57 ` Jakub Jelinek [this message]
2024-02-16 23:35 ` [Patch] OpenMP/C++: Fix (first)private clause with member variables [PR110347] [was: [RFA/RFC] C++/OpenMP: Supporting (first)private for member variables [PR110347] - or VALUE_EXPR and gimplify] Tobias Burnus
2024-02-29 17:26 ` Jakub Jelinek
2024-03-01 16:19 ` [Patch] OpenMP/C++: Fix (first)private clause with member variables [PR110347] Tobias Burnus
2024-03-01 16:21 ` Jakub Jelinek
2024-02-16 15:40 [RFA/RFC] C++/OpenMP: Supporting (first)private for member variables [PR110347] - or VALUE_EXPR and gimplify Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc+F58bXrFKDQJyK@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tburnus@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).