From: Jakub Jelinek <jakub@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: Richard.Sandiford@arm.com
Subject: [committed] aarch64: Fix build against libc++ in c++11 mode [PR113763]
Date: Tue, 6 Feb 2024 16:21:14 +0100 [thread overview]
Message-ID: <ZcJOasQqjXb2rfKo@tucnak> (raw)
Hi!
std::pair ctor used in tiles constexpr variable is only constexpr in C++14
and later, it works with libstdc++ because it is marked constexpr there even
in C++11 mode.
The following patch fixes it by using an unnamed local class instead of
std::pair, and additionally changes the first element from unsigned int to
unsigned char because 0xff has to fit into unsigned char on all hosts.
Bootstrapped/regtested on aarch64-linux, preapproved by Richard in the PR,
committed to trunk.
2024-02-06 Jakub Jelinek <jakub@redhat.com>
PR target/113763
* config/aarch64/aarch64.cc (aarch64_output_sme_zero_za): Change tiles
element from std::pair<unsigned int, char> to an unnamed struct.
Adjust uses of tile range variable.
--- gcc/config/aarch64/aarch64.cc.jj 2024-02-06 08:43:14.899888072 +0100
+++ gcc/config/aarch64/aarch64.cc 2024-02-06 11:41:47.855049148 +0100
@@ -13130,7 +13130,7 @@ aarch64_output_sme_zero_za (rtx mask)
if (mask_val == 0xff)
return "zero\t{ za }";
- static constexpr std::pair<unsigned int, char> tiles[] = {
+ static constexpr struct { unsigned char mask; char letter; } tiles[] = {
{ 0xff, 'b' },
{ 0x55, 'h' },
{ 0x11, 's' },
@@ -13144,14 +13144,14 @@ aarch64_output_sme_zero_za (rtx mask)
const char *prefix = "{ ";
for (auto &tile : tiles)
{
- auto tile_mask = tile.first;
+ unsigned int tile_mask = tile.mask;
unsigned int tile_index = 0;
while (tile_mask < 0x100)
{
if ((mask_val & tile_mask) == tile_mask)
{
i += snprintf (buffer + i, sizeof (buffer) - i, "%sza%d.%c",
- prefix, tile_index, tile.second);
+ prefix, tile_index, tile.letter);
prefix = ", ";
mask_val &= ~tile_mask;
}
Jakub
reply other threads:[~2024-02-06 15:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcJOasQqjXb2rfKo@tucnak \
--to=jakub@redhat.com \
--cc=Richard.Sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).