From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id F000E3858C74 for ; Wed, 28 Feb 2024 08:00:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F000E3858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F000E3858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709107235; cv=none; b=DFEvxgeL7PWPudA0N0QNsr2/rTT9RBXueaPhvQR/fq/dOMkuGJy33UglNKdEt4T6oHj47lRfq5bV9D3ZeVbmqpBrhBqWzviPk2ZAOyThFRKzeC68fz1fNFotg/lYrPsml9dr/E9S6WswThJAwrGlxUPfIJHluNJapyVE8jTwRzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709107235; c=relaxed/simple; bh=rX3mG9qI40wP3DodODYC2Vg19opO4I0pD/5STP2cVuM=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=C6s0XusP/lqigZRBMzTMJ2MJVdDIW24roB7pIGoon/PvwRYJLg3RGBlAzQUDjGjm+PFGWx404yIxDSp6CNECIY6Xdsk7cH7xHqcLlKYlluCyHyMUWoNeTLEP3smv6Yn6bDslmoc7mtep/qSL9ASJJxODMBFcBxf6wMl8Ph3Hjc0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709107233; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=/CuKHRXik2nAiry3D4pCphO2HSjwPpBzR0U5RLGJWno=; b=Za1EylDmPonFEPbjGsUB7fhNdLHmzcBOSN7rssdCTxKU05Nat30hvRlZ+INRK0zTuvQ5pz dipBvALJ/CK0DexHgrVOfdDq+GpSWlCtzKC6PlEkqEcVKOTw5btB1YuBF32YLH+zXbyxmB 5p0/h294+7N6HZWscsF5k09pu88A7MA= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-mcS3IYtXOwipMPr0GfYWtw-1; Wed, 28 Feb 2024 03:00:29 -0500 X-MC-Unique: mcS3IYtXOwipMPr0GfYWtw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 57AA02999B21; Wed, 28 Feb 2024 08:00:29 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A2ED2026D0A; Wed, 28 Feb 2024 08:00:28 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 41S80Qrn2997209 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 09:00:27 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 41S80QKq2997208; Wed, 28 Feb 2024 09:00:26 +0100 Date: Wed, 28 Feb 2024 09:00:25 +0100 From: Jakub Jelinek To: Richard Biener , Uros Bizjak , hjl.tools@gmail.com, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] i386: Guard noreturn no-callee-saved-registers optimization with -mnoreturn-no-callee-saved-registers [PR38534] Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Feb 27, 2024 at 03:57:52PM +0100, Jakub Jelinek wrote: > On Tue, Feb 27, 2024 at 01:09:09PM +0100, Jakub Jelinek wrote: > > So, IMHO either revert the changes altogether, or guard on -mcmodel=kernel > > (but talk to kernel people on linux-toolchains if that is what they actually > > want). > > Here is a patch which guards this by non-default option, so kernel and other > users can choose if they want this or not. On top of the PR114116 patch. > > Only lightly tested so far. Successfully bootstrapped/regtested on x86_64-linux and i686-linux now. Ok for trunk (if the PR114116 patch is approved too)? > 2024-02-27 Jakub Jelinek > > PR target/38534 > * config/i386/i386.opt (mnoreturn-no-callee-saved-registers): New > option. > * config/i386/i386-options.cc (ix86_set_func_type): Don't use > TYPE_NO_CALLEE_SAVED_REGISTERS_EXCEPT_BP unless > ix86_noreturn_no_callee_saved_registers is enabled. > * doc/invoke.texi (-mnoreturn-no-callee-saved-registers): Document. > > * gcc.target/i386/pr38534-1.c: Add -mnoreturn-no-callee-saved-registers > to dg-options. > * gcc.target/i386/pr38534-2.c: Likewise. > * gcc.target/i386/pr38534-3.c: Likewise. > * gcc.target/i386/pr38534-4.c: Likewise. > * gcc.target/i386/pr38534-5.c: Likewise. > * gcc.target/i386/pr38534-6.c: Likewise. > * gcc.target/i386/pr114097-1.c: Likewise. > * gcc.target/i386/stack-check-17.c: Likewise. Jakub