From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C0A963858C98 for ; Wed, 28 Feb 2024 11:20:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C0A963858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C0A963858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709119202; cv=none; b=RvKkHZwUg8qkmSt+cLhkd/yct58KcV+UV9K4AvCZQnrwB28cT1NZLBNaY22ZB2BKqiWwaltqNnOhD331jwZ241FV7aoO0wyGi/wD8u1SSSLGVvCiMVBkfF3Ls2klnoqhG0JWsP0gBayD38HUzLJgqi3qyEkweLwLREcySbz0Ohs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709119202; c=relaxed/simple; bh=X2KhU/e3OS97Go4TUMyUT+nnoWCRGKJ2c/OR9kjVr3w=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=mOA4T2zXUsEW0QAGfbeaPrZ0v9CSHwiQvUI/SFhfxtF1c2zzR5GiP6U+Mt2zB5fRGx2f2juc2VIJJ6KDkdHfzO2Nt3gqGaqzSL0JMeOXV6XVtzQmg1ql6mf0zG/9xKR5Yb9KyEFBJvoMab6l6X1zooofmOkrh3kjzEwZ0eKmoWc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709119200; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=2XV4tHTty2fnPdthDQMGDhZqbtiD7nVL9wHbEIWDbcY=; b=IcDqxGubhWCs2KUA+ssokjhX/3f3XByBwxGK0dd3xHx4xe6ADEk2IbuU5lp6SZvXMXHjjp gqC76wbt7HfXIpZf5F31v5ypky+MDTDH4pndH2oQFLPViZ+uWs7E/ZP5ydaBwhYtxx2eoU VckK1qkva8Af2LjOcts5AmEK2uxQX0I= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-F7mkEPpXOZyFvDIatdGP-A-1; Wed, 28 Feb 2024 06:19:56 -0500 X-MC-Unique: F7mkEPpXOZyFvDIatdGP-A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 804EB28B6A18; Wed, 28 Feb 2024 11:19:56 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 43D39401CB77; Wed, 28 Feb 2024 11:19:56 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 41SBJrVv3022839 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 12:19:54 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 41SBJqSU3022838; Wed, 28 Feb 2024 12:19:52 +0100 Date: Wed, 28 Feb 2024 12:19:52 +0100 From: Jakub Jelinek To: "Andre Vieira (lists)" Cc: gcc-patches@gcc.gnu.org, Richard.Sandiford@arm.com, kyrylo.tkachov@arm.com Subject: Re: [PATCH 2/2] aarch64: Add support for _BitInt Message-ID: Reply-To: Jakub Jelinek References: <20240125174501.32634-1-andre.simoesdiasvieira@arm.com> <20240125174501.32634-3-andre.simoesdiasvieira@arm.com> <88b9a1f0-b0e2-4c61-9f5e-4cb380fa9a7c@arm.com> MIME-Version: 1.0 In-Reply-To: <88b9a1f0-b0e2-4c61-9f5e-4cb380fa9a7c@arm.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Feb 27, 2024 at 01:40:09PM +0000, Andre Vieira (lists) wrote: > Dropped the first patch and dealt with the comments above, hopefully I > didn't miss any this time. > > ---------------------------------- > > This patch adds support for C23's _BitInt for the AArch64 port when > compiling > for little endianness. Big Endianness requires further target-agnostic > support and we therefor disable it for now. > > gcc/ChangeLog: > > * config/aarch64/aarch64.cc (TARGET_C_BITINT_TYPE_INFO): Declare MACRO. > (aarch64_bitint_type_info): New function. > (aarch64_return_in_memory_1): Return large _BitInt's in memory. > (aarch64_function_arg_alignment): Adapt to correctly return the ABI > mandated alignment of _BitInt(N) where N > 128 as the alignment of > TImode. > (aarch64_composite_type_p): Return true for _BitInt(N), where N > 128. > > libgcc/ChangeLog: > > * config/aarch64/t-softfp (softfp_extras): Add floatbitinthf, > floatbitintbf, floatbitinttf and fixtfbitint. > * config/aarch64/libgcc-softfp.ver (GCC_14.0.0): Add __floatbitinthf, > __floatbitintbf, __floatbitinttf and __fixtfbitint. > > gcc/testsuite/ChangeLog: > > * gcc.target/aarch64/bitint-alignments.c: New test. > * gcc.target/aarch64/bitint-args.c: New test. > * gcc.target/aarch64/bitint-sizes.c: New test. LGTM, but as this is mostly aarch64 specific, I'll defer the final ack to Richard or Kyrylo. Jakub