From: Jan Hubicka <hubicka@ucw.cz>
To: "Jørgen Kvalsvik" <j@lambda.is>, ibuclaw@gdcproject.org
Cc: gcc-patches@gcc.gnu.org, richard.guenther@gmail.com
Subject: Re: [PATCH v9 2/2] Add gcov MC/DC tests for GDC
Date: Thu, 22 Feb 2024 14:27:40 +0100 [thread overview]
Message-ID: <ZddLzHtfY_70QiXj@kam.mff.cuni.cz> (raw)
In-Reply-To: <20231231155127.506883-2-j@lambda.is>
> This is a mostly straight port from the gcov-19.c tests from the C test
> suite. The only notable differences from C to D are that D flips the
> true/false outcomes for loop headers, and the D front end ties loop and
> ternary conditions to slightly different locus.
>
> The test for >64 conditions warning is disabled as it either needs
> support from the testing framework or a something similar to #pragma GCC
> diagnostic push to not cause a test failure from detecting a warning.
>
> gcc/testsuite/ChangeLog:
>
> * gdc.dg/gcov.exp: New test.
> * gdc.dg/gcov1.d: New test.
I never wrote anyting in D, so I would preffer Iain to take a look, but
the transition seems direct enough so I think the patch is OK.
Honza
next prev parent reply other threads:[~2024-02-22 13:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-31 15:51 [PATCH v9 1/2] Add condition coverage (MC/DC) Jørgen Kvalsvik
2023-12-31 15:51 ` [PATCH v9 2/2] Add gcov MC/DC tests for GDC Jørgen Kvalsvik
2023-12-31 22:06 ` Iain Buclaw
2024-02-22 13:27 ` Jan Hubicka [this message]
2024-01-02 21:07 ` [PATCH v9 1/2] Add condition coverage (MC/DC) Jørgen Kvalsvik
2024-01-09 9:04 ` Ping: " Jørgen Kvalsvik
2024-01-22 10:21 ` Ping^2 " Jørgen Kvalsvik
2024-01-29 8:53 ` Ping^3 " Jørgen Kvalsvik
2024-02-06 13:09 ` Ping^4 " Jørgen Kvalsvik
2024-02-21 19:08 ` Ping^5 " Jørgen Kvalsvik
2024-01-29 23:31 ` Ping: " Fangrui Song
2024-01-30 9:33 ` Jørgen Kvalsvik
2024-02-22 13:26 ` Jan Hubicka
2024-02-22 14:24 ` Jørgen Kvalsvik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZddLzHtfY_70QiXj@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=ibuclaw@gdcproject.org \
--cc=j@lambda.is \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).