From: Jakub Jelinek <jakub@redhat.com>
To: Michael Matz <matz@suse.de>
Cc: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] tree-optimization/114074 - CHREC multiplication and undefined overflow
Date: Mon, 26 Feb 2024 16:56:28 +0100 [thread overview]
Message-ID: <Zdy0rOAQKyt3v1cU@tucnak> (raw)
In-Reply-To: <12937df3-5d06-dd50-9ebf-254a6e952080@suse.de>
On Mon, Feb 26, 2024 at 04:51:08PM +0100, Michael Matz wrote:
> On Mon, 26 Feb 2024, Jakub Jelinek wrote:
>
> > > Will update the patch, I think any improvement should be done
> > > to get_range_pos_neg (it's a bit odd in behavior for unsigned
> > > but I have only signed things incoming).
> >
> > For unsigned if it always returned 1, it would be quite useless, there would
> > be no point for the caller to call it in that case.
>
> Which seems to make sense for a function called ...pos_neg on unsigned
> types. I would expect calling it to be useless and always return "yep,
> non-negative, why did you ask?".
The callers heavily rely on it doing for unsigned types what it does now
and it matches what the function comment says.
If you have a suggestion for a different name that wouldn't be much longer
than the current one, it can be renamed.
get_msb_range?
Except it doesn't return a range for the most significant bit, but a bitmask
which values are possible.
Jakub
next prev parent reply other threads:[~2024-02-26 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <83476.124022609150401789@us-mta-131.us.mimecast.lan>
2024-02-26 14:22 ` Jakub Jelinek
2024-02-26 14:29 ` Richard Biener
2024-02-26 14:45 ` Jakub Jelinek
2024-02-26 15:51 ` Michael Matz
2024-02-26 15:56 ` Jakub Jelinek [this message]
[not found] <20240226141510.C27103858C33@sourceware.org>
2024-02-26 16:02 ` Jakub Jelinek
2024-02-26 14:15 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zdy0rOAQKyt3v1cU@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=matz@suse.de \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).