From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tburnus@baylibre.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] OpenMP/C++: Fix (first)private clause with member variables [PR110347]
Date: Fri, 1 Mar 2024 17:21:34 +0100 [thread overview]
Message-ID: <ZeIAjhpL2DggI5RC@tucnak> (raw)
In-Reply-To: <d1e4719b-e8e2-45bd-ad8d-03919ca9641d@baylibre.com>
On Fri, Mar 01, 2024 at 05:19:29PM +0100, Tobias Burnus wrote:
> Jakub Jelinek wrote:
> > As discussed on IRC, I believe not disregarding the capture proxies in
> > target regions if they shouldn't be shared is always wrong, but also the
> > gimplify.cc suggestion was incorrect.
> >
> > The thing is that at the place where the omp_disregard_value_expr call
> > is done currently for target region flags is always in_code ? GOVD_SEEN : 0
> > so by testing flags & anything we actually don't differentiate between
> > privatized vars and mapped vars. So, it needs to be moved after we
> > actually compute the flags, similarly how we do it for non-target.
> ...
>
> I have now added Jakub's updated the gimplify.cc patch, renamed the test
> files, added the proposed lambda test case as well, did add a missing line
> break, and updated the target-lambda-1.C to also work with shared memory.
>
> I think the patch should be good, having testing it with offloading here and
> Jakub also testing it on his side.
>
> Final comments, suggestions, remarks?
LGTM, thanks.
Just please mention those FIXMEs somewhere in PR113436, so that when that
bug is fixed we don't remember to remove those #if 0s.
Jakub
prev parent reply other threads:[~2024-03-01 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 15:15 [RFA/RFC] C++/OpenMP: Supporting (first)private for member variables [PR110347] - or VALUE_EXPR and gimplify Tobias Burnus
2024-02-16 15:42 ` Jakub Jelinek
2024-02-16 15:57 ` Jakub Jelinek
2024-02-16 23:35 ` [Patch] OpenMP/C++: Fix (first)private clause with member variables [PR110347] [was: [RFA/RFC] C++/OpenMP: Supporting (first)private for member variables [PR110347] - or VALUE_EXPR and gimplify] Tobias Burnus
2024-02-29 17:26 ` Jakub Jelinek
2024-03-01 16:19 ` [Patch] OpenMP/C++: Fix (first)private clause with member variables [PR110347] Tobias Burnus
2024-03-01 16:21 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeIAjhpL2DggI5RC@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tburnus@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).