From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id C8857385840C for ; Tue, 12 Mar 2024 15:07:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C8857385840C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C8857385840C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710256076; cv=none; b=f8tZ/zg/EmbsTh2X/TMyb5o3Cd/uBSvtAAUX7E3InEwQK9U/cWteKdExFfFQXX78oobZNL87jkJR02N+8w4K3bqpkjFqaaYxxkDMIRRjDVswGn83BJT9piMgxuhkKnZLaow8RDpiKqJYRuTCxJW5FIuE+mrzrVQWDahqSRmZAUw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710256076; c=relaxed/simple; bh=fphpQv+51ZwV+W46r/4r9b+JT/f82GezOuTrpsdJG/Y=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=NDqjPYa7MSlpToRY7a+xraYbWzLUm4o6PcMlDY4XUJBEpAI6mjteSzpcHGkStQV1z2NoaTVanz1UiKgS6hkIdh3fUhg/we0sfGA87Q720lIxoywkpu1NqRqpUF4An/HJS2Pn/72swMTlz/fVH1r9UfthVvSm5p3iVUBrVFEtA/Y= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42CF0Las009138 for ; Tue, 12 Mar 2024 15:07:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=8x0Ed/I7koi2y0B3IxymC9XmLhcxp6sUk9YB82WbSb8=; b=fbb3bCLGI3PJLxh/N9yipUq5hHSAjK8fnGdT+HiPohS3dltMvivkmIwWquc6lh40Hcx8 t5pLAwKVU8O2qGqTSbyUAcMr9m3+eUCMcNflDBJo0HBjfzvpNwy8b7L3PEP2J4Eb7GEs MVK1VPoWbJNJEUu8TkZh29phU+IOUpd0x3C3dm+uyAFRT7vt8ICI80gVUZpSj/sWXzeN c+nzcnVMwjbIB0axzA5slq5O/PGyv9e0EUxeyNmdhzWwmxv3CcTGamiODeqMgDKKwsh7 3KU4T5Wf9CvIs3TDtSQzqUqpMPWpYHrGFVqWWyGXyEsiw9TvReb6GgffL131wu2pBQfp QA== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wtsagr6xw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 12 Mar 2024 15:07:52 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 42CEcZ3H015570 for ; Tue, 12 Mar 2024 15:07:51 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ws2fyqvy8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 12 Mar 2024 15:07:51 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 42CF7jtA35783064 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Mar 2024 15:07:47 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 767A120043; Tue, 12 Mar 2024 15:07:45 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 625A820063; Tue, 12 Mar 2024 15:07:45 +0000 (GMT) Received: from li-819a89cc-2401-11b2-a85c-cca1ce6aa768.ibm.com (unknown [9.152.222.48]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 12 Mar 2024 15:07:45 +0000 (GMT) Date: Tue, 12 Mar 2024 16:07:45 +0100 From: Stefan Schulze Frielinghaus To: Andreas Krebbel Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] s390: Fix test vector/long-double-to-i64.c Message-ID: References: <20240229121504.1200327-1-stefansf@linux.ibm.com> <3f6a2bd4-d44c-466f-ae49-efe782cb5c7c@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f6a2bd4-d44c-466f-ae49-efe782cb5c7c@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: k9sMnpyJ3d5H9zngSy-1rcXF6-2r4W5x X-Proofpoint-ORIG-GUID: k9sMnpyJ3d5H9zngSy-1rcXF6-2r4W5x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-12_10,2024-03-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 impostorscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403120115 X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Mar 11, 2024 at 11:14:04AM +0100, Andreas Krebbel wrote: > On 2/29/24 13:15, Stefan Schulze Frielinghaus wrote: > > Starting with r14-8319-g86de9b66480b71 fwprop improved so that vpdi is > > no longer required. > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/s390/vector/long-double-to-i64.c: Fix scan > > assembler directive. > > Should we perhaps rather turn the scan-assembler directives into something which checks for the > absence of vpdi then? In order to get notified once this really useful optimization breaks? I thought about checking for the most optimal code which would be just two loads and a convert instruction. Thus if this fails, then we have a regression. Speaking of regressions, the old behaviour was restored by r14-9412-g3e3e4156a5f93e which means we are back using vpdi. Thus, I will leave this patch on hold and have a second look. Cheers, Stefan > > Andreas > > > --- > > .../gcc.target/s390/vector/long-double-to-i64.c | 13 +++++++++---- > > 1 file changed, 9 insertions(+), 4 deletions(-) > > > > diff --git a/gcc/testsuite/gcc.target/s390/vector/long-double-to-i64.c b/gcc/testsuite/gcc.target/s390/vector/long-double-to-i64.c > > index 2dbbb5d1c03..ed89878e6ee 100644 > > --- a/gcc/testsuite/gcc.target/s390/vector/long-double-to-i64.c > > +++ b/gcc/testsuite/gcc.target/s390/vector/long-double-to-i64.c > > @@ -1,19 +1,24 @@ > > /* { dg-do compile } */ > > /* { dg-options "-O3 -march=z14 -mzarch --save-temps" } */ > > /* { dg-do run { target { s390_z14_hw } } } */ > > +/* { dg-final { check-function-bodies "**" "" "" { target { lp64 } } } } */ > > + > > #include > > #include > > > > +/* > > +** long_double_to_i64: > > +** ld %f0,0\(%r2\) > > +** ld %f2,8\(%r2\) > > +** cgxbr %r2,5,%f0 > > +** br %r14 > > +*/ > > __attribute__ ((noipa)) static int64_t > > long_double_to_i64 (long double x) > > { > > return x; > > } > > > > -/* { dg-final { scan-assembler-times {\n\tvpdi\t%v\d+,%v\d+,%v\d+,1\n} 1 } } */ > > -/* { dg-final { scan-assembler-times {\n\tvpdi\t%v\d+,%v\d+,%v\d+,5\n} 1 } } */ > > -/* { dg-final { scan-assembler-times {\n\tcgxbr\t} 1 } } */ > > - > > int > > main (void) > > { >