From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E22AD3858CDA for ; Fri, 15 Mar 2024 18:04:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E22AD3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E22AD3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710525866; cv=none; b=FDeT1q9WwG9TeROzr1RivOVqSfcaVmxhhx12rX02i7bhW381Pv75chUVYmIoxOknMnNPP9lvEwz1Wv5vWHPYdDA3QQ+7/SfjQm6NFT5Qa9kuSVNms7Fo0afqwhfuE1doOTM6MSEFXSEsHeOJrhOkjfUfxcPun4Sz1DI+fwaF8WM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710525866; c=relaxed/simple; bh=G/C4X+1dGiZOKBBZ28G9GjgMglcjcvnxIKrmAzGusxU=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=gp6h8vtJhqSz8D6dSKSb4vu82GmIA6ZXkwNCFJk5vM8cHYdEk5Zax/M6zrleK2nvFsZjSDBruAXV+PJl9iX4HRFr2WKZCRHf7o5UkMDB7rWqwnepvlskT0NWoOd7FQP0Darnkt2q3OaR2WWoeMIeH/YrOUb8df0pwYcSYacDWrk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710525855; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=o568e/8RvOKdAwrCuGYjsm78+kjPBSquNMJskEJ86NU=; b=BbNN0n1hRHf7GJqGEIHqlTR48kTXjAb7VVRaHsDzKi3GJVuyAc89PDNDyODJZ3ir303xQz X79joh4o9sqxNjVoanKN6qaS7tuzQOSy0zy0MshoPoOx9EPPnJpdUXW3eGBg0bLf1SkAmV 8rQHXvarcDN5hi2rmurymPjg64OwH5Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-OG5xACo2PCiRkL0Gd0TyFw-1; Fri, 15 Mar 2024 14:04:11 -0400 X-MC-Unique: OG5xACo2PCiRkL0Gd0TyFw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CD37B85A58B; Fri, 15 Mar 2024 18:04:10 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.225.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7728D111E3F3; Fri, 15 Mar 2024 18:04:10 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 42FI44tl1059734 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 15 Mar 2024 19:04:04 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 42FI448S1059733; Fri, 15 Mar 2024 19:04:04 +0100 Date: Fri, 15 Mar 2024 19:04:04 +0100 From: Jakub Jelinek To: Martin Jambor Cc: GCC Patches , Jan Hubicka Subject: Re: [PATCH] ipa: Avoid duplicate replacements in IPA-SRA transformation phase Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Mar 15, 2024 at 06:57:18PM +0100, Martin Jambor wrote: > --- a/gcc/ipa-param-manipulation.cc > +++ b/gcc/ipa-param-manipulation.cc > @@ -1525,6 +1525,22 @@ ipa_param_body_adjustments::common_initialization (tree old_fndecl, > replacement with a constant (for split aggregates passed > by value). */ > > + if (split[parm_num]) > + { > + /* We must be careful not to add a duplicate > + replacement. */ > + sort_replacements (); > + ipa_param_body_replacement *pbr = > + lookup_replacement_1 (m_oparms[parm_num], > + av.unit_offset); Formatting nit, the = should be on the next line before lookup_replacement_1. ipa_param_body_replacement *pbr = lookup_replacement_1 (m_oparms[parm_num], av.unit_offset); Jakub