From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AEC383858CDB for ; Tue, 19 Mar 2024 12:09:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AEC383858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AEC383858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710850159; cv=none; b=lpxOV8KeF7FHJniW8JsRgcRB9FBss9KptH7xqmuQEwSCMGSLnlPFoybn+9rOOzr+nfNp5Vi9LwoYzryPdsXk/Tc/rfXyHaXpoXA7DTCVm3ce6FDtLwtfosqseMTLFzpjnHA6zmo2uatjrCJmpwchHGsqaiHd6gaX2HecXEqjHok= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710850159; c=relaxed/simple; bh=AxAR5uK5ydtNcuK5uFtkIxm1ttp0+gOnSujVj+AVurA=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=w9t6wRNggRa3Bzkdf3E4MO9K/PpFjxfOdfCeX/W0neNACjEtZX4J42pn32TL6+vTBkWRLiDGoNgCBQ9pFPIi4IjiGL1rknaLe4DHaWkvpzezTAMYHPM2lrdWKWOvPthMlUqDQwUn6axKz8Z/8O/VTFhdr/D2I4u3dDsGnvc3UuE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710850157; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Z7vcuds7Y3E5bLAwDrjtqN2UMiDT6QiLAhkEkCL8m9c=; b=M5TYOlLOxVIS7wJKk+ULD23v/lNSnqwG3ZgIv6onN0HRxzLH1u0uWfqK+352u7LcMKwFu0 JIjbiCLo4uDx4hL0HWeMLazsrDNw9/eM6YIINKc3Lt4bFHvrhc1XNviQYavvgo8uVmOk5Q CBAWMbgLTIVoPKVrbCT0mq5BmbIcH1A= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98-BEeTgjhhO3yH9BhHSMLGZw-1; Tue, 19 Mar 2024 08:09:14 -0400 X-MC-Unique: BEeTgjhhO3yH9BhHSMLGZw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BD48B380390E; Tue, 19 Mar 2024 12:09:11 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 812E12166AE5; Tue, 19 Mar 2024 12:09:11 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 42JC93NL775826 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 19 Mar 2024 13:09:03 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 42JC92je775825; Tue, 19 Mar 2024 13:09:02 +0100 Date: Tue, 19 Mar 2024 13:09:02 +0100 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] tree-optimization/114151 - revert PR114074 fix Message-ID: Reply-To: Jakub Jelinek References: <02403.124031908065200185@us-mta-664.us.mimecast.lan> MIME-Version: 1.0 In-Reply-To: <02403.124031908065200185@us-mta-664.us.mimecast.lan> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Mar 19, 2024 at 01:06:50PM +0100, Richard Biener wrote: > The following reverts the chrec_fold_multiply fix and only keeps > handling of constant overflow which keeps the original testcase > fixed. A better solution might involve ranger improvements or > tracking of assumptions during SCEV analysis similar to what niter > analysis does. > > Bootstrapped and tested on x86_64-unknown-linux-gnu. > > OK for trunk? Or do you prefer to not fix the INTEGER_CST case > either? > > Thanks, > Richard. > > PR tree-optimization/114151 > PR tree-optimization/114269 > PR tree-optimization/114322 > PR tree-optimization/114074 > * tree-chrec.cc (chrec_fold_multiply): Restrict the use of > unsigned arithmetic when actual overflow on constant operands > is observed. > > * gcc.dg/pr68317.c: Revert last change. LGTM. Jakub