* [committed] visium: Fix up visium_setup_incoming_varargs [PR114175]
@ 2024-03-20 16:08 Jakub Jelinek
2024-03-20 17:03 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2024-03-20 16:08 UTC (permalink / raw)
To: gcc-patches
Hi!
Like for x86-64, alpha or rs6000, visium seems to be affected too.
Just visually checked differences in c23-stdarg-9.c assembly in a cross
without/with the patch, committed to trunk.
2024-03-20 Jakub Jelinek <jakub@redhat.com>
PR target/114175
* config/visium/visium.cc (visium_setup_incoming_varargs): Only skip
TARGET_FUNCTION_ARG_ADVANCE for TYPE_NO_NAMED_ARGS_STDARG_P functions
if arg.type is NULL.
--- gcc/config/visium/visium.cc.jj 2024-01-03 11:51:47.166514192 +0100
+++ gcc/config/visium/visium.cc 2024-03-20 16:14:51.613422079 +0100
@@ -1482,7 +1482,8 @@ visium_setup_incoming_varargs (cumulativ
/* The caller has advanced ARGS_SO_FAR up to, but not beyond, the last named
argument. Advance a local copy of ARGS_SO_FAR past the last "real" named
argument, to find out how many registers are left over. */
- if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl)))
+ if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl))
+ || arg.type != NULL_TREE)
TARGET_FUNCTION_ARG_ADVANCE (local_args_so_far, arg);
/* Find how many registers we need to save. */
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [committed] visium: Fix up visium_setup_incoming_varargs [PR114175]
2024-03-20 16:08 [committed] visium: Fix up visium_setup_incoming_varargs [PR114175] Jakub Jelinek
@ 2024-03-20 17:03 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2024-03-20 17:03 UTC (permalink / raw)
To: Jakub Jelinek, gcc-patches
On 3/20/24 10:08 AM, Jakub Jelinek wrote:
> Hi!
>
> Like for x86-64, alpha or rs6000, visium seems to be affected too.
>
> Just visually checked differences in c23-stdarg-9.c assembly in a cross
> without/with the patch, committed to trunk.
>
> 2024-03-20 Jakub Jelinek <jakub@redhat.com>
>
> PR target/114175
> * config/visium/visium.cc (visium_setup_incoming_varargs): Only skip
> TARGET_FUNCTION_ARG_ADVANCE for TYPE_NO_NAMED_ARGS_STDARG_P functions
> if arg.type is NULL.
No gdbsim, so no execution results. Builds fine though.
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-20 17:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-20 16:08 [committed] visium: Fix up visium_setup_incoming_varargs [PR114175] Jakub Jelinek
2024-03-20 17:03 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).