From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BBD0E3858C35 for ; Thu, 21 Mar 2024 09:28:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BBD0E3858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BBD0E3858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711013311; cv=none; b=BDZzF9K15LJUEOj6/gewD3+MnCsxA2RuO2Ckq0GrXe8PYfIPRY4qYIP+nFmdAtHEdAwJr/iFJIBzNB4tWwKXuAsCb9eG2U+dTwTuVOVRk6G6KZX5CpJ0dKVwfS6VB39hoCNYb48FexGlv2AtfDBCvDGt96Pe73t1JVLMCzU9o60= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711013311; c=relaxed/simple; bh=0Ek+/F5cx4qArNu7lSrBq6CdRmM5HwY3gmdww2vFuxE=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=twMagBoSKPgWU2qdPkxWUECj+5wbj2BqHaCGRHCquu+cZaX3Q40hxnJItO9GqKivkb9N4S+EFI/055jc3A4bg5N9JGN2u5o5lWipOmzVjzmSh/7H78GF184mFz0ceCZusMxOqoaIxKupIRaYv/Ld6EReRVlBY2xxYD2Ybd5uXmA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711013309; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=oxA4AxVAh3JR2aHZL3tLQM4T1u0EMjYv7y7ybhI8Hps=; b=DtEUYKed9Hdo3TAPLEojnf7U6uNvT5khjCHdtB4C8C1NEA2fj+KfB82xCaIO83Rv7z7sA7 ddK11r4nr5GCuYt710MJlsj6Dx1HNqo4dBJUpoH0NCTh217VBvV0xtsZOQJV4X4LCcx7Ja NU3khQUf/XqkHCsxIOviXkMLoBHNsnU= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-248-t925hAH2NXCQfanH1WOa3Q-1; Thu, 21 Mar 2024 05:28:23 -0400 X-MC-Unique: t925hAH2NXCQfanH1WOa3Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 875EB383CCE1; Thu, 21 Mar 2024 09:28:22 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4AC3510189; Thu, 21 Mar 2024 09:28:22 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 42L9SF7w4071372 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 21 Mar 2024 10:28:15 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 42L9SExs4071371; Thu, 21 Mar 2024 10:28:14 +0100 Date: Thu, 21 Mar 2024 10:28:14 +0100 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org, ubizjak@gmail.com Subject: Re: [PATCH] tree-optimization/111736 - avoid address sanitizing of __seg_gs Message-ID: Reply-To: Jakub Jelinek References: <00997.124032105252600733@us-mta-75.us.mimecast.lan> MIME-Version: 1.0 In-Reply-To: <00997.124032105252600733@us-mta-75.us.mimecast.lan> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Mar 21, 2024 at 10:25:24AM +0100, Richard Biener wrote: > The following more thoroughly avoids address sanitizing accesses > to non-generic address-spaces. > > Bootstrapped and tested on x86_64-unknown-linux-gnu. > > OK? > > Thanks, > Richard. > > PR tree-optimization/111736 > * asan.cc (instrument_derefs): Do not instrument accesses > to non-generic address-spaces. > > * gcc.target/i386/pr111736.c: New testcase. > --- > gcc/asan.cc | 4 ++++ > gcc/testsuite/gcc.target/i386/pr111736.c | 23 +++++++++++++++++++++++ > 2 files changed, 27 insertions(+) > create mode 100644 gcc/testsuite/gcc.target/i386/pr111736.c > > diff --git a/gcc/asan.cc b/gcc/asan.cc > index cfe83106460..04caf8802e2 100644 > --- a/gcc/asan.cc > +++ b/gcc/asan.cc > @@ -2755,6 +2755,10 @@ instrument_derefs (gimple_stmt_iterator *iter, tree t, > if (VAR_P (inner) && DECL_HARD_REGISTER (inner)) > return; > > + /* Accesses to non-generic address-spaces are not handled. */ I'd say s/are not handled/should not be instrumented/ > + if (!ADDR_SPACE_GENERIC_P (TYPE_ADDR_SPACE (TREE_TYPE (inner)))) > + return; > + Otherwise LGTM. > poly_int64 decl_size; > if ((VAR_P (inner) > || (TREE_CODE (inner) == RESULT_DECL > diff --git a/gcc/testsuite/gcc.target/i386/pr111736.c b/gcc/testsuite/gcc.target/i386/pr111736.c > new file mode 100644 > index 00000000000..231fdd07e80 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/pr111736.c > @@ -0,0 +1,23 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -fsanitize=address" } */ > + > +int __seg_gs m; > + > +int foo (void) > +{ > + return m; > +} > + > +extern int __seg_gs n; > + > +int bar (void) > +{ > + return n; > +} > + > +int baz (int __seg_gs *o) > +{ > + return *o; > +} > + > +/* { dg-final { scan-assembler-not "asan_report_load" } } */ > -- > 2.35.3 Jakub