From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 726DC3858C98 for ; Thu, 4 Apr 2024 12:23:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 726DC3858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 726DC3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712233387; cv=none; b=UYCQuS7WnwH6DwDSCENhcyhhHVneKbowrjNn0BdRTJYXTpo0pjoXNZavRz/r2hq98Kl/GnNA+qCohiVDlne03WQPSygiqo9GiiGAn0eIOIX+Pq8gkwrb3h9Tdun2Ma432dyHlmQDVCmPAGXVpTGuxgepDkUO9EfXeR8It7PB3ss= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712233387; c=relaxed/simple; bh=mx8ww8GHVeKUfpRBysJCKdYt8OhGSvm6O+WzoL4U0Ag=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=NHXirfGTW2icBHA6W26N6SQZFNrdihrlfldR/4cuHpE2ii0T3I1ESljUWF73MHzZiSAIeH0ClkDKjyVCBfnhxI+2nzhAXbMJSat6og3gcmT/rqlffow8bkbTNrSHhzGf4rb3pBIUIy9pdOj6KG7aASDp/GBw1KsSQWQutTUKp+M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712233385; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Tp6Lb4PC2k0a/N+175CICuaVbV8kinoSghvziZp4Lyw=; b=AklZsQrS5dVjGNkFLo90CoW+rVeZEiO1PMIMl0YCb1fILf7lBGtMQp6yPvDZDG93q45kgN WjdfuB9kU0AA1tWh8w1hBaI97QGEAMyXys1G8SgFklZOPIPrvkMHP0CoGD/NDJUASzPlfw W5ylYauPdObCO+quvp0LtQA7A0iCdpY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-101-8AG7XtVDMvGgZY5fOcno3A-1; Thu, 04 Apr 2024 08:23:01 -0400 X-MC-Unique: 8AG7XtVDMvGgZY5fOcno3A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B2E585A588; Thu, 4 Apr 2024 12:23:01 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0FC118173; Thu, 4 Apr 2024 12:23:00 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 434CMtNL790365 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 4 Apr 2024 14:22:55 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 434CMsjR790364; Thu, 4 Apr 2024 14:22:54 +0200 Date: Thu, 4 Apr 2024 14:22:54 +0200 From: Jakub Jelinek To: Andreas Krebbel Cc: Ilya Leoshkevich , Andreas Krebbel , gcc-patches@gcc.gnu.org, Stefan Schulze Frielinghaus , Juergen Christ Subject: Re: [PATCH] libsanitizer: Do not mention MSan and DFSan in an error message Message-ID: Reply-To: Jakub Jelinek References: <20240404113858.854167-1-iii@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 04, 2024 at 02:19:08PM +0200, Andreas Krebbel wrote: > On 4/4/24 13:38, Ilya Leoshkevich wrote: > > Bootstrapped and regtested on s390x-redhat-linux. Ok for master? > > > > > > libsanitizer/ChangeLog: > > > > * sanitizer_common/sanitizer_linux_s390.cpp (AvoidCVE_2016_2143): > > Do not mention MSan and DFSan, which are not supported by GCC. > > Ok, Thanks! This then needs to be added to libsanitizer/LOCAL_PATCHES , otherwise it will disappear on the next merge from upstream. Though, I must say I'm not entirely convinced the change is worth the hassle on every libsanitizer merge. > > diff --git a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp > > index 74db831b0aa..65ba825fa97 100644 > > --- a/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp > > +++ b/libsanitizer/sanitizer_common/sanitizer_linux_s390.cpp > > @@ -212,7 +212,7 @@ void AvoidCVE_2016_2143() { > > return; > > Report( > > "ERROR: Your kernel seems to be vulnerable to CVE-2016-2143. Using ASan,\n" > > - "MSan, TSan, DFSan or LSan with such kernel can and will crash your\n" > > + "TSan or LSan with such kernel can and will crash your\n" > > "machine, or worse.\n" > > "\n" > > "If you are certain your kernel is not vulnerable (you have compiled it\n" Jakub