From: Jan Hubicka <hubicka@ucw.cz>
To: Martin Jambor <mjambor@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] ipa: Force args obtined through pass-through maps to the expected type (PR 113964)
Date: Fri, 5 Apr 2024 14:54:48 +0200 [thread overview]
Message-ID: <Zg_0mO4ChqLa6iGD@kam.mff.cuni.cz> (raw)
In-Reply-To: <ri6il0wm0mn.fsf@virgil.suse.cz>
> Hi,
>
> interactions of IPA-CP and IPA-SRA on the same data is a rather big
> source of issues, I'm afraid. PR 113964 is a situation where IPA-CP
> propagates an unsigned short in a union parameter into a function
> which itself calls a different function which has a same union
> parameter and both these union parameters are split with IPA-SRA. The
> leaf function however uses a signed short member of the union.
>
> In the calling function, we get the unsigned constant as the
> replacement for the union and it is then passed in the call without
> any type compatibility checks. Apparently on riscv64 it matters
> whether the parameter is signed or unsigned short and so the leaf
> function can see different values.
>
> Fixed by using useless_type_conversion_p at the appropriate place and
> if it fails, use force_value_to type as elsewhere in similar
> situations.
>
> Bootstrapped and tested on x86_64-linux, the reporter has also run the
> testsuite with this patch on riscv64 and reported in Bugzilla there were
> no issues.
>
> OK for master and GCC 13?
>
> Thanks,
>
> Martin
>
>
> gcc/ChangeLog:
>
> 2024-04-04 Martin Jambor <mjambor@suse.cz>
>
> PR ipa/113964
> * ipa-param-manipulation.cc (ipa_param_adjustments::modify_call):
> Force values obtined through pass-through maps to the expected
> split type.
>
> gcc/testsuite/ChangeLog:
>
> 2024-04-04 Patrick O'Neill <patrick@rivosinc.com>
> Martin Jambor <mjambor@suse.cz>
>
> PR ipa/113964
> * gcc.dg/ipa/pr114247.c: New test.
OK,
thanks!
Honza
prev parent reply other threads:[~2024-04-05 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 12:53 Martin Jambor
2024-04-05 12:54 ` Jan Hubicka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zg_0mO4ChqLa6iGD@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=mjambor@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).