From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3F72A3858D1E for ; Fri, 5 Apr 2024 21:50:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F72A3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3F72A3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712353860; cv=none; b=MV4CWezl7ilR1e4782jyu61xqMw9+A0gvR6xKBU1VTHD2M8yMnz5I0XMXk1MRHTaBZAb2Yjwta9eFgIc1vB/1XKqi3ZiL9d3iNPyuTRrFsOFOfKaMy42eljxDaWj6qgAxIlsaoTrnybO4gyKgMD2lsBRCxKBwLJ7cWaq4rS7zaE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712353860; c=relaxed/simple; bh=zXZaX5qcZ+hkZgeycJH+SRoV/t/IrJohbtuwXHdWCNo=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=skZ0Tf4Su8Ap5CF04OcT/opiNI7e/zHik36nGaNV9n+/KiAuRfx/GIElT6FfZ/5mEYE8M4MQumkYjy0QcN9wYEqcMp/Cik37z+/BZBkcByGuQ3NFtZTv8uSWn5R0trqth21K5p9qFARptSxfiwytAukDlGfhZljjRil1Duc5VsA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712353858; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=B8Jo+7rY18d9in6MiyovGPyqqPebnGDNNj54DJct5OY=; b=gz9tA7b6z+YYrtq8yW6gfc/wytIv0IcF0T4KK7tFZNXbh6/DuTbvqHz4ovjiI1JKzmbCHq JQZA+x+Rw/ZWxh7/25tQZEOhRsMEOHzTlFLbvkJXd0ZR6IYlTluxs80O5xgXdp9duP0R4j nSgSRybKjQYi1srGTzYzYh9yBJwgzHI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-HnuVWEUcN_Ch_zuUxeRp9g-1; Fri, 05 Apr 2024 17:50:56 -0400 X-MC-Unique: HnuVWEUcN_Ch_zuUxeRp9g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3740C185A781; Fri, 5 Apr 2024 21:50:56 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 45F0EC04121; Fri, 5 Apr 2024 21:50:55 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 435LonQw2573979 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 5 Apr 2024 23:50:49 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 435LolHp2573978; Fri, 5 Apr 2024 23:50:47 +0200 Date: Fri, 5 Apr 2024 23:50:47 +0200 From: Jakub Jelinek To: Jeff Law Cc: Segher Boessenkool , Richard Biener , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] rtl-optimization/101523 - avoid re-combine after noop 2->2 combination Message-ID: Reply-To: Jakub Jelinek References: <202404031107.433B7hCA019240@gate.crashing.org> <20240405212754.GL19790@gate.crashing.org> <6c387fd6-bf1d-45b5-b4bb-96a947217a5c@gmail.com> MIME-Version: 1.0 In-Reply-To: <6c387fd6-bf1d-45b5-b4bb-96a947217a5c@gmail.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Apr 05, 2024 at 03:46:30PM -0600, Jeff Law wrote: > > > On 4/5/24 3:27 PM, Segher Boessenkool wrote: > > Hi! > > > > On Wed, Apr 03, 2024 at 01:07:41PM +0200, Richard Biener wrote: > > > The following avoids re-walking and re-combining the instructions > > > between i2 and i3 when the pattern of i2 doesn't change. > > > > > > Bootstrap and regtest running ontop of a reversal of > > > r14-9692-g839bc42772ba7a. > > > > Please include that in the patch (or series, preferably). > > > > > It brings down memory use frmo 9GB to 400MB and compile-time from > > > 80s to 3.5s. r14-9692-g839bc42772ba7a does better in both metrics > > > but has shown code generation regressions across acrchitectures. > > > > > > OK to revert r14-9692-g839bc42772ba7a? > > > > No. > > > > The patch solved a very real problem. How does your replacement handle > > that? You don't say. It looks like it only battles symptoms a bit, > > instead :-( > But that patch very clearly created new problems in the process. I would > argue that it was a step backwards given that we're in stage4. Yeah. E.g. PR114518 and PR114522, both P1s. Jakub